Received: by 10.213.65.68 with SMTP id h4csp308514imn; Tue, 3 Apr 2018 21:37:17 -0700 (PDT) X-Google-Smtp-Source: AIpwx48kp2S1BfMAq6BBIiTLH+v1ve+rJ/CjHyLyPGpgKno9JwB6QocS2I/J12GBvV2QVSbyxUb0 X-Received: by 10.99.103.197 with SMTP id b188mr10982980pgc.108.1522816637277; Tue, 03 Apr 2018 21:37:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522816637; cv=none; d=google.com; s=arc-20160816; b=a2fGAV0zIYhryAJiw7NIfrSXVW7KF65qUaTUbhDCIyUjG0ousBNG61aeUhzXEISKYP c6+YhkwDLwUbDR3iRHWodK0uYzRxsj+U9GKvF04ZbJREDnSI8j8SA/bDICPJTlKCxi5j 8u+DNp1jmF+TIuB+EKy1zZfNqQT2mafTAf55gEFLrmhoXHG8WjsL06JMSrAmo+hvNKhG H9gR3vKkI+V7CuFnePDDKSEhSXPs4gFOtGTY68coB/0aasGGbsayhaxLvIB35hRtYuxj fT7Oyby9G3Be2/sr2BMA5JMWLHevw/xfya5EcpL4QJSCWbRlNqSIGarJ3DrgVcRVz+92 sW4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=MVSmCKIbXxPY5sPoPB9gfZDqWOHL3ToVP2ea7O2mk9o=; b=YrrMEvtobJTAIC5/CG9t/H82B8YtZ/OP3Gg+SS9fTQDGrS4WPlhE9SsybRgunjkmUB CBY7n68vRD/6Wna2whcF8vqrlFN0/2vc5fX4xGIrhYDx81sa5lFusQttbzombUCj3fx8 C1T9Fht8rGrmfQv+Y8iABsboBijmsmU0EiucYYlPVZhQytmM+sYu+jQV9huztRWVKb77 fA9ChwlgZ9QYTf8wjmWd+kDf/wuR3RZD6KcY0/3piN0EnQUaL4+H1y3LP8jMvBtdxtAj lX3tbnFd63lzUAN0baBLXPHENsWAwtsECbkB8jMODsp+koQy7yH14lH9CD1oOWpI7UEv 8ZRg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q24si3324588pff.13.2018.04.03.21.37.02; Tue, 03 Apr 2018 21:37:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751439AbeDDEea (ORCPT + 99 others); Wed, 4 Apr 2018 00:34:30 -0400 Received: from mga18.intel.com ([134.134.136.126]:28462 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750747AbeDDEe3 (ORCPT ); Wed, 4 Apr 2018 00:34:29 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Apr 2018 21:34:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,404,1517904000"; d="scan'208";a="44721769" Received: from bee.sh.intel.com (HELO bee) ([10.239.97.14]) by orsmga001.jf.intel.com with ESMTP; 03 Apr 2018 21:34:26 -0700 Received: from kbuild by bee with local (Exim 4.84_2) (envelope-from ) id 1f3a7t-0003z7-Ky; Wed, 04 Apr 2018 12:34:25 +0800 Date: Wed, 4 Apr 2018 12:34:08 +0800 From: kbuild test robot To: Paolo Pisati Cc: kbuild-all@01.org, Alan Tull , Moritz Fischer , Rob Herring , Mark Rutland , linux-fpga@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v10 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support Message-ID: <201804041222.0xEsTote%fengguang.wu@intel.com> References: <1522782152-27300-3-git-send-email-p.pisati@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1522782152-27300-3-git-send-email-p.pisati@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paolo, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.16 next-20180403] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Paolo-Pisati/dt-bindings-fpga-add-lattice-machxo2-slave-spi-binding-description/20180404-055540 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> drivers/fpga/machxo2-spi.c:86:19: sparse: cast to restricted __be32 >> drivers/fpga/machxo2-spi.c:86:19: sparse: cast to restricted __be32 >> drivers/fpga/machxo2-spi.c:86:19: sparse: cast to restricted __be32 >> drivers/fpga/machxo2-spi.c:86:19: sparse: cast to restricted __be32 >> drivers/fpga/machxo2-spi.c:86:19: sparse: cast to restricted __be32 >> drivers/fpga/machxo2-spi.c:86:19: sparse: cast to restricted __be32 drivers/fpga/machxo2-spi.c:369:12: sparse: no member 'parent' in struct fpga_manager >> drivers/fpga/machxo2-spi.c:375:33: sparse: not enough arguments for function fpga_mgr_register >> drivers/fpga/machxo2-spi.c:382:29: sparse: incorrect type in argument 1 (different base types) @@ expected struct device *dev @@ got structstruct device *dev @@ >> drivers/fpga/machxo2-spi.c:369:12: sparse: generating address of non-lvalue (8) drivers/fpga/machxo2-spi.c: In function 'machxo2_spi_probe': drivers/fpga/machxo2-spi.c:369:5: error: 'struct fpga_manager' has no member named 'parent' mgr->parent = dev; ^~ drivers/fpga/machxo2-spi.c:375:27: error: passing argument 1 of 'fpga_mgr_register' from incompatible pointer type [-Werror=incompatible-pointer-types] return fpga_mgr_register(mgr); ^~~ In file included from drivers/fpga/machxo2-spi.c:12:0: include/linux/fpga/fpga-mgr.h:173:5: note: expected 'struct device *' but argument is of type 'struct fpga_manager *' int fpga_mgr_register(struct device *dev, const char *name, ^~~~~~~~~~~~~~~~~ drivers/fpga/machxo2-spi.c:375:9: error: too few arguments to function 'fpga_mgr_register' return fpga_mgr_register(mgr); ^~~~~~~~~~~~~~~~~ In file included from drivers/fpga/machxo2-spi.c:12:0: include/linux/fpga/fpga-mgr.h:173:5: note: declared here int fpga_mgr_register(struct device *dev, const char *name, ^~~~~~~~~~~~~~~~~ drivers/fpga/machxo2-spi.c: In function 'machxo2_spi_remove': drivers/fpga/machxo2-spi.c:382:22: error: passing argument 1 of 'fpga_mgr_unregister' from incompatible pointer type [-Werror=incompatible-pointer-types] fpga_mgr_unregister(mgr); ^~~ In file included from drivers/fpga/machxo2-spi.c:12:0: include/linux/fpga/fpga-mgr.h:176:6: note: expected 'struct device *' but argument is of type 'struct fpga_manager *' void fpga_mgr_unregister(struct device *dev); ^~~~~~~~~~~~~~~~~~~ drivers/fpga/machxo2-spi.c: In function 'machxo2_spi_probe': drivers/fpga/machxo2-spi.c:376:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ cc1: some warnings being treated as errors vim +86 drivers/fpga/machxo2-spi.c 65 66 static int get_status(struct spi_device *spi, unsigned long *status) 67 { 68 struct spi_message msg; 69 struct spi_transfer rx, tx; 70 static const u8 cmd[] = LSC_READ_STATUS; 71 int ret; 72 73 memset(&rx, 0, sizeof(rx)); 74 memset(&tx, 0, sizeof(tx)); 75 tx.tx_buf = cmd; 76 tx.len = sizeof(cmd); 77 rx.rx_buf = status; 78 rx.len = 4; 79 spi_message_init(&msg); 80 spi_message_add_tail(&tx, &msg); 81 spi_message_add_tail(&rx, &msg); 82 ret = spi_sync(spi, &msg); 83 if (ret) 84 return ret; 85 > 86 *status = be32_to_cpu(*status); 87 88 return 0; 89 } 90 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation