Received: by 10.213.65.68 with SMTP id h4csp356044imn; Tue, 3 Apr 2018 22:51:25 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/0qDqQ/QZvjUUPwGoTviUj3vjfBr2Zw6RHRfMwf+rsRCog9LxAy9Ux7Gd/llMkBXsA3MO/ X-Received: by 10.98.234.6 with SMTP id t6mr11645386pfh.38.1522821085226; Tue, 03 Apr 2018 22:51:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522821085; cv=none; d=google.com; s=arc-20160816; b=nyR73tYAOxt4O0tcZnAXNC3Li3S0CkDseRvWenWILr1iY2R6RR8mSk1aCW1YpWjGuK 7A87OXp7t9DDE1TS9k01VqaCTdn7oKsagj3Jz/Kob89MLf/jNJb/1KEmKwvEJZAI/Nyw 7YBYVc4rhUt6lBQmEqaZ/ky6jD0KVSCSP65lTu5Vc+fMu7UmBP49VoR4gjmFEtmIqe6d t4HjPivcg9gHp9fhfP/e3+S3kIaYpyXBe+f8r5ARZmBCQJPz3ErgPMBPLr5qI3HVxtOx cSJ9e5iRZjk+xyxqKnUlFPcxt4Ie9YpwGi+VPNbqKspRd3sOcKfWP2OB1N/Mus1ljg+2 E9rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=aidsKB0UueAKsl9I00j8UYvyr2KjTt8EfbJbwa3cGdg=; b=iebw4DYfPJn8b1zEwdVPcRSqLlHzOkwZwpjSN5VRw62KxXxvQYbG2BGpyd5Yp93cGw xcGv6lgqYlBe/BmKNLKnNu5nXZfRPDo6pO0NcsuFasoa61xGS33/eP48ch+mlnX6vjdv CEJBNr3Xv/vDFMAvCtxFCz5kl9XSmYH9qytVtBwZtm5lDTLMejbxIprPTw1eER+JqVNN rABh3qr9jMpaM2RmPEh7MwyG2cenFUsAIcZkybmQADKQxObGkwe+r+FKwcROrCfXE1SW ExXjKi5I0WOwfyAe5bysok8bIqcRuni9y39G3vd94Tnfc1sQVbzMQGStCtQnCjOlpHxc X/jg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c16-v6si2437433plo.675.2018.04.03.22.51.10; Tue, 03 Apr 2018 22:51:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752012AbeDDFuE (ORCPT + 99 others); Wed, 4 Apr 2018 01:50:04 -0400 Received: from mga01.intel.com ([192.55.52.88]:32863 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751117AbeDDFuC (ORCPT ); Wed, 4 Apr 2018 01:50:02 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Apr 2018 22:50:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,405,1517904000"; d="scan'208";a="34107471" Received: from vkoul-udesk7.iind.intel.com (HELO localhost) ([10.223.84.143]) by fmsmga002.fm.intel.com with ESMTP; 03 Apr 2018 22:49:58 -0700 Date: Wed, 4 Apr 2018 11:24:21 +0530 From: Vinod Koul To: Geert Uytterhoeven Cc: Dan Williams , Ulf Hansson , "Rafael J . Wysocki" , Yoshihiro Shimoda , Kuninori Morimoto , Niklas =?iso-8859-1?Q?S=F6derlund?= , dmaengine@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: rcar-dmac: Fix too early/late system suspend/resume callbacks Message-ID: <20180404055420.GE15443@localhost> References: <1522342412-10126-1-git-send-email-geert+renesas@glider.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1522342412-10126-1-git-send-email-geert+renesas@glider.be> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 29, 2018 at 06:53:32PM +0200, Geert Uytterhoeven wrote: > If serial console wake-up is enabled ("echo enabled > > /sys/.../ttySC0/power/wakeup"), and any serial input is received while > the system is suspended, serial port input no longer works after system > resume. > > Note that: > 1) The system can still be woken up using the serial console, > 2) Serial port input keeps working if the system is woken up in some > other way (e.g. Wake-on-LAN or gpio-keys), and no serial input was > received while suspended. > > To fix this, replace SET_LATE_SYSTEM_SLEEP_PM_OPS() by > SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(), as the callbacks installed by the > former happen too early resp. late in the suspend resp. resume process. Applied, thanks -- ~Vinod