Received: by 10.213.65.68 with SMTP id h4csp413247imn; Wed, 4 Apr 2018 00:14:21 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+iQh/kv9dEgJQ7c66HTVTeO187Q/5+7sYCx63N/0a/P/VfnSDiZj0LurNrPIgNZPwtb1Nn X-Received: by 2002:a17:902:aa96:: with SMTP id d22-v6mr17300852plr.106.1522826061816; Wed, 04 Apr 2018 00:14:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522826061; cv=none; d=google.com; s=arc-20160816; b=XoDNmC8HCwJAdSaJAifasAxndP14CEJ4tNCEbkS9FQremRmVJMa7hmw4yhWKBe7aUi +dNjCX7fXwTWfFMJKRHG20b5fVc0fA2KJvNjU87GSKrw0xl5bQ6sun+pEotUZ5ZOPAWM NNlPO/DpfjlpB/YQUMtJg0J3ZMdDqTIGXOLzI0KaNDcCqWhQUuZgT3vnTMD8EchJx5Qg ybODcvtHPCjOJGSca1gLzDkj7+QXt6LDTrWa5accqRXbNMgigiMTm9hs2dDBNdTD+byg LkvW5IdHKhAZC8+GVSxBzuNAsrCgfuRtozPXzYppiJYc5pxSO0RDJvLV1juE2+fXB3GT 0mTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=fFi/QpOqCxGKYFQncr1M/y++5kx/2TfPEWYWTEFgK/Q=; b=QfeJK3/fGhXVf3wdRSsuNv4EuB3w+ZWjdHMBiff7Cd2mX7fV/L+tcw5u9quysdyU12 4ZzibByoxLtrtWiWbjlPVrv0NoguM1CEWDjwXoLURHNDtvDhv2GNRXzzDo6RzBpgEqqj cTTunE+KfGoiY2CIT1PVVAToub/XEIHtVxdJ0kprj4iTSYS00yRSCWpr0npPe4iMIsJq NLlGmwqqnik+56ctPShgBIzulvbMEivmGeMxzRvjAzglc/5UzUkUpdkPHOvtFZVxje/D 3gm3rrq9LrsBf9iJOM4RNoiQudGK8TvjlvHaHpCfMhkoge5cJjxvdwIC2jedETZSk+cs KMgA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h89-v6si2585876pld.48.2018.04.04.00.14.07; Wed, 04 Apr 2018 00:14:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751155AbeDDHNE (ORCPT + 99 others); Wed, 4 Apr 2018 03:13:04 -0400 Received: from mail.bootlin.com ([62.4.15.54]:38478 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750762AbeDDHND (ORCPT ); Wed, 4 Apr 2018 03:13:03 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id A2C5E2070F; Wed, 4 Apr 2018 09:13:01 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr [90.63.216.87]) by mail.bootlin.com (Postfix) with ESMTPSA id 754062037A; Wed, 4 Apr 2018 09:13:01 +0200 (CEST) Date: Wed, 4 Apr 2018 09:13:01 +0200 From: Maxime Ripard To: Sergey Suloev Cc: Mark Brown , Chen-Yu Tsai , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/6] spi: sun4i: coding style/readability improvements Message-ID: <20180404071301.hr3t225bt3dstikr@flea> References: <20180403152905.1524-1-ssuloev@orpaltech.com> <20180403152905.1524-4-ssuloev@orpaltech.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="y2vn7dmartpqftwe" Content-Disposition: inline In-Reply-To: <20180403152905.1524-4-ssuloev@orpaltech.com> User-Agent: NeoMutt/20180323 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --y2vn7dmartpqftwe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 03, 2018 at 06:29:02PM +0300, Sergey Suloev wrote: > Minor changes to fulfill the coding style and > improve the readability. Again, this is a very subjective statement. Overall, I'm not convinced by the idea of moving code around and shuffling variables assignments just for the sake of it. Maxime --=20 Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com --y2vn7dmartpqftwe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlrEevwACgkQ0rTAlCFN r3TD2Q//Scf0Mi1Q/oSNxw47xPh6H2oAWaUcl3smBNut+968VY+GN232ahOs9hCM TcJME+cKOoMaFzU+6yiI66Z6YHFao2SJZkBOtQSjIZqc+Eu3IgqSAltgTjzRk1pE KdhYDp/IL3Vovl+xOcRXFscbxukvjZl+8QpYb4hC+2QVxpIYjtXPJljgWc0Jlkis cqswxGrNBs1mtBfbtSiLCk/2bGUDlEQCmYtykjK0gx/dwxVVgZF9QxkzQKvCKR/r B3BV8yV5HQBJFJr/AQ64TPV2B5bMOdWVlzu+UKKXSNFjlhXfpZveqE3ycVInZTj5 yKsGgUqlqlAombxkL6RMHS3+uG3wE/Ko9DLNB/7qXx2lPFmmKl6Ndy89RrqwImJZ IO22+0lO2T968FRvVk6yN8HbnzvKkS+WlpoWdh03c12PK9Z/6cy3aOmME8ECNsKO r2r0uIzEpioteOvRuNW8kF8rUg2OAj8piqlWZ24HUHNEsBr1Hmpf5PuYPJ8VLEzL UpDO7ofGsg/WyNt40NV7wt0o8wJro3IZzmv+4A9o0ZEN8Z9gpHWUpcE/hVh4SLlU +lZKcwNPpMQaV8Itt9ETX4hw1Ke3FwcTSlwVEGiFMTFuvtmdjuMpclQDJxLjIJQz ILaeKJZJWvG10XuIXk2/G8+beOwQagCcVs+PX2fByEXnPkeGQqU= =KT/F -----END PGP SIGNATURE----- --y2vn7dmartpqftwe--