Received: by 10.213.65.68 with SMTP id h4csp414225imn; Wed, 4 Apr 2018 00:15:41 -0700 (PDT) X-Google-Smtp-Source: AIpwx49ToZFOY5E94BZS7M4Y0fCpYtyNwuk3JWj8Ih13TutZbUjR1fWJWC6VrwxokxMvjwh9bMaB X-Received: by 10.98.211.211 with SMTP id z80mr12864222pfk.16.1522826141721; Wed, 04 Apr 2018 00:15:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522826141; cv=none; d=google.com; s=arc-20160816; b=PFVFV6OFzxxSbKvo3sYtgsaC0ASPNs/NsAoq6gho/V/LE2JHy+5j559ZhouPndEh21 xQuXJHl6Da1qDQzF3eI5Sbj94w7Luu/w/BlmOHMks9a591orm3OxwTrMfw3EnAr1v5Kv WvuyLOlVmMQlJu98vffhxv5Xk0xklpARKwkr60yNsIptSXO0P0+CCGvhDZIN6nymJcAz TcoUCw216J33BHwYCbzK7RcYC1QWvGN6gaKjalV8ft4BMt8OGYmebKrDFi9ziCL6nGhT NrmaZJKkYySfJg84mnj2yhzgjbhhuPmzQ/F0VC5HL3QAMUfAXf93CXUt92gqUh84TR6W rLdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=qsvdpc0QBycJJuEve9o5+PHRBNcm+lOREsYp7m4nYio=; b=OcnAF7Hdemeps4PL2CIUOzhCl5QzQaaZOYV3mJf2ow5w4SRBEjYjiGr2hz0jevO/pt zRIXrO4O2FlmjbOGhvlOuKjRzic4qeC1afMDUZFMRw+h58LpyN7DDBIzJ+wNuNpqUFpZ IkERJhdCNZaBq1be4cFd2Pl2nUMTtpxRQC4TPIgn6WdZuTqFkb9g75QJPo+n35Cw0f9C /jcmlUQaxW7tI55wk7PnSrxt60eBJjLTBMfPiGt+nmVpzzovKD7M/1yE+GcrFcLvnVvw US1FJV3FIb+xnchMNT1Du176Vgw/QnA1p2ejzZUZlI9hi1ImDe606vfeuK3QE0mmeF/o 5ZaQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g16si3683721pfd.93.2018.04.04.00.15.27; Wed, 04 Apr 2018 00:15:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751384AbeDDHOQ (ORCPT + 99 others); Wed, 4 Apr 2018 03:14:16 -0400 Received: from mail.bootlin.com ([62.4.15.54]:38566 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750778AbeDDHOM (ORCPT ); Wed, 4 Apr 2018 03:14:12 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 1263F2070F; Wed, 4 Apr 2018 09:14:11 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr [90.63.216.87]) by mail.bootlin.com (Postfix) with ESMTPSA id DB49C2037A; Wed, 4 Apr 2018 09:14:10 +0200 (CEST) Date: Wed, 4 Apr 2018 09:14:10 +0200 From: Maxime Ripard To: Sergey Suloev Cc: Mark Brown , Chen-Yu Tsai , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/6] spi: sun4i: introduce register set/unset helpers Message-ID: <20180404071410.qhjela7b55oaecuu@flea> References: <20180403152905.1524-1-ssuloev@orpaltech.com> <20180403152905.1524-6-ssuloev@orpaltech.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zut6nqsjatua2up3" Content-Disposition: inline In-Reply-To: <20180403152905.1524-6-ssuloev@orpaltech.com> User-Agent: NeoMutt/20180323 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --zut6nqsjatua2up3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 03, 2018 at 06:29:04PM +0300, Sergey Suloev wrote: > Two helper functions were added in order to set/unset > specified flags in registers. Again, the diffstat is pretty neutral, so what is the benefit? Maxime --=20 Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com --zut6nqsjatua2up3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlrEe0EACgkQ0rTAlCFN r3QxQg//QzRrYiuAY5Cxm4evvkiU/H2F6YIQXyyq0mCTeWLBSEfqUc7kS2X15v28 +HyIKvjmEmlj7fv6x4dEg2QfUDwUNpGD2ulcM+2METzOQV3QSA6kpcxzpBkQx411 Ifwx3FbRSqH8ybKnElsamX/CX5cGWfs6rBZsgn/1ZyI151h7JjsvaDcyMnvQ3ux8 y0Hct9RaYHs3Jho441kpzzjVuqZKS1SK8HC2wB71KlLkt/3qy41rlYcY1O0+FvxD MJPNF+JEjCEhqcBxoaFt+6B4L+gHQmR8q+RaFNdoDD2ZjG5/Z6BvE9nGegNbMDjG yhcun3Qxny12x6raauM8Jdo4XCVwv+p28VCJBKt8EbKIdhkWUUy2vROLURK2QOQa CDG4twwPsUyocMCnEcpIt2vwtB6yomwK+RSpiPKblNd3W2LMyXr/ZbmGCgBiJ1Qf /yN9UGIt50dU/CBAECwY7Ti2ue1aqQyQ9Hl0CYbRg57dWsKR2YvfvSuF37III054 GK22N+TIiKbLtAS9CidYQp4AzsPy5xiavQQ6pZuD1UgmDwpxzVtvuhp/tjQldtu0 yRQ4+8tK/bTn5Odb0vHzlOSNR8qpBXhYrrWcRmhNBsdOyjJdLiFP1ML5KTo/h2k7 liXA/xVG8N74OTY1dlfhVjn27/G8v/5cv6BeSFzvx96JfGtBF8s= =6lhN -----END PGP SIGNATURE----- --zut6nqsjatua2up3--