Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1522830330.30374.3.camel@suse.com>
Subject: Re: [PATCH] usbip: vhc_hcd: prevent module being removed while
 device are attached
From:   Oliver Neukum <oneukum@suse.com>
To:     Shuah Khan <shuahkh@osg.samsung.com>,
        Greg KH <gregkh@linuxfoundation.org>
Cc:     valentina.manea.m@gmail.com, shuah@kernel.org,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Date:   Wed, 04 Apr 2018 10:25:30 +0200
In-Reply-To: <6022b8f0-821a-2d1c-8032-4b298835feae@osg.samsung.com>
References: <20180402205232.21659-1-shuahkh@osg.samsung.com>
         <20180403065618.GA1093@kroah.com>
         <6022b8f0-821a-2d1c-8032-4b298835feae@osg.samsung.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Am Dienstag, den 03.04.2018, 09:56 -0600 schrieb Shuah Khan:
> This is a virtual device associated to a real physical device on a different
> system. My concern is that if the module gets removed accidentally then it
> could disrupt access to the remote device. The remote nature of the device
> with several players involved makes this scenario a bit more complex than

Hi,

you would doubtlessly lose connection to that device. Yet you would
also lose connections if you down your network. You need to be root
to unload a module. You could overwrite your root filesystems or flash
your firmware. In general we cannot and don't try to protect root
from such accidents.

	Regards
		Oliver