Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: Build failure due commit 9217e566bdee
To:     Jarkko Nikula <jarkko.nikula@linux.intel.com>
CC:     <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
        Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>
References: <76f98816-9f0a-3eb7-e00e-82cf5935afd6@linux.intel.com>
From:   Mike Looijmans <mike.looijmans@topic.nl>
Organization: TOPIC
Message-ID: <1e269233-162c-0f40-6815-328c28c2a093@topic.nl>
Date:   Wed, 4 Apr 2018 10:00:39 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <76f98816-9f0a-3eb7-e00e-82cf5935afd6@linux.intel.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: nl
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

﻿On 04-04-18 09:22, Jarkko Nikula wrote:
> Hi
> 
> Today's head and linux-next doesn't compile due commit 9217e566bdee ("of_net: 
> Implement of_get_nvmem_mac_address helper"):
> 
> drivers/of/of_net.o: In function `of_get_nvmem_mac_address':
> .../drivers/of/of_net.c:100: undefined reference to `of_nvmem_cell_get'
> .../drivers/of/of_net.c:104: undefined reference to `nvmem_cell_read'
> .../drivers/of/of_net.c:106: undefined reference to `nvmem_cell_put'
> Makefile:1033: recipe for target 'vmlinux' failed
> make: *** [vmlinux] Error 1
> 
> Builds if I set CONFIG_NVMEM=y from CONFIG_NVMEM=m or revert above commit.
> 


I've been looking into it, but haven't come up with a proper solution.

The issue is that OF_NET now requires NVMEM as either not-present or built-in, 
but cannot support it as module.

I don't know if that requirement can be expressed. I think having nvnmem_core 
as a module doesn't make much sense anyway, but that's not up to me.

Moving the code from of to nvmem seems weird, but would solve it.


Kind regards,

Mike Looijmans
System Expert

TOPIC Products
Materiaalweg 4, NL-5681 RJ Best
Postbus 440, NL-5680 AK Best
Telefoon: +31 (0) 499 33 69 79
E-mail: mike.looijmans@topicproducts.com
Website: www.topicproducts.com

Please consider the environment before printing this e-mail