Received: by 10.213.65.68 with SMTP id h4csp576592imn; Wed, 4 Apr 2018 03:45:42 -0700 (PDT) X-Google-Smtp-Source: AIpwx49lJo09Kel6Y5FPwcCtEwAozdKOJ7FfcShQnBc7exTSB9/TF3/d2b4TbQyvLIs6sj7dQ9kK X-Received: by 10.98.160.92 with SMTP id r89mr13371886pfe.235.1522838741983; Wed, 04 Apr 2018 03:45:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522838741; cv=none; d=google.com; s=arc-20160816; b=JItg+gx7mWsoqNs3OvKeRcYGjk+aeWjbiXVgXmDMYZe7rEkRonFSjvBhONagtN20ht PFSWHHXTRyIE1sNBQzCpuG+HUV2zs/eyW+2wJaapPBLkUgeKJ8rrv5ukAcZ+dKWU4/f1 3HpwiOd6rF71iF0W1m/BKnjJg0DeoqEBrRZ3CFZAuieRZouJQofQcxTlvoQO3mo+jZCc acIkHgl3lhjv6HIM3qR9sFGijNOP2RUWV1RvYO9N78wnAPr+aTxbfFF6Iyyu/xAzznHg /1MtibhjyzgawCwve1rQIB2FM+Ub+YmhmtWg5huTigdtzGC6Nfd8tWpOHlxPZUJX2s1d Mlog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=qbYSiMKAm6xO/P024q+xiqaHhMNNT8ZI1QiJngmODg0=; b=A3ojfkgmkyQWG/ap52GT96S81NGUaWbfikPXPCSqlLYt5i5veRdKlv3hYTuhklO0qM ouE6fiwjxi/qFJ2l20jFOzfs5ANnu8+by+93Q5/tOLne1zOgndrv54sPMakNLPvBvw/o HKdi5qSQX9Zbb0Cd6Xz0KEijg9vC2f572W3sRYAYvlh9qAftbJHsLI2xaptJyINAhJaC tn4/T7DVb1hFh1h/E0U0FfuyopVBVBuP1K/fIaoZiF/E352BeJwQMUBsiJDJzd/zXDDj 3j6HoxfqEwP4X/x+k5twlq3jpgdVN5be7hJ4N97f34z5weo2ZCNkAmLKgnrEpLe/ZGel 8ClA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=lpCmgbru; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o33-v6si2778744plb.478.2018.04.04.03.45.28; Wed, 04 Apr 2018 03:45:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=lpCmgbru; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751312AbeDDKnO (ORCPT + 99 others); Wed, 4 Apr 2018 06:43:14 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:48196 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750827AbeDDKnN (ORCPT ); Wed, 4 Apr 2018 06:43:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=qbYSiMKAm6xO/P024q+xiqaHhMNNT8ZI1QiJngmODg0=; b=lpCmgbrubixwg5McVs9x1sW8b N5zjzuMSvY3YNrH1tk/wK56zTUjo+ogRuW7tvL2NaDeRA0bHIJDSDkXPEYawwMS0jTn26d3eQgAJC EuBzYPuxMUAxwcdSybqANdvgqzgsdwzSNA1987SDUkLGod2UrE2lEbU8TuAuh0M9MvK+k=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3fsT-0004si-LT; Wed, 04 Apr 2018 10:42:53 +0000 Received: from broonie by debutante with local (Exim 4.90_1) (envelope-from ) id 1f3fsS-0003FD-LQ; Wed, 04 Apr 2018 11:42:52 +0100 Date: Wed, 4 Apr 2018 11:42:52 +0100 From: Mark Brown To: Maxime Ripard Cc: Sergey Suloev , Chen-Yu Tsai , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/6] spi: core: handle timeout error from transfer_one() Message-ID: <20180404104252.GC7691@sirena.org.uk> References: <20180403152905.1524-1-ssuloev@orpaltech.com> <20180403152905.1524-2-ssuloev@orpaltech.com> <20180403155224.GA11578@sirena.org.uk> <20180403161824.GB11578@sirena.org.uk> <20180404070817.6cens44jvlmdaxtm@flea> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="69pVuxX8awAiJ7fD" Content-Disposition: inline In-Reply-To: <20180404070817.6cens44jvlmdaxtm@flea> X-Cookie: An idle mind is worth two in the bush. User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --69pVuxX8awAiJ7fD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 04, 2018 at 09:08:18AM +0200, Maxime Ripard wrote: > And I'm pretty sure that papering over an error returned by a driver > is not the right thing to do. We've got specific error handling for timeouts - they get accounted for separately in the stats. It *shouldn't* affect actual operation and AFAICT it doesn't. I think the main problem here is that the commit message is very unclear. --69pVuxX8awAiJ7fD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlrErCsACgkQJNaLcl1U h9C5Vgf+OToh7RTZkBZDR/42P3i4DVvulaQv12xyeiY8y0/cVS2T5BnlWo4H0xZ5 0NLmSRjaEJcf2hLnQE8vyOtDKHPYa/nfwdPmadimsvIHlKQ3Vumzw+8LP1WLgRxp GmIhOosBUZ2BuCaGeidlXu6fjT3Ngh34IHg4WOH3gx7++oclzzZQG3Ka0JCA/4fL U+tG+EUVbABd0UHznYj/j/5nuIW0Uga2ChsgpLPdZYU4vF0F1RPrHC79PfAdlQxZ T8LQQaCdUTYKvz/H0Os+fQygFssielvdpyGWppvE98o/BHmtdMWkbcoQqIVzMWw2 phnrI7nVJuAMpegLx/Bb0IouNVpNAg== =n2XR -----END PGP SIGNATURE----- --69pVuxX8awAiJ7fD--