Received: by 10.213.65.68 with SMTP id h4csp627290imn; Wed, 4 Apr 2018 04:41:59 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+wvIT17yhX5mgRvJH3vvXGiKwKgvo0RimUSfPiBeNhES6Z57qLYRy8rSNwI8VQZ7ypBBMA X-Received: by 10.167.128.81 with SMTP id y17mr6806176pfm.194.1522842119844; Wed, 04 Apr 2018 04:41:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522842119; cv=none; d=google.com; s=arc-20160816; b=gxEihOaj6l8N8wTZK/so223GeYRkXrwVILmwZbK0CEkmSTjTnrqsUjtDwlg3qrsnU6 96Z0XpyAy38xFfQtLfNliMY4XgKPIT2hsfYOOlKQ80MkL0xmEosngTH/8NSDIdPuBZ4k bm+cqzaJOX1bAfR1tPWJ3KOjrjYfAb+NMsFc1airBmzUtzMALunA4n4l2+0oUWHkW9Ba J0ROdB/yEn8uni8ohlLVb/bUw1rarkEVmCu35dEabWDBBgjLvW9TtPns+95WjxMtcchf EUvbKd3jWTgJQo5VmNRfXTBnj8uaRO9atbbCT4fqxYMlMeN75Sc3WcUTWXlN+C5H/7l+ TG4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=UKXAqMkndrhVsisbS5oZ2VPWof1nXJnmX0TWMhfcfw8=; b=E+jSe4JVUfOZiHfOnlNQJA5H7hkbzymnTnE1AFuT/rUDchmEyvyrFO8mJzHnxHshHw BDFv4sOtCaznahJTF3st7uzOon9bAq/Tdkfz1Nw1jPAnzYI8e45B9CJRuIVMWnKzqoHj KroMIGCFACMFibPDnqF4zxDzntBfj9wIUuhNKpHMvitKz1fd49bxKddcnAEncjfnz6ja qVLSGaaLGQFrCtuT7TNcjV5d9ZBEbwPuUkaXYW1cy5maec7RPETVTWYQIkP3JLnIrf0F pEvrc1P+FPKRp39dw60dNqbvn4OFemoKiDZHlmhJso1pfxCjD566vq2jfko+ZUhZZ2CB dYXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=jW6r1Qky; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y4si3604547pgs.671.2018.04.04.04.41.45; Wed, 04 Apr 2018 04:41:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=jW6r1Qky; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751443AbeDDLkf (ORCPT + 99 others); Wed, 4 Apr 2018 07:40:35 -0400 Received: from mail-io0-f181.google.com ([209.85.223.181]:39712 "EHLO mail-io0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751216AbeDDLkd (ORCPT ); Wed, 4 Apr 2018 07:40:33 -0400 Received: by mail-io0-f181.google.com with SMTP id v13so25955088iob.6; Wed, 04 Apr 2018 04:40:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=UKXAqMkndrhVsisbS5oZ2VPWof1nXJnmX0TWMhfcfw8=; b=jW6r1QkyuMthMMqyPiGPVOtSPs3qGGmc9rKkr4pez7FnV+rXNL6RsQGi/wr3jl2L0P gB3CXzUcdsqDN+xHFf9O7+onYMkHmEKpSW25nih05nqEvNitdetHgJmrLK2ro5VlM4HH UzO9iwQS8Nf9fWCPIFaFOx8jRqf6P4Q/uZpUe/Ca5eWvNtG1R48iBfqflAj4eFyelFgd UZBD4HWDAQgdk7jfeWPX1BP6WvKTfARtJKQATYbTdXoqtO4N1GhufQ6stJtpae4Ii5Mo MoSnbrwGv6aKQEqFOu+eHJJ/mkUjsKBGf7NnFmC2snTBgyi7f9/UGrk7OvWrolUXViim LTtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=UKXAqMkndrhVsisbS5oZ2VPWof1nXJnmX0TWMhfcfw8=; b=uiuVla3Wc8a5vpZQ2pBZ1qyok5VvzTWwFt9e2jY7wuPh29SHjd5FyXHxntFtQVHRo8 oWMve1NdlGRi6EsOoy2CS6NmUS1lVx6qvd4rlMMVTXkQHSTFTn3mEvIs62A0UwoI2aIY MWHRJYk2/XjDJoZN+u81Ysx+jOVMwzp0f5tzHJ9o2wRQ0mKd1rfjcA7VNy/MzdqLweRo vPKsRdAib93pYEc5R2I7MJFT9h8D78IW29T3WskpnfmVXKZaQgKehb0kEa+OkdDZTxmB 8wfDe/ESUw508A25WP+/GqUoMnYDQQ/bb2BH0d3dgMS/a+Bc12m1mmWB+ujiluUln92B X2WA== X-Gm-Message-State: AElRT7G3C2Q6H+jToVYs1sRs8nyrVMvwiqfnHBgNHJHBczhOriI6YtsO cMYMSQjLDqpvfI1KtBv00zbCXnc1/MhPw8OtzqA= X-Received: by 10.107.15.144 with SMTP id 16mr16930319iop.108.1522842032675; Wed, 04 Apr 2018 04:40:32 -0700 (PDT) MIME-Version: 1.0 Received: by 10.213.85.204 with HTTP; Wed, 4 Apr 2018 04:40:32 -0700 (PDT) In-Reply-To: <20180404095604.GD3881@phenom.ffwll.local> References: <20180403224225.26776-1-robdclark@gmail.com> <307adb15-412a-1fe2-f116-27fe5b4a657d@shipmail.org> <20180404084320.GA3881@phenom.ffwll.local> <20180404095604.GD3881@phenom.ffwll.local> From: Rob Clark Date: Wed, 4 Apr 2018 07:40:32 -0400 Message-ID: Subject: Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb To: Thomas Hellstrom , Rob Clark , =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= , dri-devel , freedreno , linux-arm-msm , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Lukasz Spintzyk , Deepak Singh Rawat , Gustavo Padovan , Maarten Lankhorst , Sean Paul , David Airlie , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 4, 2018 at 5:56 AM, Daniel Vetter wrote: > On Wed, Apr 04, 2018 at 11:10:08AM +0200, Thomas Hellstrom wrote: >> On 04/04/2018 10:43 AM, Daniel Vetter wrote: >> > On Wed, Apr 04, 2018 at 10:22:21AM +0200, Thomas Hellstrom wrote: >> > > Hi, >> > > >> > > On 04/04/2018 08:58 AM, Daniel Vetter wrote: >> > > > On Wed, Apr 4, 2018 at 12:42 AM, Rob Clark wrote: >> > > > > Add an atomic helper to implement dirtyfb support. This is needed to >> > > > > support DSI command-mode panels with x11 userspace (ie. when we can't >> > > > > rely on pageflips to trigger a flush to the panel). >> > > > > >> > > > > To signal to the driver that the async atomic update needs to >> > > > > synchronize with fences, even though the fb didn't change, the >> > > > > drm_atomic_state::dirty flag is added. >> > > > > >> > > > > Signed-off-by: Rob Clark >> > > > > --- >> > > > > Background: there are a number of different folks working on getting >> > > > > upstream kernel working on various different phones/tablets with qcom >> > > > > SoC's.. many of them have command mode panels, so we kind of need a >> > > > > way to support the legacy dirtyfb ioctl for x11 support. >> > > > > >> > > > > I know there is work on a proprer non-legacy atomic property for >> > > > > userspace to communicate dirty-rect(s) to the kernel, so this can >> > > > > be improved from triggering a full-frame flush once that is in >> > > > > place. But we kinda needa a stop-gap solution. >> > > > > >> > > > > I had considered an in-driver solution for this, but things get a >> > > > > bit tricky if userspace ands up combining dirtyfb ioctls with page- >> > > > > flips, because we need to synchronize setting various CTL.FLUSH bits >> > > > > with setting the CTL.START bit. (ie. really all we need to do for >> > > > > cmd mode panels is bang CTL.START, but is this ends up racing with >> > > > > pageflips setting FLUSH bits, then bad things.) The easiest soln >> > > > > is to wrap this up as an atomic commit and rely on the worker to >> > > > > serialize things. Hence adding an atomic dirtyfb helper. >> > > > > >> > > > > I guess at least the helper, with some small addition to translate >> > > > > and pass-thru the dirty rect(s) is useful to the final atomic dirty- >> > > > > rect property solution. Depending on how far off that is, a stop- >> > > > > gap solution could be useful. >> > > > Adding Noralf, who iirc already posted the full dirty helpers already somewhere. >> > > > -Daniel >> > > I've asked Deepak to RFC the core changes suggested for the full dirty blob >> > > on dri-devel. It builds on DisplayLink's suggestion, with a simple helper to >> > > get to the desired coordinates. >> > > >> > > One thing to perhaps discuss is how we would like to fit this with >> > > front-buffer rendering and the dirty ioctl. In the page-flip context, the >> > > dirty rects, like egl's swapbuffer_with_damage is a hint to restrict the >> > > damage region that can be fully ignored by the driver, new content is >> > > indicated by a new framebuffer. >> > > >> > > We could do the same for frontbuffer rendering: Either set a dirty flag like >> > > you do here, or provide a content_age state member. Since we clear the dirty >> > > flag on state copies, I guess that would be sufficient. The blob rectangles >> > > would then become a hint to restrict the damage region. >> > I'm not entirely following here - I thought for frontbuffer rendering the >> > dirty rects have always just been a hint, and that the driver was always >> > free to re-upload the entire buffer to the screen. >> > >> > And through a helper like Rob's proposing here (and have floated around in >> > different versions already) we'd essentially map a frontbuffer dirtyfb >> > call to a fake flip with dirty rect. Manual upload drivers already need to >> > upload the entire screen if they get a flip, since some userspace uses >> > that to flush out frontbuffer rendering (instead of calling dirtyfb). >> > >> > So from that pov the new dirty flag is kinda not necessary imo. >> > >> > > Another approach would be to have the presence of dirty rects without >> > > framebuffer change to indicate frontbuffer rendering. >> > > >> > > I think I like the first approach best, although it may be tempting for >> > > user-space apps to just set the dirty bit instead of providing the full >> > > damage region. >> > Or I'm not following you here, because I don't quite see the difference >> > between dirtyfb and a flip. >> > -Daniel >> >> OK, let me rephrase: >> >> From the driver's point-of-view, in the atomic world, new content and the >> need for manual upload is indicated by a change in fb attached to the plane. >> >> With Rob's patch here, (correct me if I'm wrong) in addition new content and >> the need for manual upload is identified by the dirty flag, (since the fb >> stays the same and the driver thus never identifies a page-flip). > > Hm, I'm not entirely sure Rob's approach is correct. Imo a pageflip > (atomic or not) should result in the entire buffer getting uploaded. The > dirty flag is kinda redundant, a flip with the same buffer works the same > way as a dirtyfb with the entire buffer as the dirty rectangle. Userspace could do a pageflip, but (with buffer-age extension) only re-render part of the frame. So there is a use-case for full frame pageflip with hints about what region(s) changed since previous frame. (Of course userspace could screw that up and get different results on "command" vs "video" style display.. in that case, it gets to keep both pieces) BR, -R >> In both these situations, clip rects can provide a hint to restrict the >> dirty region. >> >> Now I was thinking about the preferred way for user-space to communicate >> front buffer rendering through the atomic ioctl: >> >> 1) Expose a dirty (or content_age property) >> 2) Attach a clip-rect blob property. >> 3) Fake a page-flip by ping-ponging two frame-buffers pointing to the same >> underlying buffer object. >> >> Are you saying that people are already using 3) and we should keep using >> that? > > I'm saying they're using 3b), flip the same buffer wrapped in the same > drm_framebuffer, and expect it to work. > > The only advantage dirtyfb has is that it allows you to supply the > optimized upload rectangles, but at the cost of a funny api (it's working > on the fb, not the plane/crtc you want to upload) and lack of drm_event to > confirm when exactly you uploaded your stuff. But imo they should be the > same underlying operation. > > Also note that atomic helpers don't optimize out plane flips for same > buffers. We only optimize out some of the waiting, in a failed attempt at > making cursors stall less, but that's not fixed with the async plane > update stuff. And we can obviously optimize out the prepare/cleanup hooks, > because the buffer should be pinned already. > > So imo for a quick fix I think we need: > 1) Fix drivers (or at least msm) to upload buffers for manual upload on > all flips (well, all screen updates). Probably should do the fence waiting > unconditionally too (and handle cursors with the new async stuff). > 2) Tiny helper that remaps a dirtyfb call into a nonblocking atomic > commit, which currently means we're throwing the dirty rect optimization > into the wind. But that could easily be added to the drm_plane_state, > without exposing it to userspace as a property just yet. > > Cheers, Daniel > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch