Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Michael Kelley (EOSG)" <Michael.H.Kelley@microsoft.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
        "olaf@aepfle.de" <olaf@aepfle.de>,
        "apw@canonical.com" <apw@canonical.com>,
        "vkuznets@redhat.com" <vkuznets@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "leann.ogasawara@canonical.com" <leann.ogasawara@canonical.com>,
        "marcelo.cerri@canonical.com" <marcelo.cerri@canonical.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        KY Srinivasan <kys@microsoft.com>
Subject: RE: [PATCH v2 char-misc 1/1] x86/hyperv: Add interrupt handler
 annotations
Thread-Topic: [PATCH v2 char-misc 1/1] x86/hyperv: Add interrupt handler
 annotations
Thread-Index: AQHTy46r2zHDLe9OVEGvzyWeLTm/y6PwQ1mAgAAxeOA=
Date:   Wed, 4 Apr 2018 15:47:03 +0000
Message-ID: <DM5PR2101MB10306FD0D4DD653D7878C2BEDCA40@DM5PR2101MB1030.namprd21.prod.outlook.com>
References: <1522789148-1787-1-git-send-email-mikelley@microsoft.com>
 <20180404081629.GA22277@kroah.com>
In-Reply-To: <20180404081629.GA22277@kroah.com>
Accept-Language: en-US
Content-Language: en-US
msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=mikelley@ntdev.microsoft.com;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2018-04-04T15:46:59.3288523Z;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure
 Information Protection;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic;
 Sensitivity=General
x-originating-ip: [12.130.117.190]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1;DM5PR2101MB0869;7:HpllYzaSFWX3uA+icJoKo6MMfJGJHJjB08HV8wQAbFzTtjRpcv5DS21INNhTfcZoNNn96TEvhUDZrOW7GZZ8/IaQnzSiT4T8O4MNfU/H5mEDlIrHPXldpAR+lmEJfLWJNfie/KOV30uoNsPYjutqli3C6pJ+xvppi3PGs/CdvwQH7wqVLPJlyMMBCsrZJoUyp/qC5vDvbzW2TKMrjmDBZ/j3AQshA0z8War7gdB/gnkQ0tkuBoCiPEvto9q87E8d;20:GV7oblrGKYaXRbYnjsXjrFKk+85UtA04h7drvcDNcvSJ26KaumypDXfr8arwhIDTYaJQzbds6tCga/HuKa7dxhxU7KbTGWjphTf315x+X87Baf3ga6mS7+gdnl2i3uKQ0X1w8M29CgUAI84xUgK6WX2x3DdG0EEOVL2IKSVSVXw=
x-ms-exchange-antispam-srfa-diagnostics: SOS;
x-ms-office365-filtering-correlation-id: 7967f83c-a3f3-48bd-a1bb-08d59a434ff8
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4604075)(3008032)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7193020);SRVR:DM5PR2101MB0869;
x-ms-traffictypediagnostic: DM5PR2101MB0869:
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=Michael.H.Kelley@microsoft.com; 
x-microsoft-antispam-prvs: <DM5PR2101MB0869EC859BF7A180102E1273DCA40@DM5PR2101MB0869.namprd21.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(9452136761055)(85827821059158)(198206253151910);
x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(61425038)(6040522)(2401047)(8121501046)(5005006)(3231221)(944501327)(52105095)(93006095)(93001095)(10201501046)(3002001)(6055026)(61426038)(61427038)(6041310)(20161123558120)(20161123564045)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:DM5PR2101MB0869;BCL:0;PCL:0;RULEID:;SRVR:DM5PR2101MB0869;
x-forefront-prvs: 0632519F33
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(39380400002)(39860400002)(346002)(396003)(376002)(199004)(189003)(13464003)(7696005)(6246003)(102836004)(316002)(59450400001)(22452003)(76176011)(33656002)(3280700002)(3660700001)(6506007)(486006)(53546011)(2906002)(54906003)(2900100001)(107886003)(8990500004)(10090500001)(74316002)(305945005)(106356001)(7736002)(97736004)(5660300001)(10290500003)(6436002)(6116002)(3846002)(6916009)(86612001)(14454004)(86362001)(229853002)(966005)(53936002)(6306002)(9686003)(105586002)(26005)(186003)(66066001)(5250100002)(8676002)(81166006)(99286004)(81156014)(8936002)(478600001)(476003)(68736007)(11346002)(4326008)(72206003)(446003)(25786009)(55016002);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR2101MB0869;H:DM5PR2101MB1030.namprd21.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: microsoft.com does not designate
 permitted sender hosts)
x-microsoft-antispam-message-info: v1p0hYtw34VSi4roj3SM092eAGE5UOBf485DDazqoXz3f8MM/33EVNB+7LpMKxwYXXJO8TZWk3gN+52Ux06bcCv7d6+k/tELTnZ3JnB72lYu/skU6ia46mBlQq2FdZh9qZPdr2h7JA/dNpOvwBatYqnY8Dt1lGSd2ykAKAh9UZWEEBfkT6VbYjOlMI5l20cAkUOYfhG4nSQXJTV7lRZ/hIZx6slsGERi6zV4GI8LsC0XyZNV6vH2hmsh17mp5j0uZK7hlNAXLIWpwRgXpFVN7xPIaKfXEC4l3pjFB/hAFv5KhqDkaCrh7M17P7TUeAlyQfGURQOFuDkNggpapctWO2vSi95lVnH9aZ0lwFhHZjxp1oNoKSlSOOuosTEBBUBZT41BWO//ozzejW0AO4Oi+kuLhhM7gcVA+TgsfevAaPQ=
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7967f83c-a3f3-48bd-a1bb-08d59a434ff8
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Apr 2018 15:47:03.6255
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB0869
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Wednesday, April 4, 2018 1:16 AM
> To: Michael Kelley (EOSG) <Michael.H.Kelley@microsoft.com>
> Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepf=
le.de;
> apw@canonical.com; vkuznets@redhat.com; jasowang@redhat.com;
> leann.ogasawara@canonical.com; marcelo.cerri@canonical.com; Stephen Hemmi=
nger
> <sthemmin@microsoft.com>; KY Srinivasan <kys@microsoft.com>
> Subject: Re: [PATCH v2 char-misc 1/1] x86/hyperv: Add interrupt handler a=
nnotations
>=20
> On Tue, Apr 03, 2018 at 01:59:08PM -0700, mhkelley58@gmail.com wrote:
> > From: Michael Kelley <mikelley@microsoft.com>
> >
> > Add standard interrupt handler annotations to
> > hyperv_vector_handler().
> >
> > Signed-off-by: Michael Kelley <mikelley@microsoft.com>
> > ---
> > Changes in v2:
> > * Fixed From: line
> > ---
> >  arch/x86/kernel/cpu/mshyperv.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyp=
erv.c
> > index 4488cf0..20f6849 100644
> > --- a/arch/x86/kernel/cpu/mshyperv.c
> > +++ b/arch/x86/kernel/cpu/mshyperv.c
> > @@ -41,7 +41,7 @@ static void (*hv_stimer0_handler)(void);
> >  static void (*hv_kexec_handler)(void);
> >  static void (*hv_crash_handler)(struct pt_regs *regs);
> >
> > -void hyperv_vector_handler(struct pt_regs *regs)
> > +__visible void __irq_entry hyperv_vector_handler(struct pt_regs *regs)
>=20
> What bug does this solve?  What is wrong with the existing markings?
> What does __visible and __irq_entry give us that we don't already have
> and we need?
>=20
> Are you really using LTO that requires this marking to prevent the code
> from being removed?

Thomas Gleixner commented on Vitaly Kuznetsov's Hyper-V reenlightenment pat=
ch
that the interrupt handler should have these annotations: see
https://lkml.org/lkml/2018/1/14/145

I put the same annotations on the interrupt handler for stimer0 Direct Mode=
,
So this change makes the hyperv_vector_handler() consistent with
hv_stimer0_vector_handler() in the same source file.  It does not fix any
immediate bug -- it's for consistency and alignment with what is apparently
standard practice.

Not sure what LTO is ...

Michael

>=20
> thanks,
>=20
> greg k-h