Received: by 10.213.65.68 with SMTP id h4csp969362imn; Wed, 4 Apr 2018 10:13:52 -0700 (PDT) X-Google-Smtp-Source: AIpwx49k/tKpd9uARNyMz8jupGZhp7lHUtQg5AI8jwM9Y/YKlJP8TD4WA9XJynHN365wABQH88Ob X-Received: by 2002:a17:902:9a82:: with SMTP id w2-v6mr19157705plp.6.1522862032588; Wed, 04 Apr 2018 10:13:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522862032; cv=none; d=google.com; s=arc-20160816; b=v/Bi5VSMWyafUGEfxZq2juSbBwULcNlJbaRYtxv89Ud6KIB84dn+2E1MbR/fqTze8V krjAIoYU1WHZadnvlF4HRo2fJsrhBKJGooLqAsdZjxvH6ixzr6Na8oNa4WZMeSE9JMvk JlL7KJ+D7hfV0v4iiCzLtJsufaIp7mxxAS5lfY/HIBsM4keb5Wd74FpfOTxTdRqiWOYr L0z26GplAkBqvwNHKzaOYHCfGTCKoJIZEuhRWXZDAtQj1/ExL8YMj3OtW66TgbqnXMeS NfF/+MwQE0HTbPhy2ruCOoAoLfTr4hIQvPa6fNp23ePFZKl0qjJhH83xzHj2ZzVNd6J6 EVhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature:arc-authentication-results; bh=qhd2AMU3vEm1IYKOc48MqkrXmlslAlVJVYFu19x8WvY=; b=JL8OJosREAV31YuSMJwJMOLz1yO0KwxrNeeMQoqzz+P4qVL1gFtlfO85BuQVEQiZ73 bAAzw7xqdaq6LGsxVzup0f6t3JhZxQuvOEkg2Szp+stgX+KWryp7EzRuYmOKZ43H3bIn 7EbJg8c3ddhMxdWYbYY5vApFVNMuO8h9jfSAAGKl1j4dGvB96McHimejL1nb62YLbW0E Ryf90RNX0PAT7NF/O+liLrsRMCwd7Oj00D4u5+ZAHCaacD4VXfJcZP/daHl/upHzTArw FlT5VNEjiH+ODx89wPX3AvLkWBNmYbZHBcflJ/9/iEbz7QXVcoT1qsmLz/LBK7hUa8jf +fiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=eP7aygBD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d68si4360669pfl.337.2018.04.04.10.13.38; Wed, 04 Apr 2018 10:13:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=eP7aygBD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752751AbeDDRMS (ORCPT + 99 others); Wed, 4 Apr 2018 13:12:18 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:39770 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752100AbeDDRMQ (ORCPT ); Wed, 4 Apr 2018 13:12:16 -0400 Received: by mail-wm0-f53.google.com with SMTP id f125so44449651wme.4; Wed, 04 Apr 2018 10:12:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:openpgp:autocrypt:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qhd2AMU3vEm1IYKOc48MqkrXmlslAlVJVYFu19x8WvY=; b=eP7aygBDc20HX/Gsx56EPiix/cBQ6DbN9OU+iMe51jPAMrM5R7d4RuhAz/soq9XLXy 1aXSMY9nF3w0cUhLfVz/o946foLWbWJMcd03F+70a1vD8fNe/Kf7VXj9jKTk48n2PpJW xm34ilmDKUrCVF2Zsu2kvnDMX3nZzr31kXdfKSmeEJLej1zKKqp1prVOMcFenUBLv6Vn bMsbdSbJwCIi3/gQPrJ66RwZOXeV1ttZ2YWcp7hii/C47TLylH4/2ZBaqBpTBqs7DO2x 3cQX28KW51peBD7D7dEH/CnpsShYAy5uZ/fqv9OoUjtaC7j9UPUuF8MQcCFXb4JT/mTW bqXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:openpgp :autocrypt:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=qhd2AMU3vEm1IYKOc48MqkrXmlslAlVJVYFu19x8WvY=; b=OlwYqi8+xJmfVOKyHiQXW+pd0x2QKYth+qCLXaDPyC62hvAkFpQfFVjukzvCHWNedY YmKUOiBVxIwbNOet/+7UusJNIcY9p2JNip+/xlnFxQy4DHBECF+NrmMaUIZPmpwBUoZM 0oo7Spx3op+ooHQSBf5L5txgE1rsJrjiXF+P2Vn85Zu/hyR6BfACvrOhDhN5hW3efPdq a7HdXvEH1NaElgbuFG1VGUXs9FgdPKqsFBr1SadH6+uFL99qTBqMM6SUR1+rpKYNkEYJ Lf+2PmqYqiw6ETb8WD2DCnNM4M0pZNNsz1PGgCTQ8IWm9G6THH1xQlnnmm/Z18xYsaOw YpeQ== X-Gm-Message-State: AElRT7EQg6tHWpZGSRrP2mNKRx3l7RkULASDlHeOUYIySMLFKOcCuamb I5N2ZSM7IF/pbN2+ZtmabCA= X-Received: by 10.28.51.6 with SMTP id z6mr7570237wmz.63.1522861934825; Wed, 04 Apr 2018 10:12:14 -0700 (PDT) Received: from [192.168.10.165] (94-36-194-48.adsl-ull.clienti.tiscali.it. [94.36.194.48]) by smtp.googlemail.com with ESMTPSA id n49sm3502808wrn.50.2018.04.04.10.12.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Apr 2018 10:12:14 -0700 (PDT) Subject: Re: [PATCH v5 1/2] KVM: X86: Introduce handle_ud() To: David Hildenbrand , Wanpeng Li , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Andrew Cooper , Konrad Rzeszutek Wilk , Liran Alon References: <1522798129-14588-1-git-send-email-wanpengli@tencent.com> <1522798129-14588-2-git-send-email-wanpengli@tencent.com> <9d68b1b4-04e6-46d6-70b4-6ebcb0a0c4aa@redhat.com> From: Paolo Bonzini Openpgp: preference=signencrypt Autocrypt: addr=pbonzini@redhat.com; keydata= xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0f UGFvbG8gQm9uemluaSA8Ym9uemluaUBnbnUub3JnPsLBTQQTAQIAIwUCVEJ7AwIbAwcLCQgH AwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEH4VEAzNNmmxNcwOniaZVLsuy1lW/ntYCA0Caz0i sHpmecK8aWlvL9wpQCk4GlOX9L1emyYXZPmzIYB0IRqmSzAlZxi+A2qm9XOxs5gJ2xqMEXX5 FMtUH3kpkWWJeLqe7z0EoQdUI4EG988uv/tdZyqjUn2XJE+K01x7r3MkUSFz/HZKZiCvYuze VlS0NTYdUt5jBXualvAwNKfxEkrxeHjxgdFHjYWhjflahY7TNRmuqPM/Lx7wAuyoDjlYNE40 Z+Kun4/KjMbjgpcF4Nf3PJQR8qXI6p3so2qsSn91tY7DFSJO6v2HwFJkC2jU95wxfNmTEUZc znXahYbVOwCDJRuPrE5GKFd/XJU9u5hNtr/uYipHij01WXal2cce1S5mn1/HuM1yo1u8xdHy IupCd57EWI948e8BlhpujUCU2tzOb2iYS0kpmJ9/oLVZrOcSZCcCl2P0AaCAsj59z2kwQS9D du0WxUs8waso0Qq6tDEHo8yLCOJDzSz4oojTtWe4zsulVnWV+wu70AioemAT8S6JOtlu60C5 dHgQUD1Tp+ReXpDKXmjbASJx4otvW0qah3o6JaqO79tbDqIvncu3tewwp6c85uZd48JnIOh3 utBAu684nJakbbvZUGikJfxd887ATQRUQnHuAQgAx4dxXO6/Zun0eVYOnr5GRl76+2UrAAem Vv9Yfn2PbDIbxXqLff7oyVJIkw4WdhQIIvvtu5zH24iYjmdfbg8iWpP7NqxUQRUZJEWbx2CR wkMHtOmzQiQ2tSLjKh/cHeyFH68xjeLcinR7jXMrHQK+UCEw6jqi1oeZzGvfmxarUmS0uRuf fAb589AJW50kkQK9VD/9QC2FJISSUDnRC0PawGSZDXhmvITJMdD4TjYrePYhSY4uuIV02v02 8TVAaYbIhxvDY0hUQE4r8ZbGRLn52bEzaIPgl1p/adKfeOUeMReg/CkyzQpmyB1TSk8lDMxQ zCYHXAzwnGi8WU9iuE1P0wARAQABwsEzBBgBAgAJBQJUQnHuAhsMAAoJEH4VEAzNNmmxp1EO oJy0uZggJm7gZKeJ7iUpeX4eqUtqelUw6gU2daz2hE/jsxsTbC/w5piHmk1H1VWDKEM4bQBT uiJ0bfo55SWsUNN+c9hhIX+Y8LEe22izK3w7mRpvGcg+/ZRG4DEMHLP6JVsv5GMpoYwYOmHn plOzCXHvmdlW0i6SrMsBDl9rw4AtIa6bRwWLim1lQ6EM3PWifPrWSUPrPcw4OLSwFk0CPqC4 HYv/7ZnASVkR5EERFF3+6iaaVi5OgBd81F1TCvCX2BEyIDRZLJNvX3TOd5FEN+lIrl26xecz 876SvcOb5SL5SKg9/rCBufdPSjojkGFWGziHiFaYhbuI2E+NfWLJtd+ZvWAAV+O0d8vFFSvr iy9enJ8kxJwhC0ECbSKFY+W1eTIhMD3aeAKY90drozWEyHhENf4l/V+Ja5vOnW+gCDQkGt2Y 1lJAPPSIqZKvHzGShdh8DduC0U3xYkfbGAUvbxeepjgzp0uEnBXfPTy09JGpgWbg0w91GyfT /ujKaGd4vxG2Ei+MMNDmS1SMx7wu0evvQ5kT9NPzyq8R2GIhVSiAd2jioGuTjX6AZCFv3ToO 53DliFMkVTecLptsXaesuUHgL9dKIfvpm+rNXRn9wAwGjk0X/A== Message-ID: <16957e9b-103a-0fd5-9e2b-084e9ebc3773@redhat.com> Date: Wed, 4 Apr 2018 19:12:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <9d68b1b4-04e6-46d6-70b4-6ebcb0a0c4aa@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/04/2018 13:54, David Hildenbrand wrote: >> +{ >> + enum emulation_result er; >> + >> + er = emulate_instruction(vcpu, EMULTYPE_TRAP_UD); >> + if (er == EMULATE_USER_EXIT) >> + return 0; >> + if (er != EMULATE_DONE) >> + kvm_queue_exception(vcpu, UD_VECTOR); >> + return 1; > I would now actually prefer > > if (er == EMULATE_DONE) > return 1 ... Why? The return statement would be duplicated. Paolo