Received: by 10.213.65.68 with SMTP id h4csp1001471imn; Wed, 4 Apr 2018 10:50:02 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/3GqXWq/ZER9COF/PL+HkJds8ZutS5xMc8nTkEsq8KuTNYlmU0tbzDtknI9Lal8uoyr5KA X-Received: by 10.98.118.130 with SMTP id r124mr14437884pfc.238.1522864202250; Wed, 04 Apr 2018 10:50:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522864202; cv=none; d=google.com; s=arc-20160816; b=F6gapxR/MHC8jW2ubafKkMcWAL7xWR8RTvQ+1HeUO1aaFzUXoA32150zlAeRSG36Wj CT6oa+rmnKvlGL84DysFixRqSsAmnEqa1kqU5sQkiPNrq5MD6PZ+7KILWokhVWn9ZWMP XL7VdeEOBJT62Q9wOv8tPEMXs7FaRIb7usQ40/JRduLTjXEXJb3F1xUcZ3MYpYzeG4ZP fVdogkObQmb5kfvxOPlxcZEVSm5PRkgvRn9N4iuUpWxzQK2Sp3J2GM2yjLG8jOWOs4vv 2Wo//pvmkyND8Z51zVVZ33EGzcvbsy4Eb5QD/mBaMkE+XYk5RcKORGrQO77jzQNZkMfr F3QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=8XBD/HArRciw/cIByuaDpb2rE++hHUObyTbZsFXx5gs=; b=ofcqs0wne/z8i2KgznFR4k6s9oGVDvpS1wvsGPXMOHv/R8l2Xo1OGrDd71hTOg/Ehr etu+lpq7+w4xOl/6T+y8hf2qbSEuKf/aOswSmTJriIcpUbTMqD+2R5EbrPCDlEwhyE5z UXu35y9Wpe4vHW4kBGHNC7Qi7pVj8JGad7VxOh0IpAaBOwDkkHbqHGaETm3Tg+P74SgU o4QmNuH/vBrOiyJSYxGBoltXEQd/YnDXyxlSc7nsY4H5uj4QYPIXpXvYjqes8XKOJGsf GaSKS7MsFDsqHrUGpMjPz0kCueJBgH5sV9u6NCI0lR3fato18S93/8VfQJ0Fzu8JoIfv lV0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=YDoR2dQx; dkim=pass header.i=@codeaurora.org header.s=default header.b=YDoR2dQx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w64si3994562pgd.176.2018.04.04.10.49.47; Wed, 04 Apr 2018 10:50:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=YDoR2dQx; dkim=pass header.i=@codeaurora.org header.s=default header.b=YDoR2dQx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751324AbeDDRsj (ORCPT + 99 others); Wed, 4 Apr 2018 13:48:39 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:58382 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750915AbeDDRsi (ORCPT ); Wed, 4 Apr 2018 13:48:38 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id D80F46081A; Wed, 4 Apr 2018 17:48:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1522864117; bh=LIHGGfT567hFZBwP2to91knNkj4sbWPR0ULXXOfSE0U=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=YDoR2dQxKnbqVhD5vJuUbibAkVAXWkwKwLPMr1bjlo7WH42aWh2UFiIFjQP/Kwr3E lR+o3IFP+6Ck0l8QrN/rTx1fr5HG/z2eTApIMMAfgC5TmO6TZgy5Ub6RFxgmGGx4e/ N+VPjQLL3PJ3bXPJ439SswF4NprZhcM0CSbh+Jfk= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from [10.235.228.150] (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 783626024C; Wed, 4 Apr 2018 17:48:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1522864117; bh=LIHGGfT567hFZBwP2to91knNkj4sbWPR0ULXXOfSE0U=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=YDoR2dQxKnbqVhD5vJuUbibAkVAXWkwKwLPMr1bjlo7WH42aWh2UFiIFjQP/Kwr3E lR+o3IFP+6Ck0l8QrN/rTx1fr5HG/z2eTApIMMAfgC5TmO6TZgy5Ub6RFxgmGGx4e/ N+VPjQLL3PJ3bXPJ439SswF4NprZhcM0CSbh+Jfk= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 783626024C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH v2 2/2] io: prevent compiler reordering on the default readX() implementation To: Arnd Bergmann Cc: Palmer Dabbelt , Mark Rutland , Timur Tabi , sulrich@codeaurora.org, linux-arm-msm@vger.kernel.org, Linux ARM , linux-arch , Linux Kernel Mailing List References: <691b903c-e97d-0a25-28c5-690318bb215a@codeaurora.org> From: Sinan Kaya Message-ID: <9b0d7db3-0830-9661-6dc8-39523daa8f32@codeaurora.org> Date: Wed, 4 Apr 2018 13:48:35 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/4/2018 11:55 AM, Arnd Bergmann wrote: > Yes, exactly, plus the same for write and in/out of course. I was looking at this... inb() and outb() seem to be calling writeb(). It gets the wmb/barrier automatically when we fix writeb(). Did I miss something? -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.