Received: by 10.213.65.68 with SMTP id h4csp1136344imn; Wed, 4 Apr 2018 13:17:50 -0700 (PDT) X-Google-Smtp-Source: AIpwx4//7DVOosoBt81PqCzGo2f/qx2hxde2o1WDJ6hv1f1B7mbzP68B8bNnmN6LCPzU8usiRCzo X-Received: by 2002:a17:902:6bc9:: with SMTP id m9-v6mr18877436plt.146.1522873070835; Wed, 04 Apr 2018 13:17:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522873070; cv=none; d=google.com; s=arc-20160816; b=yFho1N2U5dlwkGG5BbdoC1zu39y6D7/IFd+EFlKocGMLVBAvieO7udy88C8ziyXhr7 n9lLQY3BgHTcOdHbTya1IyioxaMfN8j48mk1J1FPZJlBMAJbSUsuyI8UGTJRrvAj2x16 yaWV0V4bmGQt7d90KUnw89mnZBhJ4EGWpijGtQB5FdnNSKoxjGApXXwHsKBLrdTPzbF5 2g25A6YiV4n0LLo3HgV6TtDBNp6WyjykXCpnNIvhdsmQnIiBHxc1sYf8B1E2ig7/rKfS daakqu50+UNQDFJ/DBGk7oyusT5Mex25MroRnpmX/B2uy0fuAK7/Cs+CEddvVVvxLsEJ Y26Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=UA7IRPrF66C4ywbIeMjAmlijMohf4Lr3q/gV0UWIvvY=; b=FwI3y85WxHJAiBEsviusQMBjdYDF6dt5P9fRAfUJLmr1DnDIiH/BDr+tYFrFiVjsoS v5kHcApWRuSwiS61/4eph+DmPgtRvysWwLHwJgnnyJujeMJ4PthjaxBmRi86D39kcZES 3kwGvzfBLMHGuTHtI444Ecg8A/Ycjk1HOhMYDcN1jwdLHlfo5kCJFA73tENv9VsEXLEE twixjdxK4VQ84TZ/03RGhNkwN68gOCLxmBlMMDshaAFmpLmL8fKiYb6bPfqWxk6FtBHu YHqC4aamuM/fO3JfM3zzgYX6MqEzlpH/hqqnUCe0YFX2Z7NIykgwa/bc70aEyjdvD8jD dfLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=D+0I4BdE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b13si2819882pfi.53.2018.04.04.13.17.36; Wed, 04 Apr 2018 13:17:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=D+0I4BdE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751971AbeDDUPL (ORCPT + 99 others); Wed, 4 Apr 2018 16:15:11 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:53358 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751579AbeDDUPK (ORCPT ); Wed, 4 Apr 2018 16:15:10 -0400 Received: by mail-wm0-f68.google.com with SMTP id p9so374014wmc.3 for ; Wed, 04 Apr 2018 13:15:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UA7IRPrF66C4ywbIeMjAmlijMohf4Lr3q/gV0UWIvvY=; b=D+0I4BdEei+XzwmCrMArvhYsQsHPb9DnX9Db+C2A9NWb6y6FluM224NLOkQbRimMWS upBIv1A1QEfKETPKqDTEGwa2Tx4NpbcY+8HsX5gtvdFtCHpH/6YDpZLmz7vAoCfJf17f CHZ3V6KblLkJhZ5TPV1z0lFf4ZFhfSdl2qSG1yUIS5cBn3KGph6liEi2/JmPy29txgoT euPMj+dJuCNQj28zYJRlAvBvA5UvdtHHmn0aBq21/+yXoohlypWKbFqnXpjCQ8grrhyy YMvAwTKxfYpwC/p8W+EDI8HU/5Be5hs3TVKPLo64Yb7GzRLHfRY4D58Q1SLFioO5geca e1Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=UA7IRPrF66C4ywbIeMjAmlijMohf4Lr3q/gV0UWIvvY=; b=oZxTzUJ0R/43MqGOmI/Uk7vsR1OLY9saFwBuCoPFfzb9dblLObEYK5EC0QxQubnMZY kG6oXGkyc6uOqwfTyaX4LiupiYdL+hzr/35xTWBOxkazCmmgPn4Qr3IGxOhiS6a9Sp77 q2OZV+2WT9jTGIlcDKGXeRAiomK+rhlVkRAMDjNXXzvXHHHr/WRAFGIFfoeN7llWzn5t GQRDL9ds8EoCe2zdLd2Cii4eJECGRSef2a4ENphHOPzfLW6cgsE/s508dkg8Enjt4H7z S5r0UGOU42yFMPuKsN3HZFmStXXKvTnWR9P+KbJZLW5Q5cg6e5T/R4r+7T+Nzl/9zxs/ raRQ== X-Gm-Message-State: ALQs6tBVZ8+7BGm7D9fZsAXvcQI//GoIomCFhXuPgvHcLGvJczs5UsUM xDvSPZ40DP7tZxOVHmhDWEp4pd17 X-Received: by 10.28.207.201 with SMTP id f192mr7892152wmg.148.1522872908841; Wed, 04 Apr 2018 13:15:08 -0700 (PDT) Received: from macbookpro.malat.net (bru31-1-78-225-226-121.fbx.proxad.net. [78.225.226.121]) by smtp.gmail.com with ESMTPSA id d17sm4364101wrc.45.2018.04.04.13.15.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 04 Apr 2018 13:15:08 -0700 (PDT) Received: by macbookpro.malat.net (Postfix, from userid 1000) id 10BE710C0572; Wed, 4 Apr 2018 22:15:05 +0200 (CEST) From: Mathieu Malaterre To: Michael Ellerman Cc: Christophe Leroy , Mathieu Malaterre , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 09/19] powerpc/chrp/pci: Make some functions static Date: Wed, 4 Apr 2018 22:15:03 +0200 Message-Id: <20180404201504.28003-1-malat@debian.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180322202007.23088-10-malat@debian.org> References: <20180322202007.23088-10-malat@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org These functions can all be static, make it so. Fix warnings treated as errors with W=1: arch/powerpc/platforms/chrp/pci.c:34:5: error: no previous prototype for ‘gg2_read_config’ [-Werror=missing-prototypes] arch/powerpc/platforms/chrp/pci.c:61:5: error: no previous prototype for ‘gg2_write_config’ [-Werror=missing-prototypes] arch/powerpc/platforms/chrp/pci.c:97:5: error: no previous prototype for ‘rtas_read_config’ [-Werror=missing-prototypes] arch/powerpc/platforms/chrp/pci.c:112:5: error: no previous prototype for ‘rtas_write_config’ [-Werror=missing-prototypes] Signed-off-by: Mathieu Malaterre --- v3: style: fix alignement issue (checkpatch --strict) v2: no change arch/powerpc/platforms/chrp/pci.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/platforms/chrp/pci.c b/arch/powerpc/platforms/chrp/pci.c index 0f512d35f7c5..5ddb57b82921 100644 --- a/arch/powerpc/platforms/chrp/pci.c +++ b/arch/powerpc/platforms/chrp/pci.c @@ -31,7 +31,7 @@ void __iomem *gg2_pci_config_base; * limit the bus number to 3 bits */ -int gg2_read_config(struct pci_bus *bus, unsigned int devfn, int off, +static int gg2_read_config(struct pci_bus *bus, unsigned int devfn, int off, int len, u32 *val) { volatile void __iomem *cfg_data; @@ -58,7 +58,7 @@ int gg2_read_config(struct pci_bus *bus, unsigned int devfn, int off, return PCIBIOS_SUCCESSFUL; } -int gg2_write_config(struct pci_bus *bus, unsigned int devfn, int off, +static int gg2_write_config(struct pci_bus *bus, unsigned int devfn, int off, int len, u32 val) { volatile void __iomem *cfg_data; @@ -94,8 +94,8 @@ static struct pci_ops gg2_pci_ops = /* * Access functions for PCI config space using RTAS calls. */ -int rtas_read_config(struct pci_bus *bus, unsigned int devfn, int offset, - int len, u32 *val) +static int rtas_read_config(struct pci_bus *bus, unsigned int devfn, int offset, + int len, u32 *val) { struct pci_controller *hose = pci_bus_to_host(bus); unsigned long addr = (offset & 0xff) | ((devfn & 0xff) << 8) @@ -109,8 +109,8 @@ int rtas_read_config(struct pci_bus *bus, unsigned int devfn, int offset, return rval? PCIBIOS_DEVICE_NOT_FOUND: PCIBIOS_SUCCESSFUL; } -int rtas_write_config(struct pci_bus *bus, unsigned int devfn, int offset, - int len, u32 val) +static int rtas_write_config(struct pci_bus *bus, unsigned int devfn, int offset, + int len, u32 val) { struct pci_controller *hose = pci_bus_to_host(bus); unsigned long addr = (offset & 0xff) | ((devfn & 0xff) << 8) -- 2.11.0