Received: by 10.213.65.68 with SMTP id h4csp1738606imn; Thu, 5 Apr 2018 03:00:14 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/AqxuiRXtrBfg3cEPkJsHCb3h0BpA9I+Ti01PIlxd89nU8dDQvnT5/UYOaGflMUtK/fqN5 X-Received: by 10.98.194.195 with SMTP id w64mr16729494pfk.83.1522922414528; Thu, 05 Apr 2018 03:00:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522922414; cv=none; d=google.com; s=arc-20160816; b=QO118KSZFazTD++Ynyp5PFx4V5W5YTzcx8IGIrq31QRuLDo/IJhEHOge4MUb7V40Pa DU97MauxGX9Af3+om9eSYnHFNq079+QZDwWsv1jEmOWl/bl7lBDzmY7fZuY7BLsFh9b2 7eNBPRvR4k3dmIvEPpknJhYFgTbWbO5xiTqIXRVhPGM3LEUWoRKZrP+fWnTncXrJmADm /gFi0tsUh4uB6lbWG/d6Wfl2cTP46a8Rq29ruEXAcBHSzt4HQ8BNKlHgqRb5xqE/mCT4 OGoSmKQcgklSMX4CvVNaSPlzQmKBFMOUMgnhEL/8iIekxFJjypouZtWUhzs65CHObI3w OZrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=Ep/ZQQd2P5duK5L8/2iqTYNGJx7eMvP3LsTpJD8LOfU=; b=WhcZg9vqAg6YXL1nW9fLC4QB0OY+P/DW6E4GgAE4BooUvE2V45B/nJbXsZd9e4/iiQ bTs7Dh8Ao7ejDnnlFkjvyzzvP3zDmKvPQ1qFhul9oIOt3PlGODue2aeFMvdVH2hUsQ7U H4d7rIAllCS+VbNzp+D0gjVzX5B+BewHK34CxcjvAvjcNIoXf8ByoQU1aU+NPymDPoDh P1iAPJfqiJ0dGN14K5vmfl3crm0M2XyGdAcoLK9dDOwm5sgCKC8VuORZLQFr7Lwt1u6H LafTjIJUTdTvmJBg3ave8QA2EbjhnEA2m1FOZXqcyCWU9KA4WCrxl8JM61crHACx35z5 kJpw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h1-v6si5887349pli.645.2018.04.05.03.00.00; Thu, 05 Apr 2018 03:00:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752236AbeDEJ67 (ORCPT + 99 others); Thu, 5 Apr 2018 05:58:59 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:60850 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751900AbeDEJuq (ORCPT ); Thu, 5 Apr 2018 05:50:46 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id 6B04327A651 From: Enric Balletbo i Serra To: architt@codeaurora.org, inki.dae@samsung.com, thierry.reding@gmail.com, hjc@rock-chips.com, seanpaul@chromium.org, airlied@linux.ie, tfiga@chromium.org, heiko@sntech.de Cc: dri-devel@lists.freedesktop.org, dianders@chromium.org, a.hajda@samsung.com, ykk@rock-chips.com, kernel@collabora.com, m.szyprowski@samsung.com, linux-samsung-soc@vger.kernel.org, jy0922.shim@samsung.com, rydberg@bitmath.org, krzk@kernel.org, linux-rockchip@lists.infradead.org, kgene@kernel.org, linux-input@vger.kernel.org, orjan.eide@arm.com, wxt@rock-chips.com, jeffy.chen@rock-chips.com, linux-arm-kernel@lists.infradead.org, mark.yao@rock-chips.com, wzz@rock-chips.com, hl@rock-chips.com, jingoohan1@gmail.com, sw0312.kim@samsung.com, linux-kernel@vger.kernel.org, kyungmin.park@samsung.com, Laurent.pinchart@ideasonboard.com, kuankuan.y@gmail.com, hshi@chromium.org, Enric Balletbo i Serra Subject: [PATCH v6 15/30] drm/bridge: analogix_dp: Fix timeout of video streamclk config Date: Thu, 5 Apr 2018 11:49:45 +0200 Message-Id: <20180405095000.9756-16-enric.balletbo@collabora.com> X-Mailer: git-send-email 2.16.3 In-Reply-To: <20180405095000.9756-1-enric.balletbo@collabora.com> References: <20180405095000.9756-1-enric.balletbo@collabora.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: zain wang The STRM_VALID bit in register ANALOGIX_DP_SYS_CTL_3 may be unstable, so we may hit the error log "Timeout of video streamclk ok" since checked this unstable bit. In fact, we can go continue and the streamclk is ok if we wait enough time, it does no effect on display. Let's change this error to warn. Cc: Douglas Anderson Signed-off-by: zain wang Signed-off-by: Sean Paul Signed-off-by: Thierry Escande Reviewed-by: Andrzej Hajda Signed-off-by: Enric Balletbo i Serra Tested-by: Marek Szyprowski Reviewed-by: Archit Taneja --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index 5540e2dfc2ec..a72e454a7292 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -921,8 +921,9 @@ static int analogix_dp_config_video(struct analogix_dp_device *dp) done_count = 0; } if (timeout_loop > DP_TIMEOUT_LOOP_COUNT) { - dev_err(dp->dev, "Timeout of video streamclk ok\n"); - return -ETIMEDOUT; + dev_warn(dp->dev, + "Ignoring timeout of video streamclk ok\n"); + break; } usleep_range(1000, 1001); -- 2.16.3