Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S272616AbTHPFNj (ORCPT ); Sat, 16 Aug 2003 01:13:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S272619AbTHPFNj (ORCPT ); Sat, 16 Aug 2003 01:13:39 -0400 Received: from [66.212.224.118] ([66.212.224.118]:25874 "EHLO hemi.commfireservices.com") by vger.kernel.org with ESMTP id S272616AbTHPFNi (ORCPT ); Sat, 16 Aug 2003 01:13:38 -0400 Date: Sat, 16 Aug 2003 01:01:43 -0400 (EDT) From: Zwane Mwaikambo X-X-Sender: zwane@montezuma.mastecende.com To: "Nguyen, Tom L" Cc: Greg Kroah-Hartmann , Jeff Garzik , "Nakajima, Jun" , Linux Kernel , long Subject: RE: Update MSI Patches In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1095 Lines: 21 On Fri, 15 Aug 2003, Nguyen, Tom L wrote: > Thank you for testing it through different configurations! > That is what we thought initially by renaming irq to something like offset or > index to avoid some duplicate functions. However, I think if keeping them like > above perhaps may raise a confusion again of why not name vector since the > function vector_to_irq(...) converts a vector to irq. Please provide us final > thoughts. I think a variable rename should be fine, as long as the reader doesn't get misled into thinking a specific variable is something which it isn't. index sounds fine to me, the nice thing about your patch is that we don't have to touch pci_dev->irq at all. The only other change would be what to show to userspace e.g. driver prints pci_dev->irq and /proc/interrupts prints vector. But that's all secondary... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/