Received: by 10.213.65.68 with SMTP id h4csp2050521imn; Thu, 5 Apr 2018 08:09:14 -0700 (PDT) X-Google-Smtp-Source: AIpwx49eADBIRoTE4pZLO9m2XwqT4F8zzthenqWZQ8X4HQM3pnpJpVOMJzjUxWG+jXeEon8SZo7V X-Received: by 2002:a17:902:ac97:: with SMTP id h23-v6mr23611042plr.176.1522940954448; Thu, 05 Apr 2018 08:09:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522940954; cv=none; d=google.com; s=arc-20160816; b=PH8wqWqiaQw1O58EdkD/+4Jo4TtV3G0Z1cjEBqLgbSpstzeN0XRq+edWYgHraEeaW5 FKk6l1PiU5tlIP4gNZbv5WaGWLfUBXBPAzKNKBx/9JkxjWMwq4N9WzwlUb3lb3f/R6Di KYB94qLq5TuJYZvp/jTIj3cWozIDwferZd79t62v3amZNPLpfZp/2rNoOKiTpVM16k5O F1d1dZgtjQvfHbNwi7gor/pCr8iZBazxmdw13zMFqkT6KeoTbf0o6UaBRAX1DIY5um9D womV2KlNz9fCr8IS/LHMwi0xUui2OaTjulrPkYUjb2YdOP8kf7WbCXcMNnxM5FW7r8wl ARNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=aUababAyeIVrVunCYUxq4KrDeaOyZU4DxIJQqah2g2U=; b=NhGqW9xgAgf23ei10D5B6Ud+afqjJRvZUb8OnZXbtq/rFDQ1qpTfJD2ruyxiIpHEw7 ljxjhy8kG9TxDBQxXshbFDL5Dqkbb5cBT3avPHrpkcyBupy5WJllgaZi6O22EZIxor3y 3N+X5vkP44w1zWEg3k3tx0z14rY5gpfJ8vW9fJdvD0aFs6cCEzcYqLTMmhug++fig6+C boPnUTFucX4eSatUS0r4y/raMA+C9/pXh5aqjciiFrY/AKz0UUyZI5p6+TpzDG/Ja8au oZU6+tira5m2WNLiiglR+xT5JNewuKGHyPNCvEg3TAhXmyaT/VZxig5DflWf70Dd/XK8 fEWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=GMeohtJc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j1-v6si5833996pld.108.2018.04.05.08.09.00; Thu, 05 Apr 2018 08:09:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=GMeohtJc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751404AbeDEPHy (ORCPT + 99 others); Thu, 5 Apr 2018 11:07:54 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:44034 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751038AbeDEPHx (ORCPT ); Thu, 5 Apr 2018 11:07:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=aUababAyeIVrVunCYUxq4KrDeaOyZU4DxIJQqah2g2U=; b=GMeohtJc5x0FuHhqMQ9CZnHsx gQfp8+hm5h96ybsmIjD34DEMalofxQl1hOMx6F2akSs2O2xnII7ie7C+IISoXRpQS8tF4wEAH1TO5 xnWId0EANjJsMW6gDW4CD5znQpKa2bWrJ1IdD1rgjxdAhXjTkyRpIyROxu/YBBHGYAPrMDPMUB8pr 096pilO+3P6pycCBkTQQWH9JQnr6T4/0p0K2ExMnGebveQY3kygOUc5aMoPBbsyyMNH9z+SjL48IN ImKvdufLd/4R6HoQ8ISR7xWYiIlY8hnp0MvfoROJPbcwgRJZD3tWPfZ6P7hnO7jq6q6Eub2HttcLV 7WlnUAdcA==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1f46UO-000310-Jv; Thu, 05 Apr 2018 15:07:48 +0000 Date: Thu, 5 Apr 2018 08:07:48 -0700 From: Christoph Hellwig To: Vadim Lomovtsev Cc: sgoutham@cavium.com, sunil.kovvuri@gmail.com, robert.richter@kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, dnelson@redhat.com, gustavo@embeddedor.com, Vadim Lomovtsev Subject: Re: [PATCH] net: thunderx: rework mac addresses list to u64 array Message-ID: <20180405150748.GA5716@infradead.org> References: <20180405145756.12633-1-Vadim.Lomovtsev@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180405145756.12633-1-Vadim.Lomovtsev@caviumnetworks.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > struct xcast_addr_list { > - struct list_head list; > int count; > + u64 mc[0]; Please use the standard C99 syntax here: u64 mc[]; > + mc_list = kmalloc(sizeof(*mc_list) + > + sizeof(u64) * netdev_mc_count(netdev), > + GFP_ATOMIC); kmalloc_array(), please.