Received: by 10.213.65.68 with SMTP id h4csp156913imn; Thu, 5 Apr 2018 20:16:15 -0700 (PDT) X-Google-Smtp-Source: AIpwx49nUAKFYkP2jWYpFVfep6eBdFUu8LEGYdlyBrxnJpxdqXMzp1mlfbtVz2kDW1eQ0UE+5oit X-Received: by 2002:a17:902:33a5:: with SMTP id b34-v6mr25245282plc.232.1522984575529; Thu, 05 Apr 2018 20:16:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522984575; cv=none; d=google.com; s=arc-20160816; b=DV3anE3ssNjSC3WUJDrMV2lwIpgTAJMCr0drFUT4KlG5ELPG8/BY5oJCzSkLMZH5xs OU96w1rC/MckNKcclC8g8cLFOhBE9GE+JD3TCeMPXtVyfTGwEhkE/npYcFIWCAgJpkva iouZ4U4Cy8Km8rsF7rqk+snWzFB5gOrE0k6C1+DWJWh7zPaFsfK3b990M6GfDDK1O5/L 4pkT8fSExQJYrvmQtZXniGgSorQpkJVPjDB0FGm4cBgVDbXOk+ged4xsVIFRVcsps0qg HsFJW1Dd9YytKGqBLGH8T7qQ6NZP3dEiq0UOsAtUsxHuV3VsutUmY/odKJOtY7+N2213 Bg6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=F30IPnOzD+ndrqbN/tyiL2mmgllc2nO1L1zA2g7Rqz8=; b=XywzxDCCosr1QghX0whNN68Y99o0kj0qRufLG6dgwqvZgmGUG6a74H+lAyeUDqmncg f/LR4U/oAS3rc+wmMNyCZCXITvyRwy1r1C7jhIroznggx8Hoy0x8GlrZxtEj5krNBl0C rcSJtbPcgfp/TjcEbDfSCD+wwNwoPzFKAbcrv/w5s7yzmd9kSP/uGgg5zTlMjS3RcsZ6 raceWOrVkvg/Zar3IRo2ULjkG5VMC+0U3ENyOM2IhiuysZ+/UdlrXpUUoluNKCs64vyq hMQ4ENmLi9fwEOPOwAIiC/R2Jq/awS9mk6Leg3WwOUo81mghYuVL3B9Bk08QQQ3XDUbX 7gDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DxytTehv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1-v6si7286959plj.510.2018.04.05.20.16.01; Thu, 05 Apr 2018 20:16:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DxytTehv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751558AbeDFDOx (ORCPT + 99 others); Thu, 5 Apr 2018 23:14:53 -0400 Received: from mail-pl0-f65.google.com ([209.85.160.65]:36349 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751363AbeDFDOv (ORCPT ); Thu, 5 Apr 2018 23:14:51 -0400 Received: by mail-pl0-f65.google.com with SMTP id 91-v6so21834318pld.3; Thu, 05 Apr 2018 20:14:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=F30IPnOzD+ndrqbN/tyiL2mmgllc2nO1L1zA2g7Rqz8=; b=DxytTehvY/yjjlhe9MMJwcM5Z+uCExr6aNH8JZS0VVg+B+JzDiRxNuUYqGxsyPiJlU Q9R/RYkDBOVVgKd8x/yrMMs6OVFnlIajOyA2IeVcaXB/ml5x+zEPkHH1KsprD2v7Dy3n x8xvjbBeNghJvQ39Tk4Bx8U7mU+IXN1Z+OouItH3JHiSztUzpKBLnoKLqYIEUYHJdtPg pz4gFucvmWXMWB7OWLjRxC9tocpg+JXMK1oIlJIUfwblbfTx02mS+S1e1ReZSyXlXrEE HL0RWTqhpcG/BpT0ScQSSRgmsdVwQ56a8VRv3Nx7hrGJZO0FlIQigu+HEZ+ta55kAMcU zTyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=F30IPnOzD+ndrqbN/tyiL2mmgllc2nO1L1zA2g7Rqz8=; b=Owx2dVLW9Z113nBjJu9U+Ik8N0ketEG6YiTWuk9B+Kf2vnD+rIMWWCuKW8Z7N+hqOY pyYAsPj+VQnW4wgbzNxqzkG0m91QSmw9hJOhimZHZDRn5yfFWyBlDH+ilOlps9GW5Dbe PLsIFbPL+JLxk8zMcYFyCPwK8Lb1lugRDM0nA6wl70jzNMxZbPh2YVKzkKxRMHvrIOrk DTCmoiElgDlnpfjXOPshL4OVaOcZlj89Uqo3LXjVt4wouAq+Zyk8MYGp7y2MGpvc034x OSASF0AQoz65xxgTAKJoQL6Z0YYSEiDNBb1eiu13L9mI0+mEyqfrHZxQyonkoHEGTAXE bFhw== X-Gm-Message-State: AElRT7GA4BgWJa0WEgNUnJk74M7iKh8gNFhXcvTIdeaWw4BfbIiXQzdS KmSPJq13rkcHShx1jE5e9DM= X-Received: by 2002:a17:902:7201:: with SMTP id ba1-v6mr17885658plb.0.1522984490706; Thu, 05 Apr 2018 20:14:50 -0700 (PDT) Received: from sol.localdomain (c-67-185-97-198.hsd1.wa.comcast.net. [67.185.97.198]) by smtp.gmail.com with ESMTPSA id 67sm17397462pfp.122.2018.04.05.20.14.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Apr 2018 20:14:50 -0700 (PDT) Date: Thu, 5 Apr 2018 20:15:24 -0700 From: Eric Biggers To: Tianyu Lan Cc: "Lan, Tianyu" , syzbot , borntraeger@de.ibm.com, cornelia.huck@de.ibm.com, david@redhat.com, Dmitry Vyukov , "H. Peter Anvin" , jschoenh@amazon.de, kvm , "linux-kernel@vger kernel org" , Ingo Molnar , Paolo Bonzini , Radim Krcmar , syzkaller-bugs@googlegroups.com, Thomas Gleixner , the arch/x86 maintainers Subject: Re: KASAN: use-after-free Write in irq_bypass_register_consumer Message-ID: <20180406031524.GB21382@sol.localdomain> References: <001a1143e716efd3a9055cc8696b@google.com> <001a1146f1146fe0b505605e42c1@google.com> <91a32ec1-64e7-8b6b-9464-6599dd6735ad@intel.com> <20180126232755.z3gtqrm2oz6sp2t6@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 29, 2018 at 01:29:48PM +0800, Tianyu Lan wrote: > > > On 1/27/2018 7:27 AM, Eric Biggers wrote: > > On Sat, Dec 16, 2017 at 04:37:02PM +0800, Lan, Tianyu wrote: > > > The root cause is that kvm_irqfd_assign() and kvm_irqfd_deassign() can't > > > be run in parallel. Some data structure(e.g, irqfd->consumer) will be > > > crashed because irqfd may be freed in deassign path before they are used > > > in assign path. The other data maybe used in deassign path before > > > initialization. Syzbot test hit such case. Add mutx between > > > kvm_irqfd_assign() and kvm_irqfd_deassign() can fix such issue. Will > > > send patch to fix it. > > > > > > On 12/16/2017 12:53 PM, Tianyu Lan wrote: > > > > I reproduced the issue. Will have a look. > > > > > > > > -- Best regards Tianyu Lan 2017-12-15 18:14 GMT+08:00 syzbot > > > > : > > > > > syzkaller has found reproducer for the following crash on > > > > > 82bcf1def3b5f1251177ad47c44f7e17af039b4b > > > > > git://git.cmpxchg.org/linux-mmots.git/master > > > > > compiler: gcc (GCC) 7.1.1 20170620 > > > > > .config is attached > > > > > Raw console output is attached. > > > > > C reproducer is attached > > > > > syzkaller reproducer is attached. Seehttps://goo.gl/kgGztJ > > > > > for information about syzkaller reproducers > > > > > > > > > > > > > > > ================================================================== > > > > > BUG: KASAN: use-after-free in __list_add include/linux/list.h:64 [inline] > > > > > BUG: KASAN: use-after-free in list_add include/linux/list.h:79 [inline] > > > > > BUG: KASAN: use-after-free in irq_bypass_register_consumer+0x4b4/0x500 > > > > > virt/lib/irqbypass.c:217 > > > > > Write of size 8 at addr ffff8801cdf51180 by task syzkaller436086/15031 > > > > > > > > > > CPU: 1 PID: 15031 Comm: syzkaller436086 Not tainted 4.15.0-rc2-mm1+ #39 > > > > > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS > > > > > Google 01/01/2011 > > > > > Call Trace: > > > > > __dump_stack lib/dump_stack.c:17 [inline] > > > > > dump_stack+0x194/0x257 lib/dump_stack.c:53 > > > > > print_address_description+0x73/0x250 mm/kasan/report.c:252 > > > > > kasan_report_error mm/kasan/report.c:351 [inline] > > > > > kasan_report+0x25b/0x340 mm/kasan/report.c:409 > > > > > __asan_report_store8_noabort+0x17/0x20 mm/kasan/report.c:435 > > > > > __list_add include/linux/list.h:64 [inline] > > > > > list_add include/linux/list.h:79 [inline] > > > > > irq_bypass_register_consumer+0x4b4/0x500 virt/lib/irqbypass.c:217 > > > > > kvm_irqfd_assign arch/x86/kvm/../../../virt/kvm/eventfd.c:417 [inline] > > > > > kvm_irqfd+0x137f/0x1d50 arch/x86/kvm/../../../virt/kvm/eventfd.c:572 > > > > > kvm_vm_ioctl+0x1079/0x1c40 arch/x86/kvm/../../../virt/kvm/kvm_main.c:2992 > > > > > vfs_ioctl fs/ioctl.c:46 [inline] > > > > > do_vfs_ioctl+0x1b1/0x1530 fs/ioctl.c:686 > > > > > SYSC_ioctl fs/ioctl.c:701 [inline] > > > > > SyS_ioctl+0x8f/0xc0 fs/ioctl.c:692 > > > > > entry_SYSCALL_64_fastpath+0x1f/0x96 > > > > > RIP: 0033:0x44d379 > > > > > RSP: 002b:00007fc5ff9a9d08 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 > > > > > RAX: ffffffffffffffda RBX: 00007fc5ff9aa700 RCX: 000000000044d379 > > > > > RDX: 0000000020080fe0 RSI: 000000004020ae76 RDI: 0000000000000005 > > > > > RBP: 00000000007ff900 R08: 00007fc5ff9aa700 R09: 00007fc5ff9aa700 > > > > > R10: 00007fc5ff9aa700 R11: 0000000000000246 R12: 0000000000000000 > > > > > R13: 00000000007ff8ff R14: 00007fc5ff9aa9c0 R15: 0000000000000000 > > > > > > > > > > Allocated by task 15031: > > > > > save_stack+0x43/0xd0 mm/kasan/kasan.c:447 > > > > > set_track mm/kasan/kasan.c:459 [inline] > > > > > kasan_kmalloc+0xad/0xe0 mm/kasan/kasan.c:551 > > > > > kmem_cache_alloc_trace+0x136/0x750 mm/slab.c:3614 > > > > > kmalloc include/linux/slab.h:516 [inline] > > > > > kzalloc include/linux/slab.h:705 [inline] > > > > > kvm_irqfd_assign arch/x86/kvm/../../../virt/kvm/eventfd.c:296 [inline] > > > > > kvm_irqfd+0x16c/0x1d50 arch/x86/kvm/../../../virt/kvm/eventfd.c:572 > > > > > kvm_vm_ioctl+0x1079/0x1c40 arch/x86/kvm/../../../virt/kvm/kvm_main.c:2992 > > > > > vfs_ioctl fs/ioctl.c:46 [inline] > > > > > do_vfs_ioctl+0x1b1/0x1530 fs/ioctl.c:686 > > > > > SYSC_ioctl fs/ioctl.c:701 [inline] > > > > > SyS_ioctl+0x8f/0xc0 fs/ioctl.c:692 > > > > > entry_SYSCALL_64_fastpath+0x1f/0x96 > > > > > > > > > > Freed by task 1402: > > > > > save_stack+0x43/0xd0 mm/kasan/kasan.c:447 > > > > > set_track mm/kasan/kasan.c:459 [inline] > > > > > kasan_slab_free+0x71/0xc0 mm/kasan/kasan.c:524 > > > > > __cache_free mm/slab.c:3492 [inline] > > > > > kfree+0xca/0x250 mm/slab.c:3807 > > > > > irqfd_shutdown+0x13c/0x1a0 arch/x86/kvm/../../../virt/kvm/eventfd.c:148 > > > > > process_one_work+0xbfd/0x1bc0 kernel/workqueue.c:2113 > > > > > worker_thread+0x223/0x1990 kernel/workqueue.c:2247 > > > > > kthread+0x37a/0x440 kernel/kthread.c:238 > > > > > ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:524 > > > > > > > > > > The buggy address belongs to the object at ffff8801cdf51000 > > > > > which belongs to the cache kmalloc-512 of size 512 > > > > > The buggy address is located 384 bytes inside of > > > > > 512-byte region [ffff8801cdf51000, ffff8801cdf51200) > > > > > The buggy address belongs to the page: > > > > > page:00000000d08a0d63 count:1 mapcount:0 mapping:00000000d54c7be6 index:0x0 > > > > > flags: 0x2fffc0000000100(slab) > > > > > raw: 02fffc0000000100 ffff8801cdf51000 0000000000000000 0000000100000006 > > > > > raw: ffffea00073a7660 ffffea000737f3a0 ffff8801dac00940 0000000000000000 > > > > > page dumped because: kasan: bad access detected > > > > > > > > > > Memory state around the buggy address: > > > > > ffff8801cdf51080: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb > > > > > ffff8801cdf51100: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb > > > > > > ffff8801cdf51180: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb > > > > > ^ > > > > > ffff8801cdf51200: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc > > > > > ffff8801cdf51280: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb > > > > > ================================================================== > > > > > > > Tianyu, are you still planning to send a patch for this? This is still > > happening. > > > > - Eric > Yes, I sent out fix patch and wait for review. > ?https://patchwork.kernel.org/patch/10128925/ > This is still happening. Can you please resend your patch? Eric