Received: by 10.213.65.68 with SMTP id h4csp297897imn; Thu, 5 Apr 2018 23:48:57 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+Vcgsms4ziu0ZOVK51Ox8oLHwrD+PaUFMcRyRBN5yk1DXD647gYiAK3A0D1i0pB3wZGekZ X-Received: by 2002:a17:902:5609:: with SMTP id h9-v6mr25943406pli.121.1522997337149; Thu, 05 Apr 2018 23:48:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522997337; cv=none; d=google.com; s=arc-20160816; b=jowmschEtggymdUl2yihIiihxbr9oywV6galWK4r4hghejfEFm9C3cimzAjuE4OIOy Aqzi/tPjaRmrI3krWHqQeabqKqQXLE7V1R2Qjbd3Q78zCctCBeU9ZOzt0Dnv96vv79nx KAMD8p6xJSZz66EtW8cfGpAjir1TWhHImI9r5HNZYb0rXe9S4qVrqhYb0yRn2e8Ii7WC OzkjBUBgXHVW19AbT83YegWcmjOF0WdZO44AmtJUcEu5L5AXuP2mUIeyq+/elByh+eBo vJmJgNBljdGgd7DJLgAv6LLBa0Nx6ATfVjV9XCz2O2qn6Qe5nuRn/tGdKH/bR5InziOf Qdjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=gJMHqbH0zJJV4ZuPHzcCJIEFDkt33d8QbicrKIqrRP4=; b=bcFiv2HNnpH1a1VBeRRPBfiv4sSH0DcNqFBanZAoHKlY2s4R3P0wxB9V2pKg9lYXrv Xm6aCSbhUqhyOqTbFldMrPfQY6ki92fxkF4pEGVKoQz54OHNy8S3erhS9SN8GvbvwE4N 32Yjnrtelc98eOit6ufnNDwyVUBiFrAQQINn9kPIXbw88LLNlsLcffhUgIQ7L2tmrg+x ds/W3a2JeuCmsm54wBoAJeLs1SsumOpzLbkVCRQwhp15yXBoDKB49SgHdkrGjjUvggpG RXtrjyvxlMNFKhX0tYRAJRoNVCflrypZP+4lXGMAiHgjf+/PLZ+qo19C7LXskRMRo/v+ WXMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Iat0T0z0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a19si2232424pgd.141.2018.04.05.23.48.42; Thu, 05 Apr 2018 23:48:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Iat0T0z0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751312AbeDFGrh (ORCPT + 99 others); Fri, 6 Apr 2018 02:47:37 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:46127 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750739AbeDFGrg (ORCPT ); Fri, 6 Apr 2018 02:47:36 -0400 Received: by mail-wr0-f195.google.com with SMTP id d1so204174wrj.13 for ; Thu, 05 Apr 2018 23:47:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=gJMHqbH0zJJV4ZuPHzcCJIEFDkt33d8QbicrKIqrRP4=; b=Iat0T0z0BeQ1h3Wmyhoul2dHa8GU3Myo3/DCNrI0/azhMTA8ZpEp1zR+RleSWits7s uWjtJDZr2TqXxVenI+jS0BE2nhTX6kn58jZQh5OHFQ1lJV8EWAb2YXBMXRnJMq68x+1F d2oTVQXMtLOLjbCIAPXG6bCSIT4wKgWWlq0F//kZO7Ua4Q5VvnQBqwCNRN6OxIL7+W1Z HSNBDAvcMgLF6h3haj1JwmYweI738tGYOIPx96zDZnqWkgklXD713j3V2zs/q/pye2rC nGbxNm8d1okpQ0KriVw93rvAWrnUlFCLAMTyauGiJrtzCXks9J8KCvW3TzPKjk0gkQjV si9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=gJMHqbH0zJJV4ZuPHzcCJIEFDkt33d8QbicrKIqrRP4=; b=IH3tlVcIWOW3VzaUyEE7e3IyBJKLfDUjJLfCQutSJM1KPQkcAsW0pkM34B+y5+27Et eq8+1oWYo4ysnkxqL1nfppiTz7/uti63xn6Z8RTc5c4R0F6fCI/BxktWS/dXyE5/chVu bS7/MG4B6Y5XjeVGM3tszA0UVfnPE+8Qhynb7QDTjet21TksrULB9QFi9Syc4QdR7Qj9 DyTNlIw6tMIoLReBEpS8EsPAKYdE/TsY4OO+3OajjwJYh+gHupEPrJw2Hu+GdKIk/NTr c0UwB1tzaoWo20fSxCNVzih0dQ5kaV+UQEh3EE7jeSpKWLEk8CXnF653UoGn4lp9dooP wsGA== X-Gm-Message-State: ALQs6tDrcuYc0GhgGeXox6QW+YOEUFuRTWCzuNKqiCKgFkHJ3qbY3dsP Ok6mBp+Xer68jUwumVmsiBQ= X-Received: by 10.223.196.212 with SMTP id o20mr17855096wrf.144.1522997255049; Thu, 05 Apr 2018 23:47:35 -0700 (PDT) Received: from [127.0.1.1] ([83.243.48.55]) by smtp.gmail.com with ESMTPSA id e11sm7720315wma.4.2018.04.05.23.47.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Apr 2018 23:47:34 -0700 (PDT) From: Tobias Regnery To: keescook@chromium.org, arnd@arndb.de, linux-kernel@vger.kernel.org Cc: Tobias Regnery Subject: [PATCH] pstore: fix crypto dependencies without compression Date: Fri, 6 Apr 2018 08:38:04 +0200 Message-Id: <20180406063804.30510-1-tobias.regnery@gmail.com> X-Mailer: git-send-email 2.16.3 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit 58eb5b670747 ("pstore: fix crypto dependencies") fixed up the crypto dependencies but missed the case when no compression is selected. With CONFIG_PSTORE=y, CONFIG_PSTORE_COMPRESS=n and CONFIG_CRYPTO=m we see the following link error: fs/pstore/platform.o: In function `pstore_register': (.text+0x1b1): undefined reference to `crypto_has_alg' (.text+0x205): undefined reference to `crypto_alloc_base' fs/pstore/platform.o: In function `pstore_unregister': (.text+0x3b0): undefined reference to `crypto_destroy_tfm' Fix this by selecting CONFIG_CRYPTO unconditionally. Fixes: 58eb5b670747 ("pstore: fix crypto dependencies") Signed-off-by: Tobias Regnery --- fs/pstore/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/pstore/Kconfig b/fs/pstore/Kconfig index 09c19ef91526..f42ea286ccd7 100644 --- a/fs/pstore/Kconfig +++ b/fs/pstore/Kconfig @@ -1,6 +1,6 @@ config PSTORE tristate "Persistent store support" - select CRYPTO if PSTORE_COMPRESS + select CRYPTO default n help This option enables generic access to platform level -- 2.16.3