Received: by 10.213.65.68 with SMTP id h4csp343304imn; Fri, 6 Apr 2018 00:48:46 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/oThEXQAJz6W7/prj16NuYzrbAzLLZkDMhiTaJGKKe8WL7xifn81Gjns8QphNVV2zMlrs8 X-Received: by 10.98.133.28 with SMTP id u28mr19675256pfd.190.1523000926579; Fri, 06 Apr 2018 00:48:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523000926; cv=none; d=google.com; s=arc-20160816; b=lvbSS2M4GgXCaaT9X/Fsg0GGzXfX4ByUuzeIjDLEpLL4jHEgIMa2VSLCUJ7z+do6vF 13tdNbkibKXcolGne9raR/MYcTVxRlqdmIYx+kY+4KPlJxjErwfT40aLCFs4ZPoDKSrw sYWoXzeJELnK9wKZvRvqc0SDwfciWcPFO/WVkH3cELBQrjDgHYhrThdGYiuQjUSNeS6+ 9eicHa/rXSZ+MUpLKdvKUtzcBFQDwxz6mOKvgbWD+dlIPLf6hQmY4lRxxX0RRI9vymJP q6fJaaY+l4THoYaM0FqtmkmMIFna4pmqlYML0lW0opjRM6pP2I29ryVlkbLKgNjkAzPB +ECw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date :arc-authentication-results; bh=19kFs+mAofj1uVDMWNg4wfvj5eJwe0wl8c2msT4ozZ4=; b=nihgHjeze2VT03kVizoj6Oqo4mbsJwR9btxBxx4OMvHz3XCcJ6BVA2BtkHogUw4cG6 ebh6KpTRTuHXOIYL3wbbf4xxqBrT4gBTTmHGV+I2qVaw9MmiTAlPhXyHMvIJ6X3/Zb5K v2UWYPD6xr4bWScBMnq3fxPGfLDeFeVHaiM6xyhHO+5G+D+jBuDLrO+6FybuMlM4Lji6 HcXiapeaJod3bdXWeMHLbKhDFnYor3wFRkcdFFE/F4ZqCCwxFjAgoCwWyimiBQgiXeWa KT5d5aUo5fBC7uQbvMxyCCMWhkS7UFUS4hn/Vz4Jla9tT+1XW/4Rf0lMF4/jWorzN7T8 FD4A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bh1-v6si7405801plb.246.2018.04.06.00.48.30; Fri, 06 Apr 2018 00:48:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751425AbeDFHrR (ORCPT + 99 others); Fri, 6 Apr 2018 03:47:17 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60754 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750962AbeDFHrQ (ORCPT ); Fri, 6 Apr 2018 03:47:16 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 5E1F3D6B; Fri, 6 Apr 2018 07:47:15 +0000 (UTC) Date: Fri, 6 Apr 2018 09:47:14 +0200 From: Greg Kroah-Hartman To: Stefano Brivio Cc: Ben Hutchings , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Petr Vorel , Alexey Kodanev , "David S. Miller" , Sasha Levin , Steffen Klassert Subject: Re: [PATCH 4.4 92/97] ip6_vti: adjust vti mtu according to mtu of lower device Message-ID: <20180406074714.GA3127@kroah.com> References: <20180323094157.535925724@linuxfoundation.org> <20180323094202.622913188@linuxfoundation.org> <1522800556.2654.158.camel@codethink.co.uk> <20180405173636.5765efcf@epycfail> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180405173636.5765efcf@epycfail> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 05, 2018 at 05:36:36PM +0200, Stefano Brivio wrote: > On Wed, 04 Apr 2018 01:09:16 +0100 > Ben Hutchings wrote: > > > On Fri, 2018-03-23 at 10:55 +0100, Greg Kroah-Hartman wrote: > > > 4.4-stable review patch.??If anyone has any objections, please let me know. > > > > > > ------------------ > > > > > > From: Alexey Kodanev > > > > > > > > > [ Upstream commit 53c81e95df1793933f87748d36070a721f6cb287 ] > > [...] > > > > There are a couple of follow-ups to this: > > > > c6741fbed6dc vti6: Properly adjust vti6 MTU from MTU of lower device > > 7a67e69a339a vti6: Keep set MTU on link creation or change, validate it > > > > The second of those will fail to build on branches older than 4.10 > > though. It might be better to revert this one instead. > > Thanks Ben for spotting this. > > Actually, > 53c81e95df17 ("ip6_vti: adjust vti mtu according to mtu of lower device") > alone improves things already, despite being "fixed" by > c6741fbed6dc ("vti6: Properly adjust vti6 MTU from MTU of lower device") > > With just 53c81e95df17 the MTU of a vti6 interface will be somewhat > linked to the MTU of the lower layer, but will be underestimated. > > With c6741fbed6dc the calculation of MTU from lower layer will be > accurate instead. > > However, without > 7a67e69a339a ("vti6: Keep set MTU on link creation or change, validate it") > but with > 53c81e95df17 ("ip6_vti: adjust vti mtu according to mtu of lower device") > assignment of MTU on link change is discarded, so this would actually > introduce a bug. > > Fixing > 7a67e69a339a ("vti6: Keep set MTU on link creation or change, validate it") > for 4.4 up to 4.9 is trivial, we simply need to adjust for the lack of > b96f9afee4eb ("ipv4/6: use core net MTU range checking") > and reflect the change introduced by > f8a554b4aa96 ("vti6: Fix dev->max_mtu setting"). > > So, Greg, here comes the backport of > 7a67e69a339a ("vti6: Keep set MTU on link creation or change, validate it") > based on latest linux-4.4.y branch, in case you want to keep the existing > change and add the follow-ups on top. Please let me know if I should submit > it formally. Ick, that's a mess. How about I just revert this patch from the stable trees, and then someone sends me either a list of git commits to apply, or patches, for the different trees if it's really needed? thanks, greg k-h