Received: by 10.213.65.68 with SMTP id h4csp445451imn; Fri, 6 Apr 2018 03:07:11 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/VYBzaqPPYrFrosQwDQxQ/nDHuXjYUILRc9aRIwn9OnSfFnkPkx6iRtyIUtWMdzO3Iygnt X-Received: by 2002:a17:902:b60c:: with SMTP id b12-v6mr26818209pls.203.1523009230996; Fri, 06 Apr 2018 03:07:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523009230; cv=none; d=google.com; s=arc-20160816; b=iTsM6VwT8iRlY9C+hfLy33GEAqS/S0u6HF8TmPGOgXIQkxh9c++nEJlumDkzrerkuw qCdRmFG+SaUeHp/iVg/M7SThFiIEcXy+hCx7ZL5lZ0lGAiQ+GdfPx4QnrENpP2KYZv9d 9D6DZTqTCdsTA7uhstvZU7vWkfly00wYrUJ/GQTqx5n1wYmcfltttYu48zgdDwNKrxnd 0QJnlMWQxx0y41mSMjq8vrgMQ218LvITwxrQppH0217PUNWhLq8Z5KEs7qKngy3v3krC EusiLhFu6SYwxf8bSm9b3s2J2c5+KV9fd0l3Qs7cbzZXkFdqFX5Ua4dfmzIouTitj7OZ TCSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=OcwSO95SxG4M+/CFhOKSZEg4bv2v3oPt94FKvQl3888=; b=pFsAwRgtUKqo2d2aAxl0tlOQcH0XMxwX34oJHkrauLKjEwzBK5OYal9sHnqxqp6wNT /YlDSySwzrcs0+CDYlCipgISBn039JAsMPLz2TfEu8FAziZtMbNLbuQKsIlDhZuNxLnr vWTs+44G+IloWbYBrIeGrlYBm5+TKhApnLNkulJsDHy2MYFruHKictkpVhLCUPSZMeSy XuqoiVcEZ1/i/LfX/M97h7HwJIarxHSWuXZVmG2oXygT1a/X0Pa4XwNaZRV98fbud9ue J5bY5Y7OFIWIaOVep9kHfsjeBIaF6vV8ZAOBEdgMOH6sepE67aYf8jGyIkJYwTDzmOBD OCrQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g7si5935755pfm.106.2018.04.06.03.06.56; Fri, 06 Apr 2018 03:07:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751949AbeDFKFt (ORCPT + 99 others); Fri, 6 Apr 2018 06:05:49 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:34564 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751540AbeDFKFr (ORCPT ); Fri, 6 Apr 2018 06:05:47 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A15F180D; Fri, 6 Apr 2018 03:05:46 -0700 (PDT) Received: from [10.1.207.55] (melchizedek.cambridge.arm.com [10.1.207.55]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F1E813F587; Fri, 6 Apr 2018 03:05:42 -0700 (PDT) Subject: Re: [PATCH 1/5] arm64: entry: isb in el1_irq To: Yury Norov Cc: "Paul E. McKenney" , Mark Rutland , Will Deacon , Chris Metcalf , Christopher Lameter , Russell King - ARM Linux , Steven Rostedt , Mathieu Desnoyers , Catalin Marinas , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Alexey Klimov , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20180405171800.5648-1-ynorov@caviumnetworks.com> <20180405171800.5648-2-ynorov@caviumnetworks.com> From: James Morse Message-ID: <5036b99a-9faa-c220-27dd-e0d73f8b3fc7@arm.com> Date: Fri, 6 Apr 2018 11:02:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180405171800.5648-2-ynorov@caviumnetworks.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yury, On 05/04/18 18:17, Yury Norov wrote: > Kernel text patching framework relies on IPI to ensure that other > SMP cores observe the change. Target core calls isb() in IPI handler (Odd, if its just to synchronize the CPU, taking the IPI should be enough). > path, but not at the beginning of el1_irq entry. There's a chance > that modified instruction will appear prior isb(), and so will not be > observed. > > This patch inserts isb early at el1_irq entry to avoid that chance. > diff --git a/arch/arm64/kernel/entry.S b/arch/arm64/kernel/entry.S > index ec2ee720e33e..9c06b4b80060 100644 > --- a/arch/arm64/kernel/entry.S > +++ b/arch/arm64/kernel/entry.S > @@ -593,6 +593,7 @@ ENDPROC(el1_sync) > > .align 6 > el1_irq: > + isb // pairs with aarch64_insn_patch_text > kernel_entry 1 > enable_da_f > #ifdef CONFIG_TRACE_IRQFLAGS > An ISB at the beginning of the vectors? This is odd, taking an IRQ to get in here would be a context-synchronization-event too, so the ISB is superfluous. The ARM-ARM has a list of 'Context-Synchronization event's (Glossary on page 6480 of DDI0487B.b), paraphrasing: * ISB * Taking an exception * ERET * (...loads of debug stuff...) Thanks, James