Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S274788AbTHPPv6 (ORCPT ); Sat, 16 Aug 2003 11:51:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S274804AbTHPPv6 (ORCPT ); Sat, 16 Aug 2003 11:51:58 -0400 Received: from waste.org ([209.173.204.2]:28346 "EHLO waste.org") by vger.kernel.org with ESMTP id S274788AbTHPPv5 (ORCPT ); Sat, 16 Aug 2003 11:51:57 -0400 Date: Sat, 16 Aug 2003 10:51:10 -0500 From: Matt Mackall To: James Morris Cc: "Theodore Ts'o" , Jamie Lokier , linux-kernel , Andrew Morton , davem@redhat.com Subject: Re: [RFC][PATCH] Make cryptoapi non-optional? Message-ID: <20030816155110.GH325@waste.org> References: <20030815221211.GA4306@think> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.28i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 986 Lines: 23 On Sat, Aug 16, 2003 at 09:35:24AM +1000, James Morris wrote: > On Fri, 15 Aug 2003, Theodore Ts'o wrote: > > > > d) not disable preemption for long stretches while hashing (a > > > limitation of cryptoapi) > > > > Sounds like a bug in CryptoAPI that should be fixed in CryptoAPI. > > This is for the case of hashing from a per cpu context, which is an > inherently unsafe context for introducing schedule points. This is not > a crypto API specific problem. Yes, but it's introduced by the requirements imposed by cryptoapi. The current code uses the stack (though currently rather a lot of it), which lets it be fully re-entrant. Not an option with cryptoapi. -- Matt Mackall : http://www.selenic.com : of or relating to the moon - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/