Received: by 10.213.65.68 with SMTP id h4csp847904imn; Fri, 6 Apr 2018 09:56:12 -0700 (PDT) X-Google-Smtp-Source: AIpwx48onpbPJcgtjwfHTmQ6J1VAes4Ju25fouSfNtPaVMvSSB7sV6D+9JybDnQNIWhWgiqXq5bh X-Received: by 10.101.101.206 with SMTP id y14mr3148211pgv.220.1523033772883; Fri, 06 Apr 2018 09:56:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523033772; cv=none; d=google.com; s=arc-20160816; b=sWccaBtuL/Zhl3kB9lpmSYCWiIYAsQ77S57vVcFUgqPVDY2wapZirtdYE/fx4CDDf1 bbg4FagvbOghWXZz6TA5Kne7o/eWyO/4zcTJBC/52EFR+BEJIfWZVrBDRg1+XAeKyjI4 szN9FkyekhVkq1ytQRmPREV6Qm95M1qSCXemSiOGe3etxvO761cVTcqJTQSLV6bKpQLT SuieQzoxBPoIXrLQV7EHsNAWLYzJfH+Eyr2ahNYEPN/BHseNPYodaPXl78+Kscxleudw T7RL1oUtxVIORSdkSnq/hZb4hdDFHfPYT727p4i3dkYjg2Ypex0HxLLzrGW4MkfvAbmw 936w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:mime-version:user-agent :message-id:in-reply-to:date:references:cc:to:from :arc-authentication-results; bh=GXqw09iE2WZ6rnrZSQhBqwG9bvnySPnsVKmdiubPjbo=; b=PdnmCShdkl4naVy0+P6XBwjUArXgYoucomBNa3ykDDE/6hrf/hgb3bJ6JcWXt6nbgl t6s50ROENeWQwqJxr3UE8VJK7Mak03DHOn9oQLU23HkIPhARHGaBgulno+pgHS9bZW7n Own7q/xg9N+vUEgE1bFdQNY7H1W2uql4+j8OnGNTSN6DXZ3lhJGveAAaIvL1pqwgZJXa tE7E8q6tt5j0O3jOklMEX566PHK76xd+QHbqQdndETK6D71wfaJ4snKfsq116vEbd2Hz 4cZaa2sKB5Av/fnHZaMVc1Jj8m60lZLL3iQPjR8dTl58ZDD/WMjnBMGNdGuXBpclZ205 UiJw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c18-v6si8961882plo.537.2018.04.06.09.55.36; Fri, 06 Apr 2018 09:56:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751874AbeDFQty (ORCPT + 99 others); Fri, 6 Apr 2018 12:49:54 -0400 Received: from out03.mta.xmission.com ([166.70.13.233]:43420 "EHLO out03.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750962AbeDFQtw (ORCPT ); Fri, 6 Apr 2018 12:49:52 -0400 Received: from in01.mta.xmission.com ([166.70.13.51]) by out03.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1f4UYh-0004HF-BW; Fri, 06 Apr 2018 10:49:51 -0600 Received: from [97.119.140.30] (helo=x220.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1f4UYg-0003es-NN; Fri, 06 Apr 2018 10:49:51 -0600 From: ebiederm@xmission.com (Eric W. Biederman) To: Christian Brauner Cc: Kirill Tkhai , davem@davemloft.net, gregkh@linuxfoundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, avagin@virtuozzo.com, serge@hallyn.com References: <20180404194857.29375-1-christian.brauner@ubuntu.com> <442e89b8-e947-6eeb-1bcb-fa28f22a25f0@virtuozzo.com> <20180405140709.GA1697@gmail.com> <941de2b9-332f-75fc-f8ac-4059a9b5426f@virtuozzo.com> <20180405144130.GB26043@gmail.com> <87in953ryi.fsf@xmission.com> <20180406130704.GB9263@gmail.com> <874lko2y22.fsf@xmission.com> <20180406160757.GA16281@gmail.com> Date: Fri, 06 Apr 2018 11:48:40 -0500 In-Reply-To: <20180406160757.GA16281@gmail.com> (Christian Brauner's message of "Fri, 6 Apr 2018 18:07:59 +0200") Message-ID: <878ta01dsn.fsf@xmission.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1f4UYg-0003es-NN;;;mid=<878ta01dsn.fsf@xmission.com>;;;hst=in01.mta.xmission.com;;;ip=97.119.140.30;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX18UpTC+KkMTUX3vAjek7BPquY8uFNX+Mq8= X-SA-Exim-Connect-IP: 97.119.140.30 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on sa06.xmission.com X-Spam-Level: X-Spam-Status: No, score=-0.2 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,T_TM2_M_HEADER_IN_MSG autolearn=disabled version=3.4.1 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.4993] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa06 1397; Body=1 Fuz1=1 Fuz2=1] X-Spam-DCC: XMission; sa06 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;Christian Brauner X-Spam-Relay-Country: X-Spam-Timing: total 169 ms - load_scoreonly_sql: 0.03 (0.0%), signal_user_changed: 2.5 (1.5%), b_tie_ro: 1.79 (1.1%), parse: 0.72 (0.4%), extract_message_metadata: 9 (5.6%), get_uri_detail_list: 0.98 (0.6%), tests_pri_-1000: 4.5 (2.7%), tests_pri_-950: 1.10 (0.7%), tests_pri_-900: 0.92 (0.5%), tests_pri_-400: 17 (10.1%), check_bayes: 16 (9.6%), b_tokenize: 5 (3.1%), b_tok_get_all: 5 (3.2%), b_comp_prob: 1.58 (0.9%), b_tok_touch_all: 2.2 (1.3%), b_finish: 0.58 (0.3%), tests_pri_0: 126 (74.8%), check_dkim_signature: 0.44 (0.3%), check_dkim_adsp: 2.5 (1.5%), tests_pri_500: 3.6 (2.1%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH net-next] netns: filter uevents correctly X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christian Brauner writes: >> At a practical level there should be no receivers. Plus performance >> issues. At least my memory is that any unprivileged user on the system >> is allowed to listen to those events. > > Any unprivileged user is allowed to listen to uevents if they have > net_broadcast in the user namespace the uevent socket was opened in; > unless I'm misreading. I believe you are. This code in do_one_broadcast. if (!net_eq(sock_net(sk), p->net)) { if (!(nlk->flags & NETLINK_F_LISTEN_ALL_NSID)) return; if (!peernet_has_id(sock_net(sk), p->net)) return; if (!file_ns_capable(sk->sk_socket->file, p->net->user_ns, CAP_NET_BROADCAST)) return; } Used to just be: if (!net_eq(sock_net(sk), p->net)) return; Which makes sense when you have a shared hash table and a shared mc_list between network namespaces. There is a non-container use of network namespaces where you just need different contexts were ip addresses can overlap etc. In that configuration where a single program is mananging multiple network namespaces being able to listen to rtnetlink events in all of them is an advantage. For that case a special socket option NETLINK_F_LISTEN_ALL_NSID was added that allowed one socket to listen for events from multiple network namespaces. If we rework the code in af_netlink.c that matters. However for just understanding uevents you can assume there are no sockets with NETLINK_F_LISTEN_ALL_NSID set. Eric