Received: by 10.213.65.68 with SMTP id h4csp509856imn; Sat, 7 Apr 2018 03:47:00 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/GJb8bLE8wf34Gz/hWNOJHpYQoRRa647gXILjr/q6o6Lsy7iR9cPVrxLCBRE056VnERiQs X-Received: by 2002:a17:902:7d10:: with SMTP id z16-v6mr945764pll.79.1523098020041; Sat, 07 Apr 2018 03:47:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523098020; cv=none; d=google.com; s=arc-20160816; b=V816TN9c4EmsROGvgVu5Baz+BfBmg8/PGvb4uZ5XxDByuAPwECh00k3Aj2h71dku/7 t5MKlA9m4qgCqilg0icllUz+NEbyxY98XdFxhXQZKM3U5mdt4L8mDFJ5j/NOZYdVupAA dk5wQ6UFHiqiibhxO05vjdX+CNoS1XF24YXKZs61t6fthSdFxAg4R6c2PhVR7+jW9v70 QbyZ8tF5fhmDuF7EoDbhXi8jtNKLwg25c/NMx8sjtd7WoUURYiXMzp/qI7d3k2duL2bh wyNB7eEzqrMzMGs01DUGXzLZscGzKuuXBhInAOwEE0mZJReBle8envRoMmNTRBhpFvbv RgAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=Jlpoif1p8nyrMQHP1HOZn877zemfAtY02rYrfxNKbuY=; b=UK2ql/O7Dr83BkLQ4db5Oz4H/UiTMcmwFC4LOWhroSg/utfbX7EjN76b+NBOeaXoZD SD+RmfZOY7umnaQOj9F9Lq7iLpU42wKSkLX02mREO/g36JvaGw1psRxu93TEoujqyMe+ d9MwT4vkZwpv8EiAHVI4VdVJXBL04QsffQq88aq3+ZwOBy8FoYCiZ3kh7zQIvAac+tda SpEZ0pLn9DY93z9a4IcANc691B+iLWmAyrTWV8AqovghAFB1qrzjoZhd9ynChwyylo53 1r0GDMbol69EjMJgkmXj7+3VlMw5piAEUf4VGJj85rltNkSZ+kMabCEnEoiqOOeW9LLD 3L/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Lz1U4Dxz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g9-v6si10147213plk.60.2018.04.07.03.46.22; Sat, 07 Apr 2018 03:47:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Lz1U4Dxz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751497AbeDGKnL (ORCPT + 99 others); Sat, 7 Apr 2018 06:43:11 -0400 Received: from mail-wr0-f174.google.com ([209.85.128.174]:43986 "EHLO mail-wr0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751181AbeDGKnK (ORCPT ); Sat, 7 Apr 2018 06:43:10 -0400 Received: by mail-wr0-f174.google.com with SMTP id p53so3791412wrc.10 for ; Sat, 07 Apr 2018 03:43:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Jlpoif1p8nyrMQHP1HOZn877zemfAtY02rYrfxNKbuY=; b=Lz1U4DxzGEnI7hilB+cxFbEfhHLgctkqrcBihcfsLn4pHv8mYKAUcfBgds9KsEEoxx 5g+37X61/ht5xkqnBWvdS4TWmHObc2LZ6lHjGnDC7Eid1L+zi/6KhozrMeWO6C4WOPDu AyzodZuuSSQdbN77fBeqIFlxd+ihJkx7lGkfI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Jlpoif1p8nyrMQHP1HOZn877zemfAtY02rYrfxNKbuY=; b=W7hTyvxw+Qn/109SCUhRCg6rS7XYJ/V8JAuz1XlnsSy5juh9KJ3KUeFHWsisoGVNK3 CrQ33TCVbnr1ObT1amscRoXFXpj2bZkMj4R5naYNEUsJzJKq8iiS7+Pgoui9MPofvHNA E44TUjVvdOqJskzGc4F9IV5lK8bPJyDlnlXkg31QXF33ibfJN5FtVtK30GQXQ3awtDOC rtHZqOyNucybr2Yc1rJluBuYI8ODkIv0ZEYV4X4E22o1MyrTc4V4Ixn2qA84ce89pk6d pb7lU1DxpBERenvoIaPAHIms2Bab1H5PquU3C0TWakemNQzJYVo4bMSyChWsiI9Fi3WW lPsQ== X-Gm-Message-State: AElRT7FEN7EYz+UeSN39krDS44IGWlMJiS+IYUupZ9Gkc/wDogdgttNB /lSSzg3Llc2YxyX4+jKxSn8ggw== X-Received: by 10.223.169.55 with SMTP id u52mr22944643wrc.29.1523097788758; Sat, 07 Apr 2018 03:43:08 -0700 (PDT) Received: from [192.168.1.9] (hst-221-73.medicom.bg. [84.238.221.73]) by smtp.googlemail.com with ESMTPSA id y100sm11958129wmh.2.2018.04.07.03.43.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 Apr 2018 03:43:07 -0700 (PDT) Subject: Re: [PATCH v3 2/2] drivers: soc: Add LLCC driver To: rishabhb@codeaurora.org, Stanimir Varbanov Cc: linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-arm@lists.infradead.org, linux-kernel@vger.kernel.org, tsoni@codeaurora.org, kyan@codeaurora.org, ckadabi@codeaurora.org References: <1522176722-12691-1-git-send-email-rishabhb@codeaurora.org> <1522176722-12691-3-git-send-email-rishabhb@codeaurora.org> From: Stanimir Varbanov Message-ID: Date: Sat, 7 Apr 2018 13:43:05 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 4.04.2018 20:30, rishabhb@codeaurora.org wrote: > Hi Stanimir, > We incorporated all your comments except the following: > 1. Removing the driver that maintains the SCT (system cache table) > per chipset. As responded earlier the data is expected to change > from chipset to chipset and would clutter the main driver if we > choose using compatible string. We think its good to keep the data > separate from core driver. > 2. Changing struct llcc_slice_desc to llcc_desc: > The descriptor is specific to each slice and not the whole llcc. > All the properties such as id and size are specific to each slice > and not whole llcc. > > please let me know if you are ok with the approach. Based on that > I can send my next revision of changes. Yes, please go ahead and send the next version. regards, Stan