Received: by 10.213.65.68 with SMTP id h4csp798261imn; Sat, 7 Apr 2018 09:48:52 -0700 (PDT) X-Google-Smtp-Source: AIpwx487gU3ucpc8y2x3Vw6bxiM7Nto8K6E+Of8aJrrvPrgQ2cHYJskLpG8RTKCZdFao+p8UOwnR X-Received: by 2002:a17:902:1e3:: with SMTP id b90-v6mr31937466plb.155.1523119732655; Sat, 07 Apr 2018 09:48:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523119732; cv=none; d=google.com; s=arc-20160816; b=nkUlNOIq5eNxb76NOgFHTcl3GCOMEqOYSKacbGvyYoC7iERGIQKluzuMhLEmE7xTti qUPXzxScDijFNTXCsrqV8gryZKBWrMzwwb3XlHEJkFrMQ6nVmaS1N55XUcPicm4cIzHB 8clOVzoEu/pyww0TmHXTbYxxkNQ0gB4PQxSjN8NcwpZFPXLacViTDBefZ0TxALiJd1Ob An3pyRwODaiKh697WLNv6SH0r/5jCu62iBxdZCCGrxBWLkNfubtVeFWqWeYTNydGGL46 oiq5/Vmo/3CEa1yRDPcWD1yPrubIgEFVUbnhrdnRCoik9BLQRHJAIUcZiEdv9feib4dz QGFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=/Exdt7KzqW8Dkl6Gs+HtrK81uhctfCPzhDV7dOgwW1Y=; b=lfYYj4MCS5jm1fQsfQDlEZskKmu/gGpo2p8zrmdYawfVEk2AaJHENW6HhyVGN69M2Z zsZ+j2WZprIPBSd+//U1bmHYZAqxGCSEnQIOWH9nKU2F7fFNExKGpLQtM3f1i4ttwlOW vwcY7SIqDlaPdiBgloeV1CafRXoZvcTIYTlsUVvbotRzqUkfvlXZ1Ny7VsEEH7+WmQYI FL2LX4XTJAElDMpxYMwImQgduJTyBveBhfBZ+FC4DmbK6I/jtk/DWYOfg1m/Q94/nfa0 zRmjka3kQL4KqCXAcnGAxs6jr/gG7+C5MG+yV1beCON5+/dacPAgIodPpcf4l6q7+9vk /Cnw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=WDaLNSdw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j2-v6si11948261pli.501.2018.04.07.09.48.14; Sat, 07 Apr 2018 09:48:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=WDaLNSdw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752084AbeDGQo7 (ORCPT + 99 others); Sat, 7 Apr 2018 12:44:59 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:38646 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751704AbeDGQo5 (ORCPT ); Sat, 7 Apr 2018 12:44:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=/Exdt7KzqW8Dkl6Gs+HtrK81uhctfCPzhDV7dOgwW1Y=; b=WDaLNSdw8Ehe7uSbe12Qk9aev pCpaQH3VWLChkL4ufEHgrU0+hKwpfQZiYzdghS3PzQ3yeXRGtMQnBmh0u1jQvIukf9c8uiiPkqXjI kaEr2cQhr/8MHAYgoOHJsiBAAGRNVhx/Hb1SCJk+uJn3JrlmZxXXnWYqxlJmtisEb6SLkCfnKmuJH 9NjBp43KKfgZ/92BxYOO/NthdZNi99YrxACH81pB/Z+R0ooRzhh/iygXTgzPf3PghvDokm/9zGJ1c r8SBJqky6tT3bsIYzDh8ZmeZbBJugGFS7fo8cJoK/8g7DYjsr+ODki5AYtB3TqyHBkZLpyL5Z76ji P99l0yHRA==; Received: from dvhart by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1f4qxN-0000nX-QQ; Sat, 07 Apr 2018 16:44:49 +0000 Date: Sat, 7 Apr 2018 09:44:48 -0700 From: Darren Hart To: Kai-Heng Feng Cc: mjg59@srcf.ucam.org, pali.rohar@gmail.com, andy@infradead.org, mario.limonciello@dell.com, tiwai@suse.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH v2 1/3] dell-led: Change dell-led.h to dell-common.h Message-ID: <20180407164448.GC11256@fury> References: <20180308091023.9061-1-kai.heng.feng@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180308091023.9061-1-kai.heng.feng@canonical.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 08, 2018 at 05:10:21PM +0800, Kai-Heng Feng wrote: > This header will be used for more than just led. Change it to a more > generic name. > > Signed-off-by: Kai-Heng Feng > --- > v2: Mario suggested to squash the HDA part into the same series. Apologies for the silence on my end. I've reviewed all the comments, and my understanding is we are awaiting a v3 from Kai-Heng. Is that correct? Mario and Pali, thank you for working through the heuristics of platform identification. I appreciate taking the time to look at the big picture, or the scale impacts ("what if everyone did this?") - that leads to better solutions. Of course, this is the platform driver subsystem, and part of why we exist is to cover the quirks of today's systems, so we can't spend too much time on what-ifs. I think your conclusions were reasonable. So I'm waiting for v3 from Kai-Heng - unless I've misunderstood the conclusion of this thread. -- Darren Hart VMware Open Source Technology Center