Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org BDFC660540
Date:   Sat, 7 Apr 2018 20:31:30 -0500
From:   Richard Kuo <rkuo@codeaurora.org>
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] hexagon: add memset_io() helper
Message-ID: <20180408013130.GC3036@codeaurora.org>
References: <20180406142832.2243021-1-arnd@arndb.de>
 <20180406142832.2243021-2-arnd@arndb.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180406142832.2243021-2-arnd@arndb.de>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Apr 06, 2018 at 04:28:22PM +0200, Arnd Bergmann wrote:
> We already have memcpy_toio(), but not memset_io(), so let's
> add the obvious version to allow building an allmodconfig kernel
> without errors like
> 
> drivers/gpu/drm/ttm/ttm_bo_util.c: In function 'ttm_bo_move_memcpy':
> drivers/gpu/drm/ttm/ttm_bo_util.c:390:3: error: implicit declaration of function 'memset_io' [-Werror=implicit-function-declaration]
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  arch/hexagon/include/asm/io.h | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/hexagon/include/asm/io.h b/arch/hexagon/include/asm/io.h
> index 9e8621d94ee9..e17262ad125e 100644
> --- a/arch/hexagon/include/asm/io.h
> +++ b/arch/hexagon/include/asm/io.h
> @@ -216,6 +216,12 @@ static inline void memcpy_toio(volatile void __iomem *dst, const void *src,
>  	memcpy((void *) dst, src, count);
>  }
>  
> +static inline void memset_io(volatile void __iomem *addr, int value,
> +			     size_t size)
> +{
> +	memset((void __force *)addr, value, size);
> +}
> +
>  #define PCI_IO_ADDR	(volatile void __iomem *)
>  
>  /*

Acked-by: Richard Kuo <rkuo@codeaurora.org>


-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, 
a Linux Foundation Collaborative Project