Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S269578AbTHQMqf (ORCPT ); Sun, 17 Aug 2003 08:46:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S269583AbTHQMqf (ORCPT ); Sun, 17 Aug 2003 08:46:35 -0400 Received: from pub234.cambridge.redhat.com ([213.86.99.234]:62226 "EHLO phoenix.infradead.org") by vger.kernel.org with ESMTP id S269578AbTHQMqf (ORCPT ); Sun, 17 Aug 2003 08:46:35 -0400 Date: Sun, 17 Aug 2003 13:46:34 +0100 From: Christoph Hellwig To: Dominik Strasser Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi.h uses "u8" which isn't defined. Message-ID: <20030817134633.A7881@infradead.org> Mail-Followup-To: Christoph Hellwig , Dominik Strasser , linux-kernel@vger.kernel.org References: <3F3F782C.2030902@t-online.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <3F3F782C.2030902@t-online.de>; from Dominik.Strasser@t-online.de on Sun, Aug 17, 2003 at 02:42:20PM +0200 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 575 Lines: 13 On Sun, Aug 17, 2003 at 02:42:20PM +0200, Dominik Strasser wrote: > scsi.h uses "u8" which doesn't seem to be defined. > Better use u_char. It's defined in as is u_char. But we generally prefer explicitly sized types in Linux - and u_char is a BSDism, the right not explicitly sized type would be unsigned char. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/