Received: by 10.213.65.68 with SMTP id h4csp1540170imn; Sun, 8 Apr 2018 06:02:02 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+CJ2GsZj2lvfiEIk304s0J2D+gpXADJED1Iosb/H4efb5UaMeE8Wkg+O2KLWGAOT1lT9H6 X-Received: by 10.101.73.207 with SMTP id t15mr22991767pgs.204.1523192522241; Sun, 08 Apr 2018 06:02:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523192522; cv=none; d=google.com; s=arc-20160816; b=DzEXmPOqQFwNHyK9Rzllm4PZuIweirFRRmAar2inr2Y3Jjm+2nDeg4RXWfkpuunVpE crKXQxpnKhyOPuCCl6QH1a6MpoCK8NIzDqStO7yNzgLQ3tLlK72SivlKJ0ClhlxT9MQO iFveRWQ+jDU8AxBY8MvDWjOKFWe2bOFSJQ/B3jQyRz61Ios/MeOlZ8uAfR0lVq8YXa6u 7BOmTWxOZHkDI4/5UGjZpuyBmTpipBklB90Yr5auJpUsXkPttERRB9diJtzobLW4vcTw QzlSEaO/nwmP1j7YTidy8tNFtLcIRXxSQPP4bHoAUMFw9DDZ+3wAEcKWyHXxOTnp6eER aCoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from :arc-authentication-results; bh=vr5EV1lbnx+Ts/ncQRcmDpXNpkty0ZqxMUqLBGH4oMY=; b=Tz1jqneY4YVyT1jjJf1vLyTp/9y/2gRNdytw8j8iJW8Qh4wk+uCB1Bh0nxr7kZJ1gV spyaDIKDBwm6Dp7IswHxUPOeCo6l2thsx5vBtcHL6/59HCmwKXy5PBcg+tgFsqmZj8hU SVch0LYOm4EV7n+dxleiINFqdV2qPhJvO9xDF/Tc4WdNNrLoZlT2rSZj25osD9Iiz3iV D+dFRN3c6hnbiugc1NKJXt/4WNq58+BLZQnT5eBIZWVcS90V/55ld9X2NoJZMDrMUJjG t4L+3ZZCURANCxRimYHP0dPbTWVgdOeYPm6UAWvvxkh594V2EJqFMEP/3hoHS2djVDvG ka1A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i129si9840206pgd.206.2018.04.08.06.01.24; Sun, 08 Apr 2018 06:02:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751728AbeDHMQX (ORCPT + 99 others); Sun, 8 Apr 2018 08:16:23 -0400 Received: from smtp01.smtpout.orange.fr ([80.12.242.123]:56688 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751367AbeDHMQW (ORCPT ); Sun, 8 Apr 2018 08:16:22 -0400 Received: from belgarion ([86.201.130.131]) by mwinf5d36 with ME id XoGH1x00D2qEl8e03oGJJj; Sun, 08 Apr 2018 14:16:20 +0200 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Sun, 08 Apr 2018 14:16:20 +0200 X-ME-IP: 86.201.130.131 From: Robert Jarzmik To: Arnd Bergmann , Liam Girdwood , Mark Brown Cc: Daniel Mack , Haojian Zhuang , Vinod Koul , Jaroslav Kysela , Takashi Iwai , Linux ARM , Linux Kernel Mailing List , alsa-devel@alsa-project.org Subject: Re: [PATCH 14/15] ARM: pxa: change SSP devices allocation References: <20180402142656.26815-1-robert.jarzmik@free.fr> <20180402142656.26815-15-robert.jarzmik@free.fr> <87lge4485x.fsf@belgarion.home> <87zi2i2ljy.fsf@belgarion.home> X-URL: http://belgarath.falguerolles.org/ Date: Sun, 08 Apr 2018 14:16:17 +0200 In-Reply-To: (Arnd Bergmann's message of "Thu, 5 Apr 2018 09:29:30 +0200") Message-ID: <87o9it3nce.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd Bergmann writes: > I don't know exactly how the probing works, but I'd assume that we have > the correct device pointers in pxa2xx_ac97_dev_probe() and > asoc_ssp_probe(), or maybe in pxa2xx_ac97_*_startup() and > pxa_ssp_startup(). Yes, let's try this way, in the former patch "ASoC: pxa: remove the dmaengine compat need" : +++ b/sound/arm/pxa2xx-pcm-lib.c @@ -126,7 +127,7 @@ int __pxa2xx_pcm_open(struct snd_pcm_substream *substream) return ret; return snd_dmaengine_pcm_open( - substream, dma_request_slave_channel(rtd->platform->dev, + substream, dma_request_slave_channel(rtd->cpu_dai->dev, dma_params->chan_name)); } The cpu_dai device should be either pxa27x_ac97 or pxa-ssp-dai., and amend the dma slave map accordingly. Cheers. -- Robert