Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A9182177A
Date:   Sun, 8 Apr 2018 08:47:56 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Zhaoyang Huang <huangzhaoyang@gmail.com>
Cc:     Ingo Molnar <mingo@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] ringbuffer: Don't choose the process with adj equal
 OOM_SCORE_ADJ_MIN
Message-ID: <20180408084717.62ee4f9e@gandalf.local.home>
In-Reply-To: <CAGWkznHVGTpvfQOvaOGP6fYDWh0Os0pYXTC3gG_qvW6mCDuybQ@mail.gmail.com>
References: <1523153783-20579-1-git-send-email-zhaoyang.huang@spreadtrum.com>
        <20180407234812.2bf2b24b@gandalf.local.home>
        <CAGWkznHVGTpvfQOvaOGP6fYDWh0Os0pYXTC3gG_qvW6mCDuybQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

[ Removing kernel-patch-test, because of annoying "moderator" messages ]

On Sun, 8 Apr 2018 13:54:59 +0800
Zhaoyang Huang <huangzhaoyang@gmail.com> wrote:

> On Sun, Apr 8, 2018 at 11:48 AM, Steven Rostedt <rostedt@goodmis.org> wrote:
> > On Sun,  8 Apr 2018 10:16:23 +0800
> > Zhaoyang Huang <huangzhaoyang@gmail.com> wrote:
> >  
> >> Don't choose the process with adj == OOM_SCORE_ADJ_MIN which
> >> over-allocating pages for ring buffers.  
> >
> > Why?
> >
> > -- Steve  
> because in oom_evaluate_task, the process with adj == OOM_SCORE_ADJ_MIN will
> be suppressed by oom_badness, but with applying your latest patch,
> such process will
> be selected by oom_task_origin
> 
>         if (oom_task_origin(task)) {
>                 points = ULONG_MAX;
>                 goto select;
>         }
> 
>         points = oom_badness(task, NULL, oc->nodemask, oc->totalpages);
>         if (!points || points < oc->chosen_points)
>                 goto next;

And what's wrong with that?

-- Steve