Message-ID: <3F3F7E67.2040506@t-online.de>
Date: Sun, 17 Aug 2003 15:08:55 +0200
From: Dominik.Strasser@t-online.de (Dominik Strasser)
User-Agent: Mozilla/5.0 (X11; U; Linux i586; en-US; rv:1.4) Gecko/20030624
MIME-Version: 1.0
To: Christoph Hellwig <hch@infradead.org>
CC: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi.h uses "u8" which isn't defined.
References: <3F3F782C.2030902@t-online.de> <20030817134633.A7881@infradead.org>
In-Reply-To: <20030817134633.A7881@infradead.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 842
Lines: 24

Christoph Hellwig wrote:
> On Sun, Aug 17, 2003 at 02:42:20PM +0200, Dominik Strasser wrote:
> 
>>scsi.h uses "u8" which doesn't seem to be defined.
>>Better use u_char.
> 
> 
> It's defined in <linux/types.h> as is u_char.  But we generally prefer
> explicitly sized types in Linux - and u_char is a BSDism, the right
> not explicitly sized type would be unsigned char.

I am sorry, in 2.6.0-test3 (which I should have mentioned), there is no 
u8 in liux/types.h. Just a __u8.
Nevertheless there is a mixture in scsi.h, some lines above, u_char is 
used. This is why I chose to use it.

Dominik


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/