Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Sasha Levin <Alexander.Levin@microsoft.com>
To:     "stable@vger.kernel.org" <stable@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     Daniel Scheller <d.scheller@gmx.net>,
        Mauro Carvalho Chehab <mchehab@s-opensource.com>,
        Sasha Levin <Alexander.Levin@microsoft.com>
Subject: [PATCH AUTOSEL for 4.9 141/293] media: dvb-frontends/cxd2841er:
 require STATE_ACTIVE_* for agc readout
Thread-Topic: [PATCH AUTOSEL for 4.9 141/293] media: dvb-frontends/cxd2841er:
 require STATE_ACTIVE_* for agc readout
Thread-Index: AQHTz5knD/t7gb0GBEG7i9l1syJYYA==
Date:   Mon, 9 Apr 2018 00:24:43 +0000
Message-ID: <20180409002239.163177-141-alexander.levin@microsoft.com>
References: <20180409002239.163177-1-alexander.levin@microsoft.com>
In-Reply-To: <20180409002239.163177-1-alexander.levin@microsoft.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: microsoft.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d4ccee7-824e-484c-aa3a-08d59db118ab
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2018 00:24:43.2688
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB0807
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Daniel Scheller <d.scheller@gmx.net>

[ Upstream commit 8982735f8dd02096b75255e3c0a0df28aeaa9955 ]

When the demod driver puts the demod into sleep or shutdown state and it's
status is then polled e.g. via "dvb-fe-tool -m", i2c errors are printed
to the kernel log. If the last delsys was DVB-T/T2:

  cxd2841er: i2c wr failed=3D-5 addr=3D6c reg=3D00 len=3D1
  cxd2841er: i2c rd failed=3D-5 addr=3D6c reg=3D26

and if it was DVB-C:

  cxd2841er: i2c wr failed=3D-5 addr=3D6c reg=3D00 len=3D1
  cxd2841er: i2c rd failed=3D-5 addr=3D6c reg=3D49

This happens when read_status unconditionally calls into the
read_signal_strength() function which triggers the read_agc_gain_*()
functions, where these registered are polled.

This isn't a critical thing since when the demod is active again, no more
such errors are logged, however this might make users suspecting defects.

Fix this by requiring STATE_ACTIVE_* in priv->state. If it isn't in any
active state, additionally set the strength scale to NOT_AVAILABLE.

Signed-off-by: Daniel Scheller <d.scheller@gmx.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
---
 drivers/media/dvb-frontends/cxd2841er.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/media/dvb-frontends/cxd2841er.c b/drivers/media/dvb-fr=
ontends/cxd2841er.c
index b97647cd7dc6..8c175d959038 100644
--- a/drivers/media/dvb-frontends/cxd2841er.c
+++ b/drivers/media/dvb-frontends/cxd2841er.c
@@ -3210,7 +3210,10 @@ static int cxd2841er_get_frontend(struct dvb_fronten=
d *fe,
 	else if (priv->state =3D=3D STATE_ACTIVE_TC)
 		cxd2841er_read_status_tc(fe, &status);
=20
-	cxd2841er_read_signal_strength(fe);
+	if (priv->state =3D=3D STATE_ACTIVE_TC || priv->state =3D=3D STATE_ACTIVE=
_S)
+		cxd2841er_read_signal_strength(fe);
+	else
+		p->strength.stat[0].scale =3D FE_SCALE_NOT_AVAILABLE;
=20
 	if (status & FE_HAS_LOCK) {
 		cxd2841er_read_snr(fe);
--=20
2.15.1