Received: by 10.213.65.68 with SMTP id h4csp2117844imn; Sun, 8 Apr 2018 20:09:00 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/mVvxB4mP2ekl0UCOiXsIw7cUYMGxnnpQZy0DqqHH7Xrgo79UM8uSh5Qlc+igbG+eQGKFk X-Received: by 2002:a17:902:7804:: with SMTP id p4-v6mr37364912pll.17.1523243340085; Sun, 08 Apr 2018 20:09:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523243340; cv=none; d=google.com; s=arc-20160816; b=D6bZIKlgv+ZMAcRRUzcZ2L8UiSLKm2nY63AubL7ZR95TYX5+YNwUfL1L4xaxF97bm5 IUFpMpSK/zB8gcJOw6noypjQuMebJOWObTRzYfmOQOXwSLqZjcL1sP2oekElrxxdyjAw OUb2p4DnJtv3sa0lkLlNDMPMm9n3FjQtXu28FKZFV/nmb8elD4RqAxkwV0mAL4m4BTT7 7wOuOJCrI04rYY1zGh4d8YKMzsFTqKBp0DvkJsvjsMn1dNZ0GrXkvjTvLCnLoz18/rbV hfIifsz6UHmgdZ88E4yTRSXELMGwz/m17G8wtvZeSAdU3uF5S5FEn1Ci1YXZH/zJCEbH M8/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=GCLLK9fSnUa8TxIjpA+II7c/w1l7p+ID69gW2IbbZwU=; b=JPqJbb8OtLHjE8srrkkVmCC+f7Kc1GDCxEwIjcvgGHhRhaVDZ0nGrKV04FnI/z8kxB JLbMRAmAlL99/MWgfAYowClMPs5a8JLxDJ1UGUHeqkA8jAB/wfYAMjyuDZPDUmKtBf9x klvaP8lIoBMtLCcKO3vT3ZqUZnjMvFeH762SXQrsw8Co6JxAtDmlalqC93fKfw+e6nFy OhzeJaqi6dU88U19y4hNzFUjsAYZ8SA+XIWtfbbbFjmjCL0h5a3b6v1hoxEDM1JRrezL LtBYbXPrtNRoSdLPlFQyC2re2ZDDZgKKj+K2c2OuiOmcq/u+Goghe+g+CzgiPL0SiFQb rsjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=Odz7Wf2t; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h23si11335943pfn.287.2018.04.08.20.08.23; Sun, 08 Apr 2018 20:09:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=Odz7Wf2t; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932310AbeDICPO (ORCPT + 99 others); Sun, 8 Apr 2018 22:15:14 -0400 Received: from mail-dm3nam03on0104.outbound.protection.outlook.com ([104.47.41.104]:17478 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756080AbeDIAag (ORCPT ); Sun, 8 Apr 2018 20:30:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=GCLLK9fSnUa8TxIjpA+II7c/w1l7p+ID69gW2IbbZwU=; b=Odz7Wf2tX8+h8HS2MH0Z63Mo9NUEc6iO9MAmlmw1wUCMi6XVGamyQFv5k7n7RtgYc0pgpHlgUsHQnUjKZQfcJwreV/WmB+PRfoqlbiEe2Pl5WoWbuA3hf6lW65GxOFPXC4otZ0gRsSrapVj9mAxs4WEoU6MK75hrWc/Ku7jUC30= Received: from DM5PR2101MB1032.namprd21.prod.outlook.com (52.132.128.13) by DM5PR2101MB0807.namprd21.prod.outlook.com (10.167.110.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.696.3; Mon, 9 Apr 2018 00:30:31 +0000 Received: from DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8109:aef0:a777:7059]) by DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8109:aef0:a777:7059%2]) with mapi id 15.20.0696.003; Mon, 9 Apr 2018 00:30:31 +0000 From: Sasha Levin To: "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: Marcelo Ricardo Leitner , "David S . Miller" , Sasha Levin Subject: [PATCH AUTOSEL for 4.9 144/293] sctp: adjust ssthresh when transport is idle Thread-Topic: [PATCH AUTOSEL for 4.9 144/293] sctp: adjust ssthresh when transport is idle Thread-Index: AQHTz5kpSso8gShfnkaOnkyEr6cjIw== Date: Mon, 9 Apr 2018 00:24:45 +0000 Message-ID: <20180409002239.163177-144-alexander.levin@microsoft.com> References: <20180409002239.163177-1-alexander.levin@microsoft.com> In-Reply-To: <20180409002239.163177-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM5PR2101MB0807;7:vzBQhpzV6wRnLGJ8RUpeUqFfL8K5oML4M0CNWnGt2JaFhW8C6B8yMO/AebkvHE+ZARISHg55/GDaWoAiDwfT4LcLcCtUSI7Nf95weqDzID7Mi7WY3qT4t4FJxlDtxTxmAOCbhRgjdO/RZAzsqS5mGjujMcUGQ6cMliC9I0c3DisiHckPXvbHMzuBnyIwcj46MhezgZuC4x0qOeYvsQR+8EdZ13Jm6PVNjeF2s+S/pbmX6ZqlvYppTVmcNht3YuVf;20:WLcLU1kx7jYc9I4OoxPvlvtElf5hmmvqhlGmTEYEFFvmSrrG2v0SnPFxvnN1jeedq2EtH8TEosBk9+FDZiLWz7YQYw7s4pLsu6zJktB1glbKXzaW3SyFienM04iGeidFxoyLz+c6zqQSuTN62paRVcQRi89/FNEWzHHKPabaJcY= x-ms-office365-filtering-ht: Tenant X-MS-Office365-Filtering-Correlation-Id: df88a098-f5ce-40a8-89db-08d59db119ce x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7193020);SRVR:DM5PR2101MB0807; x-ms-traffictypediagnostic: DM5PR2101MB0807: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(85827821059158); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(61425038)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3231221)(944501327)(52105095)(3002001)(6055026)(61426038)(61427038)(6041310)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:DM5PR2101MB0807;BCL:0;PCL:0;RULEID:;SRVR:DM5PR2101MB0807; x-forefront-prvs: 0637FCE711 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(39380400002)(39860400002)(396003)(366004)(376002)(346002)(199004)(189003)(14454004)(4326008)(54906003)(25786009)(966005)(53936002)(2900100001)(1076002)(3280700002)(6486002)(186003)(2616005)(68736007)(110136005)(11346002)(10090500001)(6116002)(107886003)(3846002)(36756003)(8676002)(72206003)(22452003)(66066001)(26005)(39060400002)(6512007)(478600001)(3660700001)(6306002)(81156014)(86362001)(81166006)(86612001)(7736002)(305945005)(8936002)(10290500003)(6436002)(105586002)(6666003)(316002)(59450400001)(76176011)(5660300001)(476003)(106356001)(2906002)(6506007)(446003)(2501003)(99286004)(5250100002)(486006)(102836004)(97736004)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR2101MB0807;H:DM5PR2101MB1032.namprd21.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 4xu21TRyfeD2BcU9K/33uOxzWvc5SmD5teeWDXag4aiTtyzveTKekmUD6mOcDHdj+lWkOnIyUQL8veSmC2DontgvBETKfh6x31GVjCrIcpdpGELA++pfmEyd2+RK58OohNAhfLzO+VB3CSQf6wfWAspRiIJIrUkv7TyIMDeEXoFrrmwVgNqKvy2Xxdrak4Ykx/fUvpEvuuA4VT3UknM3PUaOA/ujvl5pk7yGpBOYF6pP0uEDxLG7q6uDNt0qjD2YAHfSPGQjlWPkNTuOunVUnsfVFVZMHFSsVFteKHCjh4noeVpNZCh8fJSY37K9iooei7VhDK4jYS9R8kqz1rDRpktWkk/9fZOMRs+nN05rKHm9W7bngDlsuJhz7tRvVJO11WMiY/u7X9k8XeM2TcY5l8LfzksrP7iiHPgqWFuecIY= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: df88a098-f5ce-40a8-89db-08d59db119ce X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2018 00:24:45.6594 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB0807 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Marcelo Ricardo Leitner [ Upstream commit a02d036c027e9070ca27c156f59eb445d5405480 ] RFC 4960 Errata 3.27 identifies that ssthresh should be adjusted to cwnd because otherwise it could cause the transport to lock into congestion avoidance phase specially if ssthresh was previously reduced by some packet drop, leading to poor performance. The Errata says to adjust ssthresh to cwnd only once, though the same goal is achieved by updating it every time we update cwnd too. The caveat is that we could take longer to get back up to speed but that should be compensated by the fact that we don't adjust on RTO basis (as RFC says) but based on Heartbeats, which are usually way longer. See-also: https://tools.ietf.org/html/draft-ietf-tsvwg-rfc4960-errata-01#se= ction-3.27 Signed-off-by: Marcelo Ricardo Leitner Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/sctp/transport.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/sctp/transport.c b/net/sctp/transport.c index ce54dce13ddb..f130167ea323 100644 --- a/net/sctp/transport.c +++ b/net/sctp/transport.c @@ -551,6 +551,8 @@ void sctp_transport_lower_cwnd(struct sctp_transport *t= ransport, */ transport->cwnd =3D max(transport->cwnd/2, 4*asoc->pathmtu); + /* RFC 4960 Errata 3.27.2: also adjust sshthresh */ + transport->ssthresh =3D transport->cwnd; break; } =20 --=20 2.15.1