Received: by 10.213.65.68 with SMTP id h4csp2118034imn; Sun, 8 Apr 2018 20:09:15 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/UElDSRD5hyK5WmYrWeT6mIEv1tquc7dMVIGpBWL4pu/kGyBAWFDVlKZPW8hXY6V8UI3dl X-Received: by 2002:a17:902:149:: with SMTP id 67-v6mr37502848plb.296.1523243355585; Sun, 08 Apr 2018 20:09:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523243355; cv=none; d=google.com; s=arc-20160816; b=cIe4WN19c5pr1CtFuWVxlwqbqSG2dP+wSSh+buq+FQIrmNI8L2K+Ro4MhUenoKw7tf mbL5CEg8I0h/AMqlEbGkSfYY6/CReQudG/Kuzz1c7NZvDj12fQN0ak03oqzXFpwF7rQG NkbPfh34himLKT7P6dXZUFlZCIc4Ca35ElP55CTFqPbk/1KwZpBnxe/4u/ABlPhX0Qgz +b+zJ/J2Z5NYUqART3HC4ywIIom0Rejkvu7LkgS41f8x2isQhSsbcXGQFW+9U5wN8G/v JzW5JjsKS5v2DQ5m6IFyFYNi1XHeBFhPPWGzFsOeEqn8i8zBdihii/AvX44KFTwMxEkY Qilw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=1RfBXGib3kGAqXam8feZrqilK8UL0hdK2hbgcQ0IyLY=; b=Cu6xnG5JTTp4EZ3wiM036Fzv/bmAQYump1lqKAqPxLeVz7YNr10kH3mjzaYg5FFMWK 11s/nj7HBKq1G/9suQ/issWYnPjxO08bxYAI7ZYOAotpTXD5uxb5yPhLSedZVKKymtVd JSDGNb/RtSh5TbATL2BmNaM9vxygB1u0k2I+48SJ6t8PfW/tPfoG99OGwbGjB5wvG3jx 1J/5v0kbgWrBFe59KO0kk1noGyek+g2jnV0ZSSdtqcWwtVejp5lZ7Gmy3np8riv9oHKq Q433koZOeegnGRhaiDWVxJhfpfESqGOmVvEx32/s98Tu7oSgYOnjz9N7FgiTafooSV2U i8pg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=M2RO41o2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 97-v6si11087328plm.548.2018.04.08.20.08.38; Sun, 08 Apr 2018 20:09:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=M2RO41o2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757468AbeDIC1O (ORCPT + 99 others); Sun, 8 Apr 2018 22:27:14 -0400 Received: from mail-dm3nam03on0110.outbound.protection.outlook.com ([104.47.41.110]:12595 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755909AbeDIA2p (ORCPT ); Sun, 8 Apr 2018 20:28:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=1RfBXGib3kGAqXam8feZrqilK8UL0hdK2hbgcQ0IyLY=; b=M2RO41o2dgHxR7Q7YbkY4+ORmjFYdvbzzqbXl7OsoGdWZcYV7wLuPk9SGKov+cvH8pHtLjPuMQWgJaqwv0rYy84BuqOgtp7tz1/AVfhTDn59MdnQT/1+muCQDkZGUT17i6GON6EhiV3gPtIQ4C1LpRzGH83yysWxd6Ze64wBIpc= Received: from DM5PR2101MB1032.namprd21.prod.outlook.com (52.132.128.13) by DM5PR2101MB0807.namprd21.prod.outlook.com (10.167.110.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.696.3; Mon, 9 Apr 2018 00:28:37 +0000 Received: from DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8109:aef0:a777:7059]) by DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8109:aef0:a777:7059%2]) with mapi id 15.20.0696.003; Mon, 9 Apr 2018 00:28:37 +0000 From: Sasha Levin To: "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: Ganesh Goudar , "David S . Miller" , Sasha Levin Subject: [PATCH AUTOSEL for 4.9 090/293] cxgb4: fix a NULL dereference Thread-Topic: [PATCH AUTOSEL for 4.9 090/293] cxgb4: fix a NULL dereference Thread-Index: AQHTz5kQuZNnFpDaO0ya+YpBX9CSUA== Date: Mon, 9 Apr 2018 00:24:04 +0000 Message-ID: <20180409002239.163177-90-alexander.levin@microsoft.com> References: <20180409002239.163177-1-alexander.levin@microsoft.com> In-Reply-To: <20180409002239.163177-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM5PR2101MB0807;7:0AInsYfWZJdy8k2F3+0enRZhQLrQxnFNvOVYu/KgQBkjRkuwwLxqzALn8DFbHC0YKNuzbrE1k8k2PMCDdPSH8wsYxiwmEuYxy3bMDqtZCPxpg8Vss8b/UG5AhCfpjlyuee1GUUpWGu7VPxtY4IXMCu+2+n7yLg5VdV+2H8mimMja8paNwDJDNgEyjATO8ztqNpMnN2R6wtZHnUP9X53VlvoduP1hpJDWDCldbzc1w27R1EKEEI7O9oUXXdbP8V3Y;20:X661Tk57hZW2cdCwDkjuSVNc1Rbaa/EQ9/fyydlqsgOnmC7O29OPL2TvK6UbqCObG4GiL46kJMGGN0oqf47qGNkg6GnvjUnhtihW8YLdqAr2RmbbYgXjV8SyJuCoN8GUtG8l4Qe3oIXk88OLpzpCqfgNQm6HD4ZTt4+Bl5xt2vU= x-ms-office365-filtering-ht: Tenant X-MS-Office365-Filtering-Correlation-Id: b09c6c0b-8f30-4d9b-58b6-08d59db0d5fa x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7193020);SRVR:DM5PR2101MB0807; x-ms-traffictypediagnostic: DM5PR2101MB0807: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(61425038)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3231221)(944501327)(52105095)(3002001)(6055026)(61426038)(61427038)(6041310)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:DM5PR2101MB0807;BCL:0;PCL:0;RULEID:;SRVR:DM5PR2101MB0807; x-forefront-prvs: 0637FCE711 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(39380400002)(39860400002)(396003)(366004)(376002)(346002)(199004)(189003)(14454004)(4326008)(54906003)(25786009)(53936002)(2900100001)(1076002)(3280700002)(6486002)(186003)(2616005)(68736007)(110136005)(11346002)(10090500001)(6116002)(107886003)(3846002)(36756003)(8676002)(72206003)(22452003)(66066001)(26005)(6512007)(478600001)(3660700001)(81156014)(86362001)(81166006)(86612001)(7736002)(305945005)(8936002)(10290500003)(6436002)(105586002)(6666003)(316002)(59450400001)(76176011)(5660300001)(476003)(106356001)(2906002)(6506007)(446003)(2501003)(99286004)(5250100002)(486006)(102836004)(97736004)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR2101MB0807;H:DM5PR2101MB1032.namprd21.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 4MbTe91sZcXnTXCxmOTOLfrdZSiiVXE0nx5nZ7qX6LcKaYe8GlgFp13pa/T9d8vXfsMVI5B+CzipeRCWWnHLqsfiFFi5EjvhtfCDVvEkoDAqpajjfGl3JQqyQHCRyz1kW89SsKXlgqGY2qpaAJ5/ZVxVsUqmB0ivChLWMmqQeP7+QBEJchOTnSLOAtf0UVPpvo/D0LeRd7BxEft//9eE2Jtjkpk+sdxyYRzqtBCYBNYtMMOkpGwnZyFLkCB+b5Wos0LpPhJ49TXTrUPse0pcyOfw2iYVUPo95QaUL7trHGypQjgxNnszzf4QFDDf2h0VYczTZWUEGSTClRDgyXvApqXpUZHs7fYqxQ09JPSx0kKqADTolT2nld3u//o3f4IF2heXeOe0bFOdXWKrrG5Z7ubIUZzdlZuuKDF5gGqG5H8= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: b09c6c0b-8f30-4d9b-58b6-08d59db0d5fa X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2018 00:24:04.6281 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB0807 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ganesh Goudar [ Upstream commit d427caee5a3f04938f47bec6fdec97a52668ee53 ] Avoid NULL dereference in setup_sge_queues() when the adapter is in non offload mode. Fixes: 0fbc81b3ad51 ('chcr/cxgb4i/cxgbit/RDMA/cxgb4: Allocate resources dyn= amically for all cxgb4 ULD's') Signed-off-by: Ganesh Goudar Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/= ethernet/chelsio/cxgb4/cxgb4_main.c index 0c2a32a305bc..7968bdb85bb1 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c @@ -853,9 +853,12 @@ static int setup_sge_queues(struct adapter *adap) { int err, i, j; struct sge *s =3D &adap->sge; - struct sge_uld_rxq_info *rxq_info =3D s->uld_rxq_info[CXGB4_ULD_RDMA]; + struct sge_uld_rxq_info *rxq_info =3D NULL; unsigned int cmplqid =3D 0; =20 + if (is_uld(adap)) + rxq_info =3D s->uld_rxq_info[CXGB4_ULD_RDMA]; + for_each_port(adap, i) { struct net_device *dev =3D adap->port[i]; struct port_info *pi =3D netdev_priv(dev); --=20 2.15.1