Received: by 10.213.65.68 with SMTP id h4csp2119075imn; Sun, 8 Apr 2018 20:10:36 -0700 (PDT) X-Google-Smtp-Source: AIpwx499GkdrTVBPvOeiMF19JPe4W0TxcemN5njKMLmwwxyP1RaP5yLrHv5YaGvrO52dOwjuKq9s X-Received: by 10.99.176.12 with SMTP id h12mr23740306pgf.448.1523243340169; Sun, 08 Apr 2018 20:09:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523243340; cv=none; d=google.com; s=arc-20160816; b=L03KSV9SyZtFz1etfOKligQOGVrE7LQ1uEmIN5GVKxldoCW+PXDVH0OyGOEZWI6sH2 7uscyRlHeqIR3QbzTf6yfPDuyPYN3RiiocMN7tOzV5Y0dAqHd3W8i/kGhSTAoppGRDNO g7CIza3tC+O0g4PeZh5ZJuN60lDA9qiQm0vMXVBfoRRLYfO8fXwTi/Y19eZ7Q4JVop8k WjBChS785sQAV6S2gKUBApcVzScyxQbro7ELiXii1X6ZOoZbqiGYSM1wCD4i0YTtcMzi /YjmyPawzxer/KAQ9luqYFG46vq0JOyGoOh2NnvE68+NzyBiPV8hUQvcQi14RUtiax3U W8EA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=Inzuz8hy00JFm9WuPGVt5kOXNEMoQRZQ5PCzz9dT59E=; b=peKKBjOTM5E77XHK0BroBhVvClNCjainV4hNIK7J/e0QK8uHHHew3lIoBmxjfcoiEk 37x6VHkviwG7gb8HP9Lf67tR1tn741VprpyWPDnwa5qzUC1EPP5Ft1fb4rtA4hMZbN5g il5HPfdtOMYe/1UTd7qFvE5rPujj6kK2RDhl7YpvfqGRhHvgVBWpgr3Ii5DIpI6wEtr5 u/kGx8YTu7c8jeHu5lGL1ziGAZHC8pe8B9SQ+qFKRqQwa/VBwC8cIQaMfuNAqm2waptY aRLRHkoencwbZmW05sVWOQHhq/wwTt/E0rUsX2nrTb+1q/as9Pwd6K/01f+ZAaTACT6K Tbjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=d2d9Yf/1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u6-v6si1061911pls.11.2018.04.08.20.08.23; Sun, 08 Apr 2018 20:09:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=d2d9Yf/1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756295AbeDICSg (ORCPT + 99 others); Sun, 8 Apr 2018 22:18:36 -0400 Received: from mail-sn1nam02on0125.outbound.protection.outlook.com ([104.47.36.125]:10314 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755798AbeDIAaY (ORCPT ); Sun, 8 Apr 2018 20:30:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Inzuz8hy00JFm9WuPGVt5kOXNEMoQRZQ5PCzz9dT59E=; b=d2d9Yf/1OfrEGvFUTO48NmOgY89e7tCq+01iPNFPtS+Rez4n+9AT2iqICqRDSBRDXp4CN4pXkDGnbxOzHdbO+w7CrkCc9a7Hc/HzGAeMRO5QKIfWtb12M10hRVM7Tm27YHB76qj0nojlsiS4vTnPd6fC+oJ5rvj/lqM7GrNd07g= Received: from DM5PR2101MB1032.namprd21.prod.outlook.com (52.132.128.13) by DM5PR2101MB1032.namprd21.prod.outlook.com (52.132.128.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.696.0; Mon, 9 Apr 2018 00:30:18 +0000 Received: from DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8109:aef0:a777:7059]) by DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8109:aef0:a777:7059%2]) with mapi id 15.20.0696.003; Mon, 9 Apr 2018 00:30:18 +0000 From: Sasha Levin To: "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: Krzysztof Kozlowski , Stephen Boyd , Sasha Levin Subject: [PATCH AUTOSEL for 4.9 130/293] clk: samsung: audss: Fix silent hang on Exynos4412 due to disabled EPLL Thread-Topic: [PATCH AUTOSEL for 4.9 130/293] clk: samsung: audss: Fix silent hang on Exynos4412 due to disabled EPLL Thread-Index: AQHTz5ki8dOB2B54dk67OSdDDtGWPw== Date: Mon, 9 Apr 2018 00:24:34 +0000 Message-ID: <20180409002239.163177-130-alexander.levin@microsoft.com> References: <20180409002239.163177-1-alexander.levin@microsoft.com> In-Reply-To: <20180409002239.163177-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM5PR2101MB1032;7:I9CxN9k2bD2ERyS55oH0nTdCaCs4ECJUhUP6THxVd68tyiFXjaXV6dtXdab3EEASY3y/SIpsOErA/Ckh7iMmE4NIy1laDVS6up0f8XJYffKR7k+hM27TsjUAUDVeM08shAspUP/Ltm6696ib5xcaOrKHQrTsSt860p8kLSBDNDk0F2XqAjnQu9UtCWoNn7Me+ntqmIjfcbC7lhdHnCTCfzLzmDJftKU0UUc++Zefgu90IECyx+EWpLtArg12wHBh;20:uExVGvllepcpS5S1XkF/UTpezXtpC7rlewrzgdkXNKT0+50pp+WpsXQJJRBqZJ6T8JpFowojizMu5bTUldW3dAz7W02UHHZyngz6fIKwDMvo245GEMnk3M35OJAmg0+36RYV9Pp4b5+MRwv5y8/h1kHEqdyLTTOM1gGEOc0AEz8= x-ms-office365-filtering-ht: Tenant X-MS-Office365-Filtering-Correlation-Id: d9c2db6e-e544-4352-0219-08d59db11292 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7193020);SRVR:DM5PR2101MB1032; x-ms-traffictypediagnostic: DM5PR2101MB1032: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(7411616537696); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(61425038)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231221)(944501327)(52105095)(10201501046)(93006095)(93001095)(6055026)(61426038)(61427038)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011);SRVR:DM5PR2101MB1032;BCL:0;PCL:0;RULEID:;SRVR:DM5PR2101MB1032; x-forefront-prvs: 0637FCE711 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(39380400002)(346002)(396003)(39860400002)(376002)(366004)(377424004)(189003)(199004)(5660300001)(76176011)(99286004)(10090500001)(2900100001)(105586002)(305945005)(7736002)(107886003)(2501003)(5250100002)(14454004)(53936002)(4326008)(8936002)(68736007)(25786009)(86612001)(3846002)(66066001)(1076002)(486006)(316002)(72206003)(22452003)(106356001)(186003)(97736004)(6436002)(6116002)(476003)(2616005)(478600001)(6486002)(10290500003)(2906002)(110136005)(54906003)(6512007)(81156014)(81166006)(8676002)(36756003)(11346002)(3660700001)(446003)(6666003)(86362001)(26005)(102836004)(3280700002)(6506007)(59450400001)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR2101MB1032;H:DM5PR2101MB1032.namprd21.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: LKq9o3qwicc6+Vk3mSkaHLX7YEQKAKfl2ZKFG2egnYiE1HvG1BwW4sLGzVTrjkkJrT19B/W8D6HzXq7Ez5WiJ3vcjZd1UK6eNmvBm4RdtztL26MtuVbXgZdQvVA7AuvdIfz/omyA896U44HHmmFMI1YV6sQJ4I/xA8IgaMhlGT3Lw2dB/DLECujg0/miPNHP32C81BpsZ3dMQm1zsqfXVQqY9IsDMIEqGy9yoP9DXImz3fTeH/XrNtKaX+cYL/Nm1dSTKoyUXMjyxHWJspyFMLIGNxLSn5y1fWGqoAXUqnUh0pjYWW7nzXRXP6Mu7D+TrmJCaHoIki5j/PLte3zcxNTKSkj8IY7wgy2kJ2Nb01ZzWb+hrF+NAS+YBiAWMGBVgI5pkz4UxHdAWdAOoTLn3ILxNDhFLHWGJhQf9WrqflY= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: d9c2db6e-e544-4352-0219-08d59db11292 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2018 00:24:34.4250 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB1032 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Krzysztof Kozlowski [ Upstream commit 5bb4053b5993406935cc3b01cbf8b9f1e5803f4c ] Similarly to commit f1e9203e2366 ("clk: samsung: Fix Exynos 5420 pinctrl setup and clock disable failure due to domain being gated") for Exynos5420, the Exynos4412 also requires that EPLL is not disabled. Otherwise any access to MAUDIO block will silently halt. This was not visible before because EPLL on Exynos4 could not be disabled before commit 6edfa11cb396 ("clk: samsung: Add enable/disable operation for PLL36XX clocks"). After this commit, on Odroid U3 board one can see silent hang, usually with last (but unrelated) messages: [ 2.382741] input: gpio_keys as /devices/platform/gpio_keys/input/input= 0 [ 2.405686] usb 1-3: new high-speed USB device number 3 using exynos-eh= ci [ 2.419843] max77686-rtc max77686-rtc: setting system clock to 2017-06-= 21 17:04:13 UTC (1498064653) Mark Exynos4 variant as also needed EPLL to be enabled all the time. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Sylwester Nawrocki Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/samsung/clk-exynos-audss.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/samsung/clk-exynos-audss.c b/drivers/clk/samsung/c= lk-exynos-audss.c index 17e68a724945..f047733f1a61 100644 --- a/drivers/clk/samsung/clk-exynos-audss.c +++ b/drivers/clk/samsung/clk-exynos-audss.c @@ -77,6 +77,7 @@ struct exynos_audss_clk_drvdata { =20 static const struct exynos_audss_clk_drvdata exynos4210_drvdata =3D { .num_clks =3D EXYNOS_AUDSS_MAX_CLKS - 1, + .enable_epll =3D 1, }; =20 static const struct exynos_audss_clk_drvdata exynos5410_drvdata =3D { --=20 2.15.1