Received: by 10.213.65.68 with SMTP id h4csp2155373imn; Sun, 8 Apr 2018 21:08:22 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+6ODWoWAjxqTWTbZK8rrci7wWh6osiEUqokxgm72HLWur8aGR0Mpm8/plp9+zTXQ8OQpvl X-Received: by 2002:a17:902:a981:: with SMTP id bh1-v6mr37898490plb.255.1523246902670; Sun, 08 Apr 2018 21:08:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523246902; cv=none; d=google.com; s=arc-20160816; b=p2YLUd6H2qBl9g8Wds9wzwNErwbQBKuxaHU08uNLU79bV5CTLZ5H+bht+IUQH9RB69 8JB9kv3vHk8z8TsPMA5hUfdi/VmsLy4UqedJO/H1/Q9ibVCswyNJELpTES594N5McUOr wqwxqnwTZ46DWniaWv9f2kl1FZHWFRjRf3VUZpUAL2AmyG1RCBqwp5w79+v3mcWcVeD6 7sA3aXktD86N1RLcfK05m4/63EkRfIH8U29CmyeVBVgVEleJWJo3215aO9JMNxr0tqqv IKBxYi7Qniay2SaUQd667fmKLnpoar8DWOQEIDxn0OQh6kPRS3Rp8Now7qlYvoVcw/4t YKRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=U9sNy0UgIaUznZwX1HSbJrhTx1gmOCQ2lyxnCSA3PzM=; b=t2xHWcG4DYKP+j3i43IKFP5cqGUZcIwBH21NLsXomnIBVjaGJjvP3O1Zqj15F29ixw PFcsPXn0tg164i8NwpjdhluP950RGgkKrKMeLq3s+tmO//NfVZukrSR7q9ByX3CMEp49 qWQzEc0d8ygHccoYZVk0oGffzIEiZgx3wQbg8DmrWSLqePznNCbi5jy4oEOGvbmc94f8 uZ65pVBLR5L9/xCgqZfQTNsiaHgt48ah+DByBTof7M7HS4HGN9Dx0+eqdFvdrcwCKUjv ACyhjFKhUqlOczLptW8db9LG3auyeZwjFk6mM7KHjeCd8fKfc+OJiMktAkI4wZ7uU8ZR es4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=HI48RNya; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h3si10562978pgf.314.2018.04.08.21.07.45; Sun, 08 Apr 2018 21:08:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=HI48RNya; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753943AbeDIECa (ORCPT + 99 others); Mon, 9 Apr 2018 00:02:30 -0400 Received: from mail-co1nam03on0107.outbound.protection.outlook.com ([104.47.40.107]:43410 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753362AbeDIASB (ORCPT ); Sun, 8 Apr 2018 20:18:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=U9sNy0UgIaUznZwX1HSbJrhTx1gmOCQ2lyxnCSA3PzM=; b=HI48RNya4G1QBEJPkDx3U7o3FhRnaI3xckXEZZBeRgp5ffY4p/rNkQdrEsqlNvjF2OQOVx+b0xdr1iebzKM+M5Ml98ZXfZbd5mBYeZIupieBokhg2FqL38hwJEldrwFQoh0ORZzxP5gtkLhJPo/lM7z0N7vfJQ/7uABS3pzVClA= Received: from DM5PR2101MB1032.namprd21.prod.outlook.com (52.132.128.13) by DM5PR2101MB1046.namprd21.prod.outlook.com (52.132.128.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.696.0; Mon, 9 Apr 2018 00:17:57 +0000 Received: from DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8109:aef0:a777:7059]) by DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8109:aef0:a777:7059%2]) with mapi id 15.20.0696.003; Mon, 9 Apr 2018 00:17:57 +0000 From: Sasha Levin To: "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: Wei Yongjun , Corey Minyard , Sasha Levin Subject: [PATCH AUTOSEL for 4.15 060/189] ipmi/powernv: Fix error return code in ipmi_powernv_probe() Thread-Topic: [PATCH AUTOSEL for 4.15 060/189] ipmi/powernv: Fix error return code in ipmi_powernv_probe() Thread-Index: AQHTz5gn+ZPv2eGjPE+n1YFtK7gkuA== Date: Mon, 9 Apr 2018 00:17:32 +0000 Message-ID: <20180409001637.162453-60-alexander.levin@microsoft.com> References: <20180409001637.162453-1-alexander.levin@microsoft.com> In-Reply-To: <20180409001637.162453-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM5PR2101MB1046;7:bY1+QUreHreiPq7m7dcGDpK9SCoKl8MrwzAD9Lp31lCAuIm282UhkyCBDY0lTVksZpTYYBRVgm1QGOzlxG2epTCbRixnM+hccaVdy47+PtpimQ2mZPRjqEwIqEyvTd/EwGfd+HAK99IZTHu+zUvq7RbTbnwXR7O+n3oyl9PRU2Wbf4cq3Vp/NWLBzb+woB9nyTDLTxX7J+MWNupl8Pwim48+GKKLjzZAY5/XXp7z6DBFRujsdadJnO5IiQP72iaK;20:yqrk/FiR64sUlFmijX9eGdV6hC1c9BqxGzIht3EFs4MZXSrt6wqEkQxTj076fZOYe88trmCsj3N4OiIiln1EbAropZPzh0B6g501ZFlnj7tlCUyr/8u0bIDadY5ORdqwM/AWkUfhJRrTgluAfS+igs4HUNj7IsyZRvzqBSIgSQQ= X-MS-Office365-Filtering-Correlation-Id: f6656083-fc0c-4026-dd6f-08d59daf5878 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(48565401081)(2017052603328)(7193020);SRVR:DM5PR2101MB1046; x-ms-traffictypediagnostic: DM5PR2101MB1046: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(50582790962513); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(61425038)(6040522)(2401047)(8121501046)(5005006)(3231221)(944501327)(52105095)(10201501046)(3002001)(93006095)(93001095)(6055026)(61426038)(61427038)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(20161123562045)(20161123564045)(6072148)(201708071742011);SRVR:DM5PR2101MB1046;BCL:0;PCL:0;RULEID:;SRVR:DM5PR2101MB1046; x-forefront-prvs: 0637FCE711 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(39380400002)(346002)(376002)(396003)(366004)(39860400002)(199004)(189003)(36756003)(575784001)(186003)(11346002)(446003)(476003)(2616005)(7736002)(5660300001)(26005)(10290500003)(478600001)(106356001)(6666003)(68736007)(10090500001)(54906003)(3846002)(59450400001)(22452003)(6116002)(86612001)(110136005)(99286004)(86362001)(72206003)(305945005)(76176011)(102836004)(6506007)(486006)(316002)(3280700002)(3660700001)(81166006)(81156014)(8676002)(2906002)(14454004)(2900100001)(97736004)(6486002)(4477795004)(8936002)(1076002)(6512007)(6436002)(105586002)(25786009)(4326008)(2501003)(5250100002)(53936002)(66066001)(107886003)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR2101MB1046;H:DM5PR2101MB1032.namprd21.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: hP55owXquCRqpqXzcZwqUBysvQtbMu+sOWVw+qombU4ZbY+ylS8P2umF81GMdP/AIqrQiTonZAxa5UD5slPHQ6FTFiDXu2RHGC2IufKNlKpU5pjffDDOFEMGVK+vgGAY+nUB32NjW44jNEkFecsIbOxD1LHsFcZO/acVi0QwLbCAs/hzuK6gABSO4/gcp4UsXXzjK9CqZs5BfXsRZOUvtGLS/dLE+9CyhZ5occ/pD82aVrmH4OTNz3AsOiB0liWDOI96stCRTLT7DuzlzKQOgr/74FZL0P3KgPOewLEyh1kcJCCXNHFfaoSv3SaIiqlEgoD7HHYB9kpvLlZsd7iV6DWpMomvEzol/6Pe6F1JlOM8aehugiHjFwvbMLPD2olw7sn2GB25s9tfD5Fh9xQghON7999CA2RUHht01P3MHeo= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6656083-fc0c-4026-dd6f-08d59daf5878 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2018 00:17:32.8998 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB1046 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wei Yongjun [ Upstream commit e749d328b0b450aa78d562fa26a0cd8872325dd9 ] Fix to return a negative error code from the request_irq() error handling case instead of 0, as done elsewhere in this function. Fixes: dce143c3381c ("ipmi/powernv: Convert to irq event interface") Signed-off-by: Wei Yongjun Reviewed-by: Alexey Kardashevskiy Signed-off-by: Corey Minyard Signed-off-by: Sasha Levin --- drivers/char/ipmi/ipmi_powernv.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/char/ipmi/ipmi_powernv.c b/drivers/char/ipmi/ipmi_powe= rnv.c index 07fddbefefe4..193baf31f778 100644 --- a/drivers/char/ipmi/ipmi_powernv.c +++ b/drivers/char/ipmi/ipmi_powernv.c @@ -250,8 +250,9 @@ static int ipmi_powernv_probe(struct platform_device *p= dev) ipmi->irq =3D opal_event_request(prop); } =20 - if (request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH, - "opal-ipmi", ipmi)) { + rc =3D request_irq(ipmi->irq, ipmi_opal_event, IRQ_TYPE_LEVEL_HIGH, + "opal-ipmi", ipmi); + if (rc) { dev_warn(dev, "Unable to request irq\n"); goto err_dispose; } --=20 2.15.1