Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S271037AbTHQU7J (ORCPT ); Sun, 17 Aug 2003 16:59:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S271041AbTHQU7J (ORCPT ); Sun, 17 Aug 2003 16:59:09 -0400 Received: from fw.osdl.org ([65.172.181.6]:32902 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S271037AbTHQU7E (ORCPT ); Sun, 17 Aug 2003 16:59:04 -0400 Date: Sun, 17 Aug 2003 13:59:35 -0700 From: Andrew Morton To: Peter Osterlund Cc: lists@runa.sytes.net, linux-kernel@vger.kernel.org, axboe@suse.de Subject: Re: segfault when unloading module loop in 2.6.0-test3+ck patches Message-Id: <20030817135935.2790cec6.akpm@osdl.org> In-Reply-To: References: <20030817042751.379428cf.lists@runa.sytes.net> X-Mailer: Sylpheed version 0.9.4 (GTK+ 1.2.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1084 Lines: 27 Peter Osterlund wrote: > > (I'm resending this because I previously had sendmail configuration > problems. Sorry if you receive this message twice.) I saw it (and the other) the first time, thanks. > diff -puN drivers/block/loop.c~loop-oops-fix drivers/block/loop.c > --- linux/drivers/block/loop.c~loop-oops-fix 2003-08-17 19:19:22.000000000 +0200 > +++ linux-petero/drivers/block/loop.c 2003-08-17 20:33:03.000000000 +0200 > @@ -1198,6 +1198,7 @@ int __init loop_init(void) > lo->lo_queue = blk_alloc_queue(GFP_KERNEL); > if (!lo->lo_queue) > goto out_mem4; > + init_timer(&lo->lo_queue->unplug_timer); > disks[i]->queue = lo->lo_queue; > init_MUTEX(&lo->lo_ctl_mutex); > init_MUTEX_LOCKED(&lo->lo_sem); This bit should be done in ll_rw_blk.c somewhere. Are you sure it is necessary for loop? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/