Received: by 10.213.65.68 with SMTP id h4csp2329134imn; Mon, 9 Apr 2018 01:24:03 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/b3iDWqDqjzx/Mb6t8GuqDbDQ85RvuhHZZivkrbvWEumzjZ5LQOQo6KRy9EDmqzUN7mDWj X-Received: by 2002:a17:902:6a88:: with SMTP id n8-v6mr38018283plk.131.1523262243592; Mon, 09 Apr 2018 01:24:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523262243; cv=none; d=google.com; s=arc-20160816; b=J5ZD+xXgghwO1kX+SCmVV0ldpZACVqo8xSsjkNx516mzIrg1HbYZLn11c8njA4Pyxq XL6fLDsrb6/N7QEtt3kbIYn0DbSWC28sAEhnW/T/pCMntaW1Bd5X/gcW+lBp51shkZak 7d0dtqA6Hxc83+jcynDp1eYMkjQA1r+3ZQ4f5PmkOJcGRSPoPFC9Uv7BGjd6YdC0jCQ1 qxAmhpgF0rNWJ1NFNcebEiuIe578uLsD1yYWRkIYs4GNo+jp+pjlkIZriifmpCyg91o2 XAQ1JR5kIh/hZa6LB1XN8zf0Opdp8Sky7Lx6bH99HJunPK02jW6AUf6B2A6cR/PU4WJ7 szOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=GcDqWyPq01sRhibvL10BN5Vj41oLPxEc3Wl0OfAOMDk=; b=xQCqyiFpUMNXmBM4yhSvLWaYE4ZZa9q0cEl+D/MlqObgLviMUUzFlGRCL4QTOGnaS4 e6oaHmuBkisqLtAxY//Vtmvue2+ixO397KBg7QFv1gR3ydO5qdY4q8R/o2jywhv7/eAa iNG/go60zhNZ0RIEK/IQZZgRkmk5yBSaw8mlb9rw6c8HXZgm6jeZ6nHabCnlsO72N6mY FCJm25SfdKC95VEka7zlS1uTUvAIqvYryLcE+uBGE6tgpxHlnORZeEF8N4vDsrzodA/L 7Xyz94XyEZlYub4j/LIL+McfODtCvP0uKMVMz3R4AOD1JdsWUJYBeqOXswBt0hUAnrMU eqJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TRUCEMGJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p1-v6si13811355plo.421.2018.04.09.01.23.25; Mon, 09 Apr 2018 01:24:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TRUCEMGJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751919AbeDIIRI (ORCPT + 99 others); Mon, 9 Apr 2018 04:17:08 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:53804 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750952AbeDIIRG (ORCPT ); Mon, 9 Apr 2018 04:17:06 -0400 Received: by mail-wm0-f68.google.com with SMTP id 66so10660456wmd.3 for ; Mon, 09 Apr 2018 01:17:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=GcDqWyPq01sRhibvL10BN5Vj41oLPxEc3Wl0OfAOMDk=; b=TRUCEMGJx6t8Af0oQWGca9HbQy8IHNayHC3o4hire7PF77bBHOfVsQNw2L6Lcshqto QbGGp/JPnBs2TMOZTolg8Wio9qb/5P4L2yGrPcMl+Otb6xB/U/pXi5I3gwBgfC8duEIm qS8VbADCJdX2DgEdUUCnObQHOUvPlSTnQvR1I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=GcDqWyPq01sRhibvL10BN5Vj41oLPxEc3Wl0OfAOMDk=; b=LoY9kiQYucz9UiYZKOZuE/dKU8mOhYVP1PFoR5BBUUInoIVq1COwlsehuZR13gg1oY Q6xOIxXj1yqKR03Kjg8BCMcf3axXJ+BH3g98HFP4IyPVzRFDFiMDeFcSqLUPYhb3OpSB QijpUhQXcFR0dAh561AY3zz5zVFe9YtoUnRN37ThOv+hOoE9J+ERaipDonLp5E1Dbsh7 W9HUJJtW+rR+1BUbvSg/xhsVnGM+hXZL2c9GZTM0gjd4HkiQzj7Xf8Pn2nMFPFtedTz+ d/ws+SyyM3saU0+NnYWbhLmMC0c59i8KKAqOAsmjkBn1XnSdqOWY+RqvRvnrcds/Gtb6 t0oQ== X-Gm-Message-State: ALQs6tCdwoT45r3epWIWGjpcMevO0C5CtB7gXcnZlYnPR3MQTipdY2RJ /Vuz09oK2Fg/0ZQdbUBMN5i/8Q== X-Received: by 10.28.190.3 with SMTP id o3mr13331560wmf.57.1523261825661; Mon, 09 Apr 2018 01:17:05 -0700 (PDT) Received: from dell ([2.27.167.72]) by smtp.gmail.com with ESMTPSA id q20sm118125wmf.39.2018.04.09.01.17.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 09 Apr 2018 01:17:04 -0700 (PDT) Date: Mon, 9 Apr 2018 09:17:02 +0100 From: Lee Jones To: Enric Balletbo i Serra Cc: Daniel Thompson , Doug Anderson , Pavel Machek , Rob Herring , Jingoo Han , Richard Purdie , Jacek Anaszewski , Brian Norris , Guenter Roeck , Alexandru Stan , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH v3 0/4] backlight: pwm_bl: support linear interpolation and brightness to human eye Message-ID: <20180409081702.rwj773h6ndglnejm@dell> References: <20180208113032.27810-1-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180208113032.27810-1-enric.balletbo@collabora.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 08 Feb 2018, Enric Balletbo i Serra wrote: > Dear all, > > This series is a third patchset integrating the requested changes. > > The first and second patch what tries to solve is the problem of > granularity for high resolution PWMs. The idea is simple interpolate > between 2 brightness values so we can have a high PWM duty cycle (a > 16 bits PWM is up to 65535 possible steps) without having to list > out every possible value in the dts. I think that this patch is > required to not break backward compability, to be more flexible and > also extend the functionality to be able to use high resolution PWM > with enough steps to have a good UI experience in userspace. > > The thirth and fourth patch is a bit more ambicious, the idea is let > decide the driver the brightness-levels required in function of the PWM > resolution. To do this create a brightness-levels table filled with the > CIE 1931 algorithm values to convert brightness to PWM duty cycle. > > More detailed info is available in the commit message of every patch. > > Both functionalities were tested on a Samsung Chromebook Plus (that has > a 16 bits PWM) and a SL50 device (with a 8 bits PWM) > > Waiting for your feedback. Looks like you now have some positive feedback. :) Could you please collect all of your received Acks and re-post this set as a [RESEND] please? > Best regards, > > Enric Balletbo i Serra (4): > backlight: pwm_bl: linear interpolation between brightness-levels > dt-bindings: pwm-backlight: add a num-interpolation-steps property. > backlight: pwm_bl: compute brightness of LED linearly to human eye. > dt-bindings: pwm-backlight: move brightness-levels to optional. > > .../bindings/leds/backlight/pwm-backlight.txt | 34 ++- > drivers/video/backlight/pwm_bl.c | 232 +++++++++++++++++++-- > 2 files changed, 246 insertions(+), 20 deletions(-) -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog