Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S271125AbTHQWad (ORCPT ); Sun, 17 Aug 2003 18:30:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S271129AbTHQWac (ORCPT ); Sun, 17 Aug 2003 18:30:32 -0400 Received: from ebiederm.dsl.xmission.com ([166.70.28.69]:56635 "EHLO frodo.biederman.org") by vger.kernel.org with ESMTP id S271125AbTHQWab (ORCPT ); Sun, 17 Aug 2003 18:30:31 -0400 To: ebiederm@xmission.com (Eric W. Biederman) Cc: Russell King , Christoph Hellwig , Patrick Mochel , Greg KH , linux-kernel@vger.kernel.org Subject: [PATCH] don't call device_shutdown on halt. References: <20030814085442.A21232@infradead.org> <20030814090605.A25516@flint.arm.linux.org.uk> <20030814170721.B332@flint.arm.linux.org.uk> From: ebiederm@xmission.com (Eric W. Biederman) Date: 17 Aug 2003 16:26:36 -0600 In-Reply-To: Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.1 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1177 Lines: 25 For a halt quiescing devices is overkill, historically wrong, and error prone when the system is halted. The only drivers that should care are drivers for devices that do the wrong thing when power is removed. diff -uNr linux-2.6.0-test3/kernel/sys.c linux-2.6.0-test3-no_device_shutdown/kernel/sys.c --- linux-2.6.0-test3/kernel/sys.c Tue Jul 29 14:48:17 2003 +++ linux-2.6.0-test3-no_device_shutdown/kernel/sys.c Sun Aug 17 22:04:18 2003 @@ -423,7 +423,6 @@ case LINUX_REBOOT_CMD_HALT: notifier_call_chain(&reboot_notifier_list, SYS_HALT, NULL); system_running = 0; - device_shutdown(); printk(KERN_EMERG "System halted.\n"); machine_halt(); unlock_kernel(); @@ -433,7 +432,6 @@ case LINUX_REBOOT_CMD_POWER_OFF: notifier_call_chain(&reboot_notifier_list, SYS_POWER_OFF, NULL); system_running = 0; - device_shutdown(); printk(KERN_EMERG "Power down.\n"); machine_power_off(); unlock_kernel(); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/