Received: by 10.213.65.68 with SMTP id h4csp2346944imn; Mon, 9 Apr 2018 01:49:21 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/XhYuG5kFNwtbNiu0/fWksbqDnH1qZV+igbpUmp3wgpBEUCFkDHF2iATPLq9rN1jzCMEkd X-Received: by 2002:a17:902:bf03:: with SMTP id bi3-v6mr3341642plb.368.1523263761653; Mon, 09 Apr 2018 01:49:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523263761; cv=none; d=google.com; s=arc-20160816; b=SE7upZtzp8Oxrhl46Nop+s73G8K7KoEByRFFNTR5R+ws6tQXkYqeUOl7eX2WkeSIp1 7PJPIc4BkpHS47oIqAZt1yjVPBlLTgRxi+WbRRCsGTcq0uI8s5/BCFWZ4mjol9YY/dYh RvsH5toA+Yr6hYniI2llKcS8bkWBFw9bKjKDfk/nKJmrmfRhjx8ppiKcsnyD/US5Ii4N ThzRUYyDvpZ0+N15L/oGGi/9ooTb9tfDG0pf5LmVQioxJASPRZhIVpif6eUWa+X4WBGI 9tn5FeO7kDEwMv2wfmtHbKJ929S7m0oy+dFeBZiqjwHEH8Ufat4iCmL/42OH093UqLAY GArQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:dkim-signature:arc-authentication-results; bh=DSdPkSkUv4p/AAXcaJsz3KH5C66m1XbheKeHqttrDcM=; b=Jzdtqk4bqChE0Sl9Wakxz8V84lqXMAqD8sQsdVG4C/hwuJIGsGCRzBY7YpX1HUULbU 8IN1tlaFQWYQaPY36M98zJ3TbumYn9QpjEufhPZntRND7dUOCSKFkA9CcYfk2VBkWu6U ip3ThtowyIRsBSPS14OcboSf2byr11gnSz55j+eHzrZ9c7ceU68TNcqjYcAPvKKJDq2R gQHpQ8zwwFM2xKjzmoj2Z9ed+WgX8MfGdIC5magGIXoX7cQaIpp4KkJkg84CtdeePbr8 9suFMzrawpnNrV6PA4Y7uDHoVhsywGmQXuHVOv9XeeVXp8PnkK0R5udJS9d0hIyXH/tw AYdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=mNgMbcbF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r8-v6si16440596pli.12.2018.04.09.01.48.44; Mon, 09 Apr 2018 01:49:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=mNgMbcbF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751737AbeDIIpg (ORCPT + 99 others); Mon, 9 Apr 2018 04:45:36 -0400 Received: from lelnx194.ext.ti.com ([198.47.27.80]:56403 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750952AbeDIIpe (ORCPT ); Mon, 9 Apr 2018 04:45:34 -0400 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by lelnx194.ext.ti.com (8.15.1/8.15.1) with ESMTP id w398jLMX000690; Mon, 9 Apr 2018 03:45:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1523263521; bh=qhLsvxUvv1keYTxj+H0Z6BJwh8uEqovq2SKg9a6usAI=; h=From:To:CC:Subject:Date; b=mNgMbcbFajMWT5GyVqSkY04sQHCiqe7/+Ft6EIDumlVQmBFHguThvyeOe+mv65a/Z uOZri5McQzVmDl7vLtOsWEcFZs/RbpwbSR9sCkVx8ddo8wNkGbTeOcO4Agn4H89742 qYs3nYw7emkegXa5+GU120n8kgh1RsB+ziFDcjIg= Received: from DLEE106.ent.ti.com (dlee106.ent.ti.com [157.170.170.36]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id w398jLQq019209; Mon, 9 Apr 2018 03:45:21 -0500 Received: from DLEE115.ent.ti.com (157.170.170.26) by DLEE106.ent.ti.com (157.170.170.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1261.35; Mon, 9 Apr 2018 03:45:21 -0500 Received: from dflp32.itg.ti.com (10.64.6.15) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1261.35 via Frontend Transport; Mon, 9 Apr 2018 03:45:21 -0500 Received: from feketebors.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id w398jIUs011441; Mon, 9 Apr 2018 03:45:19 -0500 From: Peter Ujfalusi To: , CC: , , , Subject: [PATCH v2] mfd: twl-core: Fix clock initialization Date: Mon, 9 Apr 2018 11:45:39 +0300 Message-ID: <20180409084539.14365-1-peter.ujfalusi@ti.com> X-Mailer: git-send-email 2.17.0 MIME-Version: 1.0 Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When looking up the clock we must use the client->dev as device since that is the one which is probed via DT. Signed-off-by: Peter Ujfalusi Cc: stable@vger.kernel.org # 4.16+ --- Hi, Changes since v1: - Removed the Fixes line and add tag only for v4.16 to avoid possible breakage in pre v4.16. Regards, Peter drivers/mfd/twl-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c index d3133a371e27..c649344fd7f2 100644 --- a/drivers/mfd/twl-core.c +++ b/drivers/mfd/twl-core.c @@ -1177,7 +1177,7 @@ twl_probe(struct i2c_client *client, const struct i2c_device_id *id) twl_priv->ready = true; /* setup clock framework */ - clocks_init(&pdev->dev, pdata ? pdata->clock : NULL); + clocks_init(&client->dev, pdata ? pdata->clock : NULL); /* read TWL IDCODE Register */ if (twl_class_is_4030()) { -- Peter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki