Received: by 10.213.65.68 with SMTP id h4csp2379900imn; Mon, 9 Apr 2018 02:31:41 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+VXplKwoIHGJuh504qH1vs83ADi6XG7/bIRNRriVvzTZ2mt/+ctFXvGFDd1gC6ldGlZCJF X-Received: by 2002:a17:902:76c7:: with SMTP id j7-v6mr2807168plt.108.1523266301343; Mon, 09 Apr 2018 02:31:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523266301; cv=none; d=google.com; s=arc-20160816; b=Gg9MR2WjPamGb1COar2e+9mZMa3U6fUYKPbLeWAPjocXx+oyz4wJGm7E8YLVo/LOkJ jmD6ajN2i6xCm3Nrg7N93v0cYlaX6spx3qIKGZo69u4fvqBPk21sdjpcVNIyCqEdlltj +LWDr6NiHrTmfXWUE8lzBqw5JLrThIOe4s3fxZZflk5IEiDymCm8hIyS5WTk7KrW1RPB KFhg7dSaZuCsz76HrHnyHBY1tMz/U5uwtXEM+57EpF18LwOEuru+9VuZB09rWLq3PXk4 rVut7/1LANIArhXRtZ2Mnx3fdxaN2yNKdofVkaMXg04L5+1D0VmG3ib+alWNUJ714h7z XJhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=Z/K6sy+GyEZYPo3XS5tUx6i9SXDx75DI/Cu7VecSe+U=; b=Ja3tj1KpTzKL9UZH6HOSO+OIhKvfV/zTDjpIL5T5zOw6qrZvWDlE9BWpHH4GLHQHN9 rD94em1HE6stBBL0N1Zko73TDsk6YCcrfpKQQTxJMDMhzHGwJF9jV84OZhFloV5NX98y SwWt6oLy9FbsuYtr9b2ZGBDS6MGlROufH4Ynw2Rh8oClTYFSjSCl9ULXiQ3flauMEwFk mIPKCsE/ivWcIP2SzT1l43pDjc0tD/ug+gQJHJM5rRrBggBva17WdVlow2sCh9il1HfL yFImUDs3J+RPDpCzsdN2XJCagZYcvPr7uDI94MbMwM+RqkMEoT0CHW7K1NGM1ag+I0sK b5MQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m10-v6si13446024plt.31.2018.04.09.02.31.04; Mon, 09 Apr 2018 02:31:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752093AbeDIJ1n (ORCPT + 99 others); Mon, 9 Apr 2018 05:27:43 -0400 Received: from mail.bootlin.com ([62.4.15.54]:41285 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750863AbeDIJ1m (ORCPT ); Mon, 9 Apr 2018 05:27:42 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 73B742083D; Mon, 9 Apr 2018 11:27:40 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr [90.63.216.87]) by mail.bootlin.com (Postfix) with ESMTPSA id 470D820650; Mon, 9 Apr 2018 11:27:30 +0200 (CEST) Date: Mon, 9 Apr 2018 11:27:30 +0200 From: Maxime Ripard To: Sergey Suloev Cc: Mark Brown , Chen-Yu Tsai , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org Subject: Re: [PATCH v3 3/6] spi: sun6i: restrict transfer length in PIO-mode Message-ID: <20180409092730.2moyhl5aaktjwbyn@flea> References: <20180403154449.2443-1-ssuloev@orpaltech.com> <20180403154449.2443-4-ssuloev@orpaltech.com> <20180404065048.n76r3ytuznd6fqsl@flea> <20180405091913.ky4dnmszoobn2xry@flea> <20180405131735.GB12349@sirena.org.uk> <8159c3a5-af74-9f13-aedb-7ecc708bdff6@orpaltech.com> <20180406073441.xesojvzc3deljhoy@flea> <204e97cb-2f39-00f0-fd4e-3aa9a51f7cac@orpaltech.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3txxy5hs7e432z62" Content-Disposition: inline In-Reply-To: <204e97cb-2f39-00f0-fd4e-3aa9a51f7cac@orpaltech.com> User-Agent: NeoMutt/20180323 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --3txxy5hs7e432z62 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 06, 2018 at 06:48:23PM +0300, Sergey Suloev wrote: > On 04/06/2018 10:34 AM, Maxime Ripard wrote: > > On Thu, Apr 05, 2018 at 04:44:16PM +0300, Sergey Suloev wrote: > > > On 04/05/2018 04:17 PM, Mark Brown wrote: > > > > On Thu, Apr 05, 2018 at 12:59:35PM +0300, Sergey Suloev wrote: > > > > > On 04/05/2018 12:19 PM, Maxime Ripard wrote: > > > > > > The point of that patch was precisely to allow to send more dat= a than > > > > > > the FIFO. You're breaking that behaviour without any justificat= ion, > > > > > > and this is not ok. > > > > > I am sorry, but you can't. That's a hardware limitation. > > > > Are you positive about that? Normally you can add things to hardwa= re > > > > FIFOs while they're being drained so so long as you can keep data > > > > flowing in at least as fast as it's being consumed. > > > Well, normally yes, but this is not the case with the hardware that I= own. > > > My a20 (BPiM1+) and a31 (BPiM2) boards behaves differently. With a tr= ansfer > > > larger than FIFO then TC interrupt never happens. > > Because you're not supposed to have a transfer larger than the FIFO, > > but to have to setup at first a transfer the size of the FIFO, and > > then when it's (or starts to be) depleted, fill it up again. >=20 > According to what you said the driver must implement > "transfer_one_message" instead of "transfer_one" I'm not sure what makes you think that I said that. Maxime --=20 Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com --3txxy5hs7e432z62 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlrLMgEACgkQ0rTAlCFN r3TtWQ/+MS3bXXuREbEWxlzRndXqFInds1H64yh0YGCQYch+oDERUjei967P+k7h /1Yhj5JgqF/zjGaf7dUg0Ho3trUuKUfbobjyOYIzKVjmDB3YJdFXqrUoJw5mGKYE RswK5GhVQY7EoJOZJ6hwT5Kop+6A0BuxbQ9A2oSOwfXFaXnap83mdohjYRgW8ZgH MpdLUNo1JX+Qxo7KnzGpKJko/u4ewKTm7NnxxkC98BUSRvkBgDn0imAMZK3wBHFz LqY6GB/iDI65H3iN+2ADcY0A5a3DjoMfqT/Ia9tgExjFbzf6QNgWcD8mmcmE+M5w soN3FAnyM04CnWDCJpkTLQ76EVKq0gCuuUj5gpCPn8tTOzK8JJ/VOssMG/Almcv9 tdXpy0lPUAmWSyPUQebKAAOJv5sDGz4DfFf+W10+oCmpJMTMoxNBKwJ7jvZufOUp dK1axDC4HxzuAF+OFNWe4Af13jmKO5qm/rqvn7xmob0JLlhRBqQ9ouov96+7oyJA RdzWRnBEI0w5Y4rmXQo3X3f9dijW93/+s2EiB4WcUS7vZWdVJr1B6YNv/z/tS0TF sz+zgUWXr7uvSZO/NtL+xIDaWvVBgG4vCArgCHvzHPDDcygTciAa7Fxq2fPcG7Tc ExJ1DfXsni1JND0DpMP9o26RWhbqmBPiOD9084vdkSEa/lqRLXQ= =2Fb8 -----END PGP SIGNATURE----- --3txxy5hs7e432z62--