Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <e5d59c005cdf0183b866fd24a012ccc35118f121.camel@perches.com>
Subject: Re: [PATCH] checkpatch: relax check for revert commit
From:   Joe Perches <joe@perches.com>
To:     Jia He <hejianet@gmail.com>, Andy Whitcroft <apw@canonical.com>
Cc:     linux-kernel@vger.kernel.org, Jia He <jia.he@hxt-semitech.com>
Date:   Mon, 09 Apr 2018 03:50:36 -0700
In-Reply-To: <979a4ce5-2c68-6186-476c-1214aed2cdbc@gmail.com>
References: <1522679339-19067-1-git-send-email-hejianet@gmail.com>
         <1522679339-19067-2-git-send-email-hejianet@gmail.com>
         <d5f5fbc7-d01f-05e1-f8ac-c1db8ba5fd9e@gmail.com>
         <7d9467ac5aee4b81b5c58c167ac553c75dd26f4c.camel@perches.com>
         <979a4ce5-2c68-6186-476c-1214aed2cdbc@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 2018-04-09 at 14:37 +0800, Jia He wrote:
> 
> On 4/9/2018 1:07 AM, Joe Perches Wrote:
> > On Sun, 2018-04-08 at 10:12 +0800, Jia He wrote:
> > > Hi Andy & Joe
> > > 
> > > Although it is minor, it is a real bug, I thought.
> > > 
> > > Is there any comment? Thank you
> > 
> > If you really want to do something useful here,
> > quote the quote characters and compare for that.
> > 
> > 
> 
> Hi Joe, thanks for the comments
> I am not sure I understand you comments here.

Change the tests to allow quote characters instead
of ignoring them.

To do this matching, any internal  quote character in
the actual commit string and the commit string from the
patch must be perl quoted with \Q<string>\E so that the
expected title can be matched properly.