Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S271148AbTHRAqc (ORCPT ); Sun, 17 Aug 2003 20:46:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S271153AbTHRAqc (ORCPT ); Sun, 17 Aug 2003 20:46:32 -0400 Received: from mail.jlokier.co.uk ([81.29.64.88]:39040 "EHLO mail.jlokier.co.uk") by vger.kernel.org with ESMTP id S271148AbTHRAqa (ORCPT ); Sun, 17 Aug 2003 20:46:30 -0400 Date: Mon, 18 Aug 2003 01:46:18 +0100 From: Jamie Lokier To: Linus Torvalds Cc: Rusty Russell , linux-kernel@vger.kernel.org Subject: [PATCH] use simple_strtoul for unsigned kernel parameters Message-ID: <20030818004618.GA5094@mail.jlokier.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1145 Lines: 25 The largest "unsigned int" value doesn't fit in a "long", on many machines. So we should use simple_strtoul, not simple_strtol, to decode these values. Enjoy, -- Jamie --- orig-2.5.75/kernel/params.c 2003-07-08 21:44:26.000000000 +0100 +++ laptop-2.5.75/kernel/params.c 2003-08-17 03:17:40.116594605 +0100 @@ -165,9 +165,9 @@ } STANDARD_PARAM_DEF(short, short, "%hi", long, simple_strtol); -STANDARD_PARAM_DEF(ushort, unsigned short, "%hu", long, simple_strtol); +STANDARD_PARAM_DEF(ushort, unsigned short, "%hu", unsigned long, simple_strtoul); STANDARD_PARAM_DEF(int, int, "%i", long, simple_strtol); -STANDARD_PARAM_DEF(uint, unsigned int, "%u", long, simple_strtol); +STANDARD_PARAM_DEF(uint, unsigned int, "%u", unsigned long, simple_strtoul); STANDARD_PARAM_DEF(long, long, "%li", long, simple_strtol); STANDARD_PARAM_DEF(ulong, unsigned long, "%lu", unsigned long, simple_strtoul); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/