Received: by 10.213.65.68 with SMTP id h4csp2606353imn; Mon, 9 Apr 2018 06:18:56 -0700 (PDT) X-Google-Smtp-Source: AIpwx49Y1QDg28RR5hxM7xdR41KJFeqXZ8L4LNvxk7LTGeUlTHMc4OfFZmTy/pTouzUWC5CJ7/Ga X-Received: by 2002:a17:902:d20b:: with SMTP id t11-v6mr9289412ply.381.1523279936623; Mon, 09 Apr 2018 06:18:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523279936; cv=none; d=google.com; s=arc-20160816; b=YawbBii/i33nccdOh0rUrQYjAOgIkBxxxT6gMH1I5ZpY7Jk+wY7lXnLyoZPms657BP mwaKtUP9zDuhut0Mx2lwgdij5IgtbWz7SDQrPMAma3bEFofXQEXWvbZf4gBAj0LnAuIY ZdZPvIvvTuZHGawIpXBkRcXVQUtU4rrG2+aYSAzQbs/oSStzVE3CZXIqupWEDVXsF8GR uhXtgCBslilvN5udVi/C+3zQZgzSfS1aDNAvkOw9xGw0WDXt+r4EUQQ8kLRGg71Wstxa J0NN0gzjr/lstqqOsF/RfiqrZlSRKU5zeY4yTrstJpc1jO8S6x264FIJkDuGtICJem9e 0+rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from :arc-authentication-results; bh=2AUdWCIXsaanpDpWSP0+0Fy0EGXFfrEKCgM0GvXwSDo=; b=oFEEiE4DjbwQ7xodYFutD1i8QLeqe4GzPRWLMhvOp3Uo3t689sor46zMqzrQOx/BfS bt67Ey7ztvJ+Xb/UdJsV0QyBhE2yNaE+RmcLaXU0vEsLfLlEClhcx0HN6SUtrQb6ffBL oIxaiq1gXFpTUQ5DDFDLdEBoAxnofuQWbSYx/6z7X+0taJNCCbCJZfFf0zhWyH1Vk235 9zm5hgE4+cwhU+1KkfV/NGWf8OVjjQ7XvM2Pz1eD1/yDafOdZr9S3ky1QWmnC20zLdWS iLmzb7dCsJhEKWSKUZDT9oa7gfOT3ew0goWRvpr/Gi4GC05ul50KRxC4yQPlD2OVUKQQ RWVQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w3-v6si308206plb.17.2018.04.09.06.18.19; Mon, 09 Apr 2018 06:18:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751667AbeDINOF convert rfc822-to-8bit (ORCPT + 99 others); Mon, 9 Apr 2018 09:14:05 -0400 Received: from smtp-out6.electric.net ([192.162.217.192]:59949 "EHLO smtp-out6.electric.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751291AbeDINOE (ORCPT ); Mon, 9 Apr 2018 09:14:04 -0400 Received: from 1f5WcO-000jOz-V7 by out6e.electric.net with emc1-ok (Exim 4.90_1) (envelope-from ) id 1f5WcR-000jny-W0; Mon, 09 Apr 2018 06:13:59 -0700 Received: by emcmailer; Mon, 09 Apr 2018 06:13:59 -0700 Received: from [156.67.243.126] (helo=AcuMS.aculab.com) by out6e.electric.net with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1f5WcO-000jOz-V7; Mon, 09 Apr 2018 06:13:56 -0700 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) by AcuMS.aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Mon, 9 Apr 2018 14:14:58 +0100 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Mon, 9 Apr 2018 14:14:58 +0100 From: David Laight To: "'kpark3469@gmail.com'" , "kernel-hardening@lists.openwall.com" CC: "catalin.marinas@arm.com" , "keescook@chromium.org" , "will.deacon@arm.com" , "mark.rutland@arm.com" , "james.morse@arm.com" , "panand@redhat.com" , "keun-o.park@darkmatter.ae" , "psodagud@codeaurora.org" , "jpoimboe@redhat.com" , "mingo@kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v3 3/3] x86: usercopy: reimplement arch_within_stack_frames with unwinder Thread-Topic: [PATCH v3 3/3] x86: usercopy: reimplement arch_within_stack_frames with unwinder Thread-Index: AQHTz/sSAuKS/MpI00yCw1px+eBQn6P4ZtyQ Date: Mon, 9 Apr 2018 13:14:58 +0000 Message-ID: References: <1523275156-29087-1-git-send-email-kpark3469@gmail.com> <1523275156-29087-2-git-send-email-kpark3469@gmail.com> <1523275156-29087-3-git-send-email-kpark3469@gmail.com> <1523275156-29087-4-git-send-email-kpark3469@gmail.com> In-Reply-To: <1523275156-29087-4-git-send-email-kpark3469@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.33] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Outbound-IP: 156.67.243.126 X-Env-From: David.Laight@ACULAB.COM X-Proto: esmtps X-Revdns: X-HELO: AcuMS.aculab.com X-TLS: TLSv1.2:ECDHE-RSA-AES256-SHA384:256 X-Authenticated_ID: X-PolicySMART: 3396946, 3397078 X-Virus-Status: Scanned by VirusSMART (c) X-Virus-Status: Scanned by VirusSMART (s) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: kpark3469@gmail.com > Sent: 09 April 2018 12:59 > > The old arch_within_stack_frames which used the frame pointer is > now reimplemented to use frame pointer unwinder apis. So the main > functionality is same as before. How much slower does this make the code? Following stack frames using %bp is reasonably quick. I can't imagine some of the other unwinder APIs being any where near that fast. While fine for fault tracebacks, using them during usercopy is likely to have measurable performance impact. David