Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <2047337098.98106.1523186884813@email.1und1.de>
References: <1523178315-30562-1-git-send-email-geert@linux-m68k.org> <2047337098.98106.1523186884813@email.1und1.de>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Mon, 9 Apr 2018 15:29:32 +0200
Message-ID: <CAMuHMdWua5swcrNsvB5pbiMpuSyHSSoQhYSaqeq0ctP2csPtTA@mail.gmail.com>
Subject: Re: [PATCH/RFC] soc: bcm2835: Make !RASPBERRYPI_FIRMWARE dummies
 return failure
To:     Stefan Wahren <stefan.wahren@i2se.com>
Cc:     Scott Branden <sbranden@broadcom.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Eric Anholt <eric@anholt.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        bcm-kernel-feedback-list@broadcom.com, Ray Jui <rjui@broadcom.com>,
        Dave Stevenson <dave.stevenson@raspberrypi.org>,
        Phil Elwell <phil@raspberrypi.org>,
        Arnd Bergmann <arnd@arndb.de>,
        linux-rpi-kernel <linux-rpi-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Stefan,

On Sun, Apr 8, 2018 at 1:28 PM, Stefan Wahren <stefan.wahren@i2se.com> wrot=
e:
>> Geert Uytterhoeven <geert@linux-m68k.org> hat am 8. April 2018 um 11:05 =
geschrieben:
>> If CONFIG_RASPBERRYPI_FIRMWARE=3Dn:
>>
>>     drivers/gpio/gpio-raspberrypi-exp.c: In function =E2=80=98rpi_exp_gp=
io_get_polarity=E2=80=99:
>>     drivers/gpio/gpio-raspberrypi-exp.c:71: warning: =E2=80=98get.polari=
ty=E2=80=99 is used uninitialized in this function
>>     drivers/gpio/gpio-raspberrypi-exp.c: In function =E2=80=98rpi_exp_gp=
io_get_direction=E2=80=99:
>>     drivers/gpio/gpio-raspberrypi-exp.c:150: warning: =E2=80=98get.direc=
tion=E2=80=99 is used uninitialized in this function
>>
>> The dummy firmware interface functions return 0, which means success,
>> causing subsequent code to make use of the never initialized output
>> parameter.
>
> i think this is more theoritical, because we need to get rpi_firmware fir=
st and in this case it's NULL.

Sure, I just want to get rid of the ugly warnings when compile-testing.
Most dummy functions for other subsystems return error codes.

>> Fix this by making the dummy functions return an error code (-ENOSYS)
>> instead.
>
> Anyway i'm okay with the change.

OK, thanks!

Gr{oetje,eeting}s,

                        Geert

--=20
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
.org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds