Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 9 Apr 2018 19:00:36 +0200 (CEST)
From:   Sebastian Ott <sebott@linux.ibm.com>
To:     Kees Cook <keescook@chromium.org>
cc:     Sebastian Ott <sebott@linux.vnet.ibm.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Heiko Carstens <heiko.carstens@de.ibm.com>,
        Martin Uecker <Martin.Uecker@med.uni-goettingen.de>,
        Ingo Molnar <mingo@kernel.org>,
        Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Subject: Re: [bisected] 3c8ba0d61d04ced9f8d9ff93977995a9e4e96e91 oopses on
 s390
In-Reply-To: <alpine.LFD.2.21.1804091809310.1698@schleppi>
References: <alpine.LFD.2.21.1804061125390.1819@schleppi> <CAGXu5jKTtU3fvqP-ygV51WcOAmTkm=y5fysKNv+k0crhJACtVg@mail.gmail.com> <alpine.LFD.2.21.1804091809310.1698@schleppi>
User-Agent: Alpine 2.21 (LFD 202 2017-01-01)
Organization: =?ISO-8859-15?Q?=22IBM_Deutschland_Research_&_Development_GmbH?=
 =?ISO-8859-15?Q?_=2F_Vorsitzende_des_Aufsichtsrats=3A_Martina?=
 =?ISO-8859-15?Q?_Koederitz_Gesch=E4ftsf=FChrung=3A_Dirk_Wittkopp?=
 =?ISO-8859-15?Q?_Sitz_der_Gesellschaft=3A_B=F6blingen_=2F_Reg?=
 =?ISO-8859-15?Q?istergericht=3A_Amtsgericht_Stuttgart=2C_HRB_2432?=
 =?ISO-8859-15?Q?94=22?=
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="-1463805262-326909844-1523293237=:1698"
Message-Id: <alpine.LFD.2.21.1804091854290.1698@schleppi>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

---1463805262-326909844-1523293237=:1698
Content-Type: text/plain; charset=US-ASCII

On Mon, 9 Apr 2018, Sebastian Ott wrote:
> On Fri, 6 Apr 2018, Kees Cook wrote:
> > On Fri, Apr 6, 2018 at 2:47 AM, Sebastian Ott <sebott@linux.vnet.ibm.com> wrote:
> > > Today's kernel oopsed on s390. Bisect points to:
> > > 3c8ba0d61d04 ("kernel.h: Retain constant expression output for max()/min()")
> > >
> > > [    1.898277] dasd-eckd 0.0.3304: DASD with 4 KB/block, 21636720 KB total size, 48 KB/track, compatible disk layout
> > > [    1.898308] ------------[ cut here ]------------
> > > [    1.898310] kernel BUG at block/bio.c:1798!
> > 
> > Well that's extremely bad. :(
> 
> What happened is that the bio build by the partition detection code was
> attempted to be split by the block layer because the block queue had a
> max_sector setting of 0. blk_queue_max_hw_sectors uses min_not_zero.
> 
> Both of the following return 0 on my machine:
> +       pr_warn("%u\n", min_not_zero(100, 1000));
> +       pr_warn("%u\n", min_not_zero(1000, 100));
> 
> So, we now know what failed...the question is why?

I copied these macros to a userspace program to easily test it on other
machines/compilers. ....maybe I did something wrong but min_not_zero did
not work - even on fedora on an x86 laptop.

Sebastian
---1463805262-326909844-1523293237=:1698
Content-Type: text/plain; name=test.c
Content-Transfer-Encoding: BASE64
Content-ID: <alpine.LFD.2.21.1804091900360.1698@schleppi>
Content-Description: 
Content-Disposition: attachment; filename=test.c

I2luY2x1ZGUgPHN0ZGlvLmg+DQoNCiNkZWZpbmUgX190eXBlY2hlY2soeCwg
eSkJCQkJXA0KCSghIShzaXplb2YoKHR5cGVvZih4KSAqKTEgPT0gKHR5cGVv
Zih5KSAqKTEpKSkNCg0KI2RlZmluZSBfX2lzX2NvbnN0ZXhwcih4KQkJCQkJ
CVwNCgkoc2l6ZW9mKGludCkgPT0gc2l6ZW9mKCooOCA/ICgodm9pZCAqKSgo
bG9uZykoeCkgKiAwbCkpIDogKGludCAqKTgpKSkNCg0KI2RlZmluZSBfX25v
X3NpZGVfZWZmZWN0cyh4LCB5KQkJCQlcDQoJKF9faXNfY29uc3RleHByKHgp
ICYmIF9faXNfY29uc3RleHByKHkpKQ0KDQojZGVmaW5lIF9fc2FmZV9jbXAo
eCwgeSkJCQkJCQlcDQoJKF9fdHlwZWNoZWNrKHgsIHkpICYmIF9fbm9fc2lk
ZV9lZmZlY3RzKHgsIHkpKQ0KDQojZGVmaW5lIF9fY21wKHgsIHksIG9wKSAg
ICAgICAgKCh4KSBvcCAoeSkgPyAoeCkgOiAoeSkpDQoNCiNkZWZpbmUgX19j
bXBfb25jZSh4LCB5LCBvcCkgKHsJCQlcDQoJCQl0eXBlb2YoeCkgX194ID0g
KHgpOyAgICBcDQoJCQl0eXBlb2YoeSkgX195ID0gKHkpOyAgICBcDQoJCQlf
X2NtcChfX3gsIF9feSwgb3ApOyB9KQ0KDQojZGVmaW5lIF9fY2FyZWZ1bF9j
bXAoeCwgeSwgb3ApCQkJCQkJXA0KCV9fYnVpbHRpbl9jaG9vc2VfZXhwcihf
X3NhZmVfY21wKHgsIHkpLAkJCQlcDQoJCQkgICAgICBfX2NtcCh4LCB5LCBv
cCksIF9fY21wX29uY2UoeCwgeSwgb3ApKQ0KDQojZGVmaW5lIG1pbih4LCB5
KSAgICAgIF9fY2FyZWZ1bF9jbXAoeCwgeSwgPCkNCiNkZWZpbmUgbWF4KHgs
IHkpICAgICAgX19jYXJlZnVsX2NtcCh4LCB5LCA+KQ0KDQojZGVmaW5lIG1p
bl90KHR5cGUsIHgsIHkpICAgICAgX19jYXJlZnVsX2NtcCgodHlwZSkoeCks
ICh0eXBlKSh5KSwgPCkNCiNkZWZpbmUgbWF4X3QodHlwZSwgeCwgeSkgICAg
ICBfX2NhcmVmdWxfY21wKCh0eXBlKSh4KSwgKHR5cGUpKHkpLCA+KQ0KDQoN
CiNkZWZpbmUgbWluX25vdF96ZXJvKHgsIHkpICh7CQkJCQkJXA0KCQkJdHlw
ZW9mKHgpIF9feCA9ICh4KTsJCQkJXA0KCQkJdHlwZW9mKHkpIF9feSA9ICh5
KTsJCQkJXA0KCQkJX194ID09IDAgPyBfX3kgOiAoKF9feSA9PSAwKSA/IF9f
eCA6IG1pbihfX3gsIF9feSkpOyB9KQ0KDQppbnQgbWFpbigpDQp7DQoJcHJp
bnRmKCJ0ZXN0ICV1XG4iLCBtaW5fbm90X3plcm8oMTAwLCAxMDAwKSk7DQoJ
cmV0dXJuIDA7DQp9DQo=

---1463805262-326909844-1523293237=:1698--