Received: by 10.213.65.68 with SMTP id h4csp2948265imn; Mon, 9 Apr 2018 11:40:51 -0700 (PDT) X-Google-Smtp-Source: AIpwx4++WGZsIOrPkXmTiZ9cuW3qsm2FWO8OjtgwdyroLK73pUWz2wBH9JNXXUMZIURbkigev5Ju X-Received: by 2002:a17:902:102:: with SMTP id 2-v6mr39979009plb.48.1523299251762; Mon, 09 Apr 2018 11:40:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523299251; cv=none; d=google.com; s=arc-20160816; b=iYKEdEm0EoyJQeUBS/nMlLyjS0FW2idUmY3GLchlfvjJSSpihz5BRwPYk4vECicV3h nDVTqa++h8viMAHxCQsFk2NiQNrFjmZjrObfzruQXYgmCMsXP6Hrva9dO3G3XApEKcth VaMSHV1XGgAT59EwWxB50OjvkzA6QB5lwppbNUn9raZHaNRJlNU93ysnNaa7fNC1hcmt AtlpTLNNBoafPzguY1RZNu6OwqYF9EDFa0acCI47i2emR3il6QeCNrbaEWtUh8GZMcuU 9pX6NURVWts4Wc2X+GmuqT5gTwOxJeEIj5eTGPGdCnsjoEvQD3O3n78n5UNoFBZjFLbX w4zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=AvezN0W1yxe3+J2RVpxXdNvjo04xUkWO0MIfpjCYtUs=; b=EvCRWRNUu5/WlPdL20u7U2/SoysMq2DIv3Gj6X5QcthlxbbWk9FCOQBmto+iVrRrXM r15RYr4N7GejG2ppnUVQs+9skxL3G1eiLGjlOK7p17he8xA/Lf9noDpnj0z5qthzKU3j QSXLHrSlRylmyZ4pXAc+MuNLeGX7aBdnRPa0b3t+KdUu8jX8oKYnAg+FA0eX49HZWT+p 9PBPwBl3csYDnkcAlg7zxy4sIDupmquEPNfSyPjgAjaEzcOJqRhfpby4EY7jy1Zstxi9 IBVT7Vt9NKJr8Du9gNh4z+5qLzX/wpAS8LW/xiH/47CNerKO7k0PHcxKpOZXHo2XmuNq 8oMQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s3-v6si762150plb.418.2018.04.09.11.40.14; Mon, 09 Apr 2018 11:40:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752163AbeDIShR (ORCPT + 99 others); Mon, 9 Apr 2018 14:37:17 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:46072 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751610AbeDIShQ (ORCPT ); Mon, 9 Apr 2018 14:37:16 -0400 Received: by mail-oi0-f65.google.com with SMTP id 71-v6so8623027oie.12; Mon, 09 Apr 2018 11:37:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=AvezN0W1yxe3+J2RVpxXdNvjo04xUkWO0MIfpjCYtUs=; b=Hm8zn2b40i8WN+fjaNznV335M0D+kt9TsRQy3igRPzaxY4g4NAUqYj/eY9zTbtbbEC n3ZoIJLGxXRE/J/tBu1ChKpZZNP2A+B5jvEjaOIBN9nvDjQYyJq1g0ADzZYw4vzRWGYY U+00QH9E8UG/8uf5v8NDR5+nzW/8n0GRqw5H4PfHuLbK+BVVkgZDRFFjYPZ0lX5TDQwV dd2RFT0j4oqXaqh0oFQnp1rrh9XNJU4avJd44gYVnqXJ1d5YZ+sVy28mkcqAswtp/L0/ AX5x2KOZ6AdnjeYjghCAWpueDsauit9wdxOyH0eaILcZIyAf4lrXqBXVI729ekp4ReAv muKQ== X-Gm-Message-State: ALQs6tDMu2xB1Gbm/DKqpShqP64+9Y+D4ftQncX6/jN2pYglfQHLdL+u 932IGxB27M0t64gorLVnfQ== X-Received: by 2002:aca:c68d:: with SMTP id w135-v6mr67675oif.215.1523299035263; Mon, 09 Apr 2018 11:37:15 -0700 (PDT) Received: from localhost (216-188-254-6.dyn.grandenetworks.net. [216.188.254.6]) by smtp.gmail.com with ESMTPSA id y9-v6sm572711oia.37.2018.04.09.11.37.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 09 Apr 2018 11:37:14 -0700 (PDT) Date: Mon, 9 Apr 2018 13:37:13 -0500 From: Rob Herring To: Peter Rosin Cc: linux-kernel@vger.kernel.org, David Airlie , Mark Rutland , Boris Brezillon , Nicolas Ferre , Alexandre Belloni , Archit Taneja , Andrzej Hajda , Laurent Pinchart , Daniel Vetter , Gustavo Padovan , Sean Paul , Jacopo Mondi , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 4/5] drm: bridge: lvds-encoder: allow specifying the input bus format Message-ID: <20180409183713.xk7qt4mukb24vr64@rob-hp-laptop> References: <20180326212447.7380-1-peda@axentia.se> <20180326212447.7380-5-peda@axentia.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180326212447.7380-5-peda@axentia.se> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 26, 2018 at 11:24:46PM +0200, Peter Rosin wrote: > If the bridge changes the bus format, allow this to be described in > the bridge, instead of providing false information about the bus > format of the connector or panel. I guess this is dead, but I'll comment here anyway because this issue has come up several times and I think something is needed. > > Signed-off-by: Peter Rosin > --- > .../bindings/display/bridge/lvds-transmitter.txt | 6 ++++++ > drivers/gpu/drm/bridge/lvds-encoder.c | 25 ++++++++++++++++++++++ > 2 files changed, 31 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt > index 50220190c203..8d40a2069252 100644 > --- a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt > +++ b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt > @@ -30,6 +30,12 @@ Required properties: > device-specific version corresponding to the device first > followed by the generic version. > > +Optional properties: > + > +- interface-pix-fmt: > + List of valid input bus formats of the encoder. Recognized bus formats > + are listed in ../bus-format.txt We already have bus interface properties defined in media/video-interfaces.txt. It's the same problem though the bus/pixel formats are somewhat different. "bus-width" is probably enough to handle your particular case, but I'd imagine that could easily not be the case. If so, we should extend the existing binding rather than diverge with something new. Rob