Received: by 10.213.65.68 with SMTP id h4csp3022103imn; Mon, 9 Apr 2018 12:53:42 -0700 (PDT) X-Google-Smtp-Source: AIpwx48kRPNSn3VhEahF9TPGU3Yi1CBE4tV0F9jGP6PkPbjHz9bYYv1wjBl0WIhWxPtdgpELXRJI X-Received: by 10.99.105.195 with SMTP id e186mr2546089pgc.353.1523303622751; Mon, 09 Apr 2018 12:53:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523303622; cv=none; d=google.com; s=arc-20160816; b=tWU0I4DaZA5Bz6uR8gxGq3x+kcWmkY+ZF3W/O7Lvt3yDpmUf7Rrb/ex6L2Tn7XTUJd MQfT28SQLsRX14qH2Yl6elYGbWuP332W6sSLXLlKS7LXl7iodP+wL/u6JX54H9MWMzcu AC/0hVaD5wjyZu8cnSYODhBp6nKCYSC/XxSfXYB42yh4h4a2w9Hgk8E8VLK8NJgM+mjZ SiW1xths5M/KrHo1As5dCtld/4YmXpLiH93UvHqIkwZ2ooEUrA2y9YdrnrBjMgVnGtFm W4TPaXX0mWV2rEm4KbCr5gZCcREEGjVU1L5qIpjntK9qP/Jq/3nxqxO9LCXjjGWAi7e6 hhIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:cc:references:to:subject:arc-authentication-results; bh=PcJ5zpqbaB+RnFSCHK6qXAr91OMlOLdXPRQsH8o9e+U=; b=B5KRT3Pk3ju3BpoK/Nub7wg9aAMIZTJNr8mf9YLDKo3rnKgvcyaWdAGAIeCSErFYfH lz1Ga/rrIFvDBXv2faPlXcdSpObSXsJjrEZZaHYxwFk45PSNAdUIiwcTwib52c6GWNUt xH3hm3bUh811FwO4CZpJUW8UeZ/wSrmP5FF1FXBC946FBxB7HSDjmi6iNilhnFv8wSwV hGxY3NSFVKow3pHcFJcYc1VZAjm/D7ozyGR/PJ7lHCqfx2oEUzU5dTJRjhXTUgNtW2Z/ C7njrX7QZJHj34B3CDum/juYxAIYYaY/Fzt6k1oIYc7Noo7ySA3baleYlcXt7pZAHoe2 ZHzA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g61-v6si893742plb.686.2018.04.09.12.53.04; Mon, 09 Apr 2018 12:53:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753818AbeDITuX (ORCPT + 99 others); Mon, 9 Apr 2018 15:50:23 -0400 Received: from mga07.intel.com ([134.134.136.100]:25634 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751549AbeDITuW (ORCPT ); Mon, 9 Apr 2018 15:50:22 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Apr 2018 12:50:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,427,1517904000"; d="scan'208";a="32920959" Received: from ray.jf.intel.com (HELO [10.7.201.24]) ([10.7.201.24]) by orsmga006.jf.intel.com with ESMTP; 09 Apr 2018 12:50:21 -0700 Subject: Re: [PATCH 00/11] [v5] Use global pages with PTI To: Tom Lendacky , linux-kernel@vger.kernel.org References: <20180406205501.24A1A4E7@viggo.jf.intel.com> <1b45ffd1-99bb-4ac1-fb65-0de3e42c1c0a@amd.com> Cc: linux-mm@kvack.org, aarcange@redhat.com, luto@kernel.org, torvalds@linux-foundation.org, keescook@google.com, hughd@google.com, jgross@suse.com, x86@kernel.org, namit@vmware.com From: Dave Hansen Message-ID: Date: Mon, 9 Apr 2018 12:50:20 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1b45ffd1-99bb-4ac1-fb65-0de3e42c1c0a@amd.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/09/2018 11:59 AM, Tom Lendacky wrote: > On 4/9/2018 1:17 PM, Dave Hansen wrote: >> On 04/09/2018 11:04 AM, Tom Lendacky wrote: >>> On 4/6/2018 3:55 PM, Dave Hansen wrote: >>>> Changes from v4 >>>> * Fix compile error reported by Tom Lendacky >>> This built with CONFIG_RANDOMIZE_BASE=y, but failed to boot successfully. >>> I think you're missing the initialization of __default_kernel_pte_mask in >>> kaslr.c. >> >> This should be simple to fix (just add a -1 instead of 0), but let me >> double-check and actually boot the fix. > > Yup, added an "= ~0" and everything is good. I'm testing at this commit in the tip tree: 0564258... x86/pti: Leave kernel text global for !PCID It seems to boot OK with RANDOMIZE_BASE=y for both PCID and non-PCID configuration. Could you send along your .config so I can try to reproduce?