Received: by 10.213.65.68 with SMTP id h4csp3135804imn; Mon, 9 Apr 2018 15:07:37 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/59QLtTN0VTzO2CvZdL66SlxaR3tI5+A3xkna7c4GQYUSnqNqQUXljYpQLOH/AQky0yMUA X-Received: by 10.101.97.15 with SMTP id z15mr26311964pgu.393.1523311657471; Mon, 09 Apr 2018 15:07:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523311657; cv=none; d=google.com; s=arc-20160816; b=pFQ1JoJBBT+n/Ll8NZx9MRXFQ2x0z240udjYBeZALHUg0ioH+aicpBR8jt6m3Xf1gw 823dqNYRgPlL+IogNHxTKNf30pYOh+jnRKxvdDYEqNZ5g199CJmgnqXGes5Onse0giKg Rsj8OOHmC1oy94HYS3CUpFhQSbb7v5wFlVSxfi9TPo3RASvw5KFUTk0SNDZLP4l+8O+q ZGBbFTOALG2+aXX0C9Fv8CM8W2A5wt9hsLHSrLZgZJh5tu8P81ZzwGLPCdjfeFUS4MR4 GC8LQee8GwDuI9KiNnkxnjOTC+IgWdJLGXujHJx1G2OLGLOdxfllCPzqLfPCzMc8Ooul mKxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=BdtzyxkueXa0t/KRCFoPmMsdbR+TGmVkP6KmZX4KtqY=; b=DvA2HgoAWHmcUuv3GTGchN3QozMjPdRNP5yIw7cLnu08vBkv0k3xjfC1MImqf4KV53 KBtj91rGqBwwyzpOCiINz16Dyleq+0EtyOW0307nAgJwf9D0CBe5FNVVQc9rXCGAN/7c 6Zv1Rr48hLOMEJ6515u1PlP62ylmeuEp4c2eSTUnLuBu598dsZTtSLpb3tfzeoLzWO/h wn96QBxSwsuOwsAc7EPHNu6kGmNSty7uEMZaeABt2NzC8DY4qNcdf4vXi7EA+NreqMVE NtHNLxjul7PcxYd9bWwIUxDx5QlHmnCoNRs3BJV6l644aIKf3y/7ajjQzzfJB1p696bW Xk7A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k2si792099pgf.691.2018.04.09.15.07.00; Mon, 09 Apr 2018 15:07:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752863AbeDIOhs (ORCPT + 99 others); Mon, 9 Apr 2018 10:37:48 -0400 Received: from mail.us.es ([193.147.175.20]:33464 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752724AbeDIOhq (ORCPT ); Mon, 9 Apr 2018 10:37:46 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 78E68396277 for ; Mon, 9 Apr 2018 16:37:18 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 65D60CA0E1 for ; Mon, 9 Apr 2018 16:37:18 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 5B368DA727; Mon, 9 Apr 2018 16:37:18 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 8516ACA0E3; Mon, 9 Apr 2018 16:37:16 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Mon, 09 Apr 2018 16:37:16 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (sys.soleta.eu [212.170.55.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 4F7354265A2F; Mon, 9 Apr 2018 16:37:16 +0200 (CEST) Date: Mon, 9 Apr 2018 16:37:41 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Arnd Bergmann Cc: Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: fix CONFIG_NF_REJECT_IPV6=m link error Message-ID: <20180409143741.dzooqrzcgi2bnvd5@salvia> References: <20180409105322.2247296-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="iojt55x3tnaul5vo" Content-Disposition: inline In-Reply-To: <20180409105322.2247296-1-arnd@arndb.de> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --iojt55x3tnaul5vo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Arnd, On Mon, Apr 09, 2018 at 12:53:12PM +0200, Arnd Bergmann wrote: > We get a new link error with CONFIG_NFT_REJECT_INET=y and CONFIG_NF_REJECT_IPV6=m I think we can update NFT_REJECT_INET so it depends on NFT_REJECT_IPV4 and NFT_REJECT_IPV6. This doesn't allow here CONFIG_NFT_REJECT_INET=y and CONFIG_NF_REJECT_IPV6=m. I mean, just like we do with NFT_FIB_INET. BTW, I think this problem has been is not related to the recent patch, but something older that kbuild robot has triggered more easily for some reason? Thanks for your patch! --iojt55x3tnaul5vo Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="x.patch" diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig index d3220b43c832..b48c57bb9aaf 100644 --- a/net/netfilter/Kconfig +++ b/net/netfilter/Kconfig @@ -601,7 +601,8 @@ config NFT_REJECT config NFT_REJECT_INET depends on NF_TABLES_INET - default NFT_REJECT + depends on NFT_REJECT_IPV4 + depends on NFT_REJECT_IPV6 tristate config NFT_COMPAT --iojt55x3tnaul5vo--