Received: by 10.213.65.68 with SMTP id h4csp3142782imn; Mon, 9 Apr 2018 15:14:29 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+rii3FMtpPA9vlRd+4vmJNiQ4pbumhvBwAsAdTRigf66m8Ecjt/PSbLgOi7yL/t5nRyILZ X-Received: by 2002:a17:902:7793:: with SMTP id o19-v6mr7438950pll.349.1523312069761; Mon, 09 Apr 2018 15:14:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523312069; cv=none; d=google.com; s=arc-20160816; b=pQYKZ7y0o9eivCsaypEh26RUacXmiUOJ+yuZjITijOL8KbIyAK7190M/AwWEDzZQhA U2nrHzqqmT0rxprcY8Z0hJvo+bjOXiLwKNwufWyQIpdwhtCegdHyoFkFUJlh2JYOoDdV lG9fEepQW2jiyuwZ0XKDelkKzSx60exu9BLElEbKSt8uy9BpRX6xxn5u2jwrVHZIXut4 vT1u9xSiske/m4zgUp55hfnzfNQ64O3yUhdu3sqXevuoA2pD/dW0LtI3PvX6890Kt6cA zg84BYQWKWJemx/YHFhx2pW1fTHpMoIpziWYCBf/7mwLx/HiEnGLlg2nhpaYuS2jzwwu spMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition :content-transfer-encoding:mime-version:robot-unsubscribe:robot-id :git-commit-id:subject:to:references:in-reply-to:reply-to:cc :message-id:from:date:arc-authentication-results; bh=+u84+BPGm5nChFbdXZvLFLvWBQbCA5A9pkrVEz/U670=; b=FVZC3UAi+Wz6MHQqhdSUyBTceOpI1wnEYfS4XDytpGICimjdqP1t0Sl2Gdn4qtjYBO CJPeB4YwjRb8eOkqvhnlbIGRFz68PMQJUI4PQ/yKvnPDrbm9Jfxgc0tGyz8t57XhxWeO G6fIIn2P/iTmkQGJaSYD1K8lFhQQQXWUOKHY16un4pwIs/J/hOYI5M9hqIVQxcxS/Pwu XfRVmYvpji9GIOS8SeOUKEAaJcURLGmJOzJDdmfa5oCkIsWh2hitfzapQwYfU+nk5rZu x1QuECBWp/bGpIgRVPyNC6tpQZeGoB3hVt948BRT7x30wmkpniVq5AA2Lf6j3bLfj5Zf aTVg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t190si780457pgt.745.2018.04.09.15.13.52; Mon, 09 Apr 2018 15:14:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753983AbeDIRPp (ORCPT + 99 others); Mon, 9 Apr 2018 13:15:45 -0400 Received: from terminus.zytor.com ([198.137.202.136]:48241 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753956AbeDIRPn (ORCPT ); Mon, 9 Apr 2018 13:15:43 -0400 Received: from terminus.zytor.com (localhost [127.0.0.1]) by terminus.zytor.com (8.15.2/8.15.2) with ESMTP id w39HEgJa1894417; Mon, 9 Apr 2018 10:14:42 -0700 Received: (from tipbot@localhost) by terminus.zytor.com (8.15.2/8.15.2/Submit) id w39HEfGZ1894414; Mon, 9 Apr 2018 10:14:41 -0700 Date: Mon, 9 Apr 2018 10:14:41 -0700 X-Authentication-Warning: terminus.zytor.com: tipbot set sender to tipbot@zytor.com using -f From: tip-bot for Dave Hansen Message-ID: Cc: bp@alien8.de, peterz@infradead.org, arjan@linux.intel.com, gregkh@linuxfoundation.org, hughd@google.com, tglx@linutronix.de, aarcange@redhat.com, hpa@zytor.com, mingo@kernel.org, jpoimboe@redhat.com, linux-kernel@vger.kernel.org, namit@vmware.com, dave.hansen@linux.intel.com, torvalds@linux-foundation.org, luto@kernel.org, dan.j.williams@intel.com, keescook@google.com, jgross@suse.com, dwmw2@infradead.org Reply-To: jgross@suse.com, dwmw2@infradead.org, keescook@google.com, luto@kernel.org, dan.j.williams@intel.com, torvalds@linux-foundation.org, namit@vmware.com, dave.hansen@linux.intel.com, linux-kernel@vger.kernel.org, jpoimboe@redhat.com, mingo@kernel.org, hpa@zytor.com, tglx@linutronix.de, hughd@google.com, aarcange@redhat.com, gregkh@linuxfoundation.org, peterz@infradead.org, arjan@linux.intel.com, bp@alien8.de In-Reply-To: <20180406205513.079BB265@viggo.jf.intel.com> References: <20180406205513.079BB265@viggo.jf.intel.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/pti] x86/mm: Comment _PAGE_GLOBAL mystery Git-Commit-ID: 4ddee6efdcd0259fdd5014312bd536325e6d3429 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on terminus.zytor.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 4ddee6efdcd0259fdd5014312bd536325e6d3429 Gitweb: https://git.kernel.org/tip/4ddee6efdcd0259fdd5014312bd536325e6d3429 Author: Dave Hansen AuthorDate: Fri, 6 Apr 2018 13:55:13 -0700 Committer: Ingo Molnar CommitDate: Mon, 9 Apr 2018 18:27:33 +0200 x86/mm: Comment _PAGE_GLOBAL mystery I was mystified as to where the _PAGE_GLOBAL in the kernel page tables for kernel text came from. I audited all the places I could find, but I missed one: head_64.S. The page tables that we create in here live for a long time, and they also have _PAGE_GLOBAL set, despite whether the processor supports it or not. It's harmless, and we got *lucky* that the pageattr code accidentally clears it when we wipe it out of __supported_pte_mask and then later try to mark kernel text read-only. Comment some of these properties to make it easier to find and understand in the future. Signed-off-by: Dave Hansen Cc: Andrea Arcangeli Cc: Andy Lutomirski Cc: Arjan van de Ven Cc: Borislav Petkov Cc: Dan Williams Cc: David Woodhouse Cc: Greg Kroah-Hartman Cc: Hugh Dickins Cc: Josh Poimboeuf Cc: Juergen Gross Cc: Kees Cook Cc: Linus Torvalds Cc: Nadav Amit Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: linux-mm@kvack.org Link: http://lkml.kernel.org/r/20180406205513.079BB265@viggo.jf.intel.com Signed-off-by: Ingo Molnar --- arch/x86/kernel/head_64.S | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/head_64.S b/arch/x86/kernel/head_64.S index 48385c1074a5..8344dd2f310a 100644 --- a/arch/x86/kernel/head_64.S +++ b/arch/x86/kernel/head_64.S @@ -399,8 +399,13 @@ NEXT_PAGE(level3_ident_pgt) .quad level2_ident_pgt - __START_KERNEL_map + _KERNPG_TABLE_NOENC .fill 511, 8, 0 NEXT_PAGE(level2_ident_pgt) - /* Since I easily can, map the first 1G. + /* + * Since I easily can, map the first 1G. * Don't set NX because code runs from these pages. + * + * Note: This sets _PAGE_GLOBAL despite whether + * the CPU supports it or it is enabled. But, + * the CPU should ignore the bit. */ PMDS(0, __PAGE_KERNEL_IDENT_LARGE_EXEC, PTRS_PER_PMD) #else @@ -431,6 +436,10 @@ NEXT_PAGE(level2_kernel_pgt) * (NOTE: at +512MB starts the module area, see MODULES_VADDR. * If you want to increase this then increase MODULES_VADDR * too.) + * + * This table is eventually used by the kernel during normal + * runtime. Care must be taken to clear out undesired bits + * later, like _PAGE_RW or _PAGE_GLOBAL in some cases. */ PMDS(0, __PAGE_KERNEL_LARGE_EXEC, KERNEL_IMAGE_SIZE/PMD_SIZE)