Received: by 10.213.65.68 with SMTP id h4csp3290897imn; Mon, 9 Apr 2018 18:22:34 -0700 (PDT) X-Google-Smtp-Source: AIpwx490VZRG3ldX7ZFzDxw9G+IZ/D3qap8leDadT6chWSuofA7R0cAVDarSt0yYw8jdGf+anor5 X-Received: by 10.99.36.7 with SMTP id k7mr5284435pgk.63.1523323354369; Mon, 09 Apr 2018 18:22:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523323354; cv=none; d=google.com; s=arc-20160816; b=vQ0Q26FlzuDRVt9i0ShWBA8Xdi3oyXzp8bThSpg1wajiuKk45ilkDsaVP+8ssuCims 0MjxqYuXlN7R1pXfb9xocyuzKVVdebIi8MvQwxaqrr+ys+2xvOd2WWvt037K2wrCM2jj nYdmEA1jrF9eAP+UA/QiVmPoMSoojEJv2AZuSSesxY0QfIeR5JmJZj/r9DACvOb4QaQQ 4x8LlvnrBcKJQXKMy6D/fU4OkiBKSlrOndaykdxlIMOOgMZB3q6W7YasleMDm+V9I1yH CJmMqThSq6BSyOoB07S/fP0PPleg6enjFo8Szxb5YzrGkWNEPl306kNK8l/uxF381Peu ankA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature:arc-authentication-results; bh=1L3D8t/SKS8MRamksIfnqsPJeyCalEw/Z6J3/ukbnyI=; b=0YY1ye6OU8zPGgO5hRohxDDIkmHWmyQmmFmLn+PLtdacDuPILd1SadX1EAyjm44rDL 47no4vgWeonLrM1lrgGRGocfAzULv9QvgNqrrG1DfW8Js1gFHrkzGQ3P6uCoYjvp/rhG UdqvvxPiYqzUhDPSimPC61Pd9KpTyvzXPo++03mVAK7PIjpd/EB5FvsqYt7LLjISWYy3 Y6NEWv4arD/+Cn7ayjuXyDuAnAQdPMSKfkr2jlus+e2Nf4ulg7VWLdeUKUOfjQM8W6Iu 75WoeD/otRg7G60gx6j3Cr7TyB+0vLCuP2cW6bLuEYZB/mTJMpMHIBwcR1JanA37v89O +cAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=ahMPtSyl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 32-v6si1447357plg.578.2018.04.09.18.21.58; Mon, 09 Apr 2018 18:22:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=ahMPtSyl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752470AbeDJBSJ (ORCPT + 99 others); Mon, 9 Apr 2018 21:18:09 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:41370 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752083AbeDJBSH (ORCPT ); Mon, 9 Apr 2018 21:18:07 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w3A1Fw2R120130; Tue, 10 Apr 2018 01:18:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2017-10-26; bh=1L3D8t/SKS8MRamksIfnqsPJeyCalEw/Z6J3/ukbnyI=; b=ahMPtSyl5snOoJ483yzmxB3a+7ay31xkhZ2SJtNoB3gBPhjafc4FU+8uWFTJgqSxQ9fB zNRnwE07fEEmMhZni1EufwCviW6HdxrnJ2lu+SUcsKbjUjOnzbbzTFM5g4ZcdREAucGz B3gsd+VK4pjP0x1FPAUEw8SdJ7L43LvbanCU8LZXV5VSC8wgi9F5jD76IQTNAGsZIkq9 Cgq/yj4aifmIB0z1JrAL9pAtDb7leVzO/wRN3KdtCp3RPzMuXkGrhSrzTYo6VSNjyqOB NdF6o5jGp5Wwuxmx21T7mHTU2fuVuYy10fEjN43OTbx0qff40x1yiwd0FNtg5EJT5HBn 4A== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2120.oracle.com with ESMTP id 2h6pn4fs7y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 10 Apr 2018 01:18:03 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w3A1I2vj013977 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 10 Apr 2018 01:18:03 GMT Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w3A1I2CI005076; Tue, 10 Apr 2018 01:18:02 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 09 Apr 2018 18:18:01 -0700 To: Johannes Thumshirn Cc: "Martin K . Petersen" , Bart Van Assche , Linux Kernel Mailinglist , Linux SCSI Mailinglist Subject: Re: [PATCH v2] qla2xxx: correctly shift host byte From: "Martin K. Petersen" Organization: Oracle Corporation References: <20180409122423.32231-1-jthumshirn@suse.de> Date: Mon, 09 Apr 2018 21:17:59 -0400 In-Reply-To: <20180409122423.32231-1-jthumshirn@suse.de> (Johannes Thumshirn's message of "Mon, 9 Apr 2018 14:24:23 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8858 signatures=668698 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=637 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1804100012 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Johannes, > The SCSI host byte has to be shifted by 16 not 6. > > As Bart pointed out this patch does not change any functionality > because DID_OK == 0, but a wrong shift is irritating for the reviewer. Applied to 4.17/scsi-fixes. Thank you! -- Martin K. Petersen Oracle Linux Engineering