Received: by 10.213.65.68 with SMTP id h4csp3291813imn; Mon, 9 Apr 2018 18:23:47 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/7H33peN2eH5NFdr4afKGAU8sM7EKqMyH9xspeOBBsxY1NGSW6B4b8Hs0serXMWZfbi1zY X-Received: by 10.101.100.68 with SMTP id s4mr5590003pgv.407.1523323427075; Mon, 09 Apr 2018 18:23:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523323427; cv=none; d=google.com; s=arc-20160816; b=RsNG66Jwq20J79pF1ZqrrIicawuG2HUtqMBSK4p5rLq/Wa3rmixElXrbJAnssPpQY7 GWzvZn9xjgNhOKAl/ERQZnZgzl94e3pVi85fAcydzRZQdc7wD9bv2SmcxLgt3iIB0pVj LPryidA/mo/aU5/je8G4S/b3+VH3N4/SLfh5NT13SHga+UYgA9Lv6OnyG9sEp+6S225a NOWGdp/TzCTuM7WJrv0PH+55WAvZZ9KQum+RENOagW55CeRfqB1fVqVaeKYP0k/W0htY 4mCtisGPKShDMr7GerOzgQobH9YJWo45ZrSrB45J7DkFAb3wk2Kf0H2n2eKKKjf6UEVk g5Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature:arc-authentication-results; bh=yGZ06k3dvzDPB1jQyCuXVT8rABPmUC8jD61ZJJfv4ik=; b=JzUU8PXAfo7fM6PaBgHgA4/APaTotYfGN6YqHOtc4svcsalVvKcq5lIuuFztjGAhb7 ncf1lhKCiXcLQJ9MYXAf3crAKZZXjsosJtQEbm4X4iRAZ7IIJeldDj4aaKGCozzbG/i6 yYJf25pCURCpBbM3NE3p0Ynjkf8CuhAUgYsOMHljSijrDUh43VTsMZftC/AVKlKIFir4 dRusx3sDYT8hBbQBZHriWLBVl8hdMv2qeIaiMtm9FIhZxTOodN42bwzoa8/6L9skhesU cd6nqUAwTv0Gtw2NSe+iTMR5+ZvJh3GMnn9KvdAHNxLkfZevnUhK7bQRL4Fe/Ej2aF0+ ZZcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=saNgc416; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j91-v6si1401998pld.14.2018.04.09.18.23.10; Mon, 09 Apr 2018 18:23:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=saNgc416; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751991AbeDJBTG (ORCPT + 99 others); Mon, 9 Apr 2018 21:19:06 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:42108 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751367AbeDJBTF (ORCPT ); Mon, 9 Apr 2018 21:19:05 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w3A1G3sJ120169; Tue, 10 Apr 2018 01:18:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2017-10-26; bh=yGZ06k3dvzDPB1jQyCuXVT8rABPmUC8jD61ZJJfv4ik=; b=saNgc416AVKJi+2ZxC3HI03XTaiToAjQ8Zj3GrRcMLmJVhppZvCGeDak+AAHg3i4fYQ9 maRRgicXTr3t0V99l9tx7pTukftoXCO0MmaFEUSM2tosvFtTCdFdQEILIiYSj18UYDtL CfTgDcRtUQIm/J4E5/+SGOyz+wZ7LKY05Wohn0iTdS1TYbrMzgDL9/Ovo6vRBZYM4iYW 0gaJZmi/SLASIOxqjNjkpHvZuqPOODzQOz5CpcU1/FheAVGgMlFlZ7ZpkjEM147cHFF4 JwBRychCO+zc2oDI2BI1k0fu/PEeDgaUiTqmz99S+MZh8JWbldSt4q+N6ZatKienTJoq FA== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2120.oracle.com with ESMTP id 2h6pn4fsbr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 10 Apr 2018 01:18:59 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w3A1IxTw015769 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 10 Apr 2018 01:18:59 GMT Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w3A1IxcJ002338; Tue, 10 Apr 2018 01:18:59 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 09 Apr 2018 18:18:58 -0700 To: Johannes Thumshirn Cc: "Martin K . Petersen" , Linux Kernel Mailinglist , Linux SCSI Mailinglist , Bart Van Assche , Hannes Reinecke , Himanshu Madhani Subject: Re: [PATCH] scsi: qla2xxx: Correct setting of SAM_STAT_CHECK_CONDITION From: "Martin K. Petersen" Organization: Oracle Corporation References: <20180409123922.854-1-jthumshirn@suse.de> Date: Mon, 09 Apr 2018 21:18:56 -0400 In-Reply-To: <20180409123922.854-1-jthumshirn@suse.de> (Johannes Thumshirn's message of "Mon, 9 Apr 2018 14:39:22 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8858 signatures=668698 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=524 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1804100012 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Johannes, > Bart reports that in qla_isr.c's qla2x00_handle_dif_error we're > wrongly shifting the SAM_STAT_CHECK_CONDITION by one instead of > directly ORing it onto the SCSI command's result. Applied to 4.17/scsi-fixes. Thx! -- Martin K. Petersen Oracle Linux Engineering