Received: by 10.213.65.68 with SMTP id h4csp3482720imn; Mon, 9 Apr 2018 22:53:29 -0700 (PDT) X-Google-Smtp-Source: AIpwx48HURn+VCOJAiHIlYgnYi0LT4ta/TnCjcVpk58vGe6lwbzffS75ir7gvIaUCWwYDh8IhU6g X-Received: by 10.101.102.153 with SMTP id b25mr17038390pgw.293.1523339609809; Mon, 09 Apr 2018 22:53:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523339609; cv=none; d=google.com; s=arc-20160816; b=TsBA3wHkj3/PWj9uaAZVXJtYcgdvk8MqrgsbSHTLSCam/Z21453svHFlzJX/8bsHZW 5h5oyOBWk16lqNKiGBKPT3Zi19d5d70p1ez2gjMoEJjeuELfMlmstAOrIRmCj/aq351Q eBTB1sj4f/wlF3mvj9ToEbEidAz++uaS9x1QknQbzqitU+BNhAzvRQaNp4WQVDP1KGVC MvrQPktEMGWyTmthiXGMhPzvkJ/OIx8/+IFQegDQAflVYi4kVWKLSyofPg+5vKAbR/VT pmb4D5xzwLAf+1XOZEGp9GHdu1qHBtFzLayjkiXI7k/HZNfmRSLaF/wHldFOqkPMD8TA BEQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :subject:cc:to:from:date:arc-authentication-results; bh=VJQCIL+1pKVqTqsNgsM2x4TIOsRp+AHcIlCDdleth/I=; b=IzJ7VJOLBDXJeI9BWzNraQyfAf4szbtlt+rnrtRn2nECcr+iHOLYdhBQH6tFdQye1K q+Iu3/bS5i2nK0xEiv1jWURIiBuekzaeT8p4b7MFXY2iGBc+ft/rwPHaHIKfYl57nAtd ZZQAOOJ1ioQfxQnrTcBlnz+oRvRDsOxIJsonaiQBENlw2/6mA7N1mO1kzaSZjrNxMxzm FEpGMAvXAjZARDxTTNNrhaT6NdxBSRe9wiY/KZx0WgvPhNKdOswO7IZ/9OYB24oeEj1W ZHdXWymxYRBEz27KevRiZHI7lkJhEBz/BYYxUR5S2CCG3/cvuIvXbCdks6Vgqf20H5ED +SvA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y62si1519822pfd.309.2018.04.09.22.52.52; Mon, 09 Apr 2018 22:53:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752076AbeDJFto (ORCPT + 99 others); Tue, 10 Apr 2018 01:49:44 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:61507 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751589AbeDJFtn (ORCPT ); Tue, 10 Apr 2018 01:49:43 -0400 X-IronPort-AV: E=Sophos;i="5.48,430,1517871600"; d="scan'208";a="261452898" Received: from ip-146.net-89-2-7.rev.numericable.fr (HELO [192.168.0.15]) ([89.2.7.146]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2018 07:49:41 +0200 Date: Tue, 10 Apr 2018 07:49:40 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Hyun Kwon cc: Michal Simek , Laurent Pinchart , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kbuild-all@01.org Subject: [PATCH] drm: xlnx: pl_disp: fix odd_ptr_err.cocci warnings Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Fengguang Wu PTR_ERR should normally access the value just tested by IS_ERR Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci Fixes: 742243a44a73 ("drm: xlnx: pl_disp: Use xlnx pipeline calls") CC: Hyun Kwon Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall --- tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v4.14 head: fe04d2ee0dfea6b5fdbb04f4f6dbcaa13bfd2fda commit: 742243a44a738b165f8da5cbdb6662139e85a5c5 [651/842] drm: xlnx: pl_disp: Use xlnx pipeline calls xlnx_pl_disp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/gpu/drm/xlnx/xlnx_pl_disp.c +++ b/drivers/gpu/drm/xlnx/xlnx_pl_disp.c @@ -482,7 +482,7 @@ static int xlnx_pl_disp_probe(struct pla xlnx_pl_disp->master = xlnx_drm_pipeline_init(pdev); if (IS_ERR(xlnx_pl_disp->master)) { - ret = PTR_ERR(xlnx_pl_disp->dev); + ret = PTR_ERR(xlnx_pl_disp->master); dev_err(dev, "failed to initialize the drm pipeline\n"); goto err_component; }